0000464: Louder/duplicate DSOOF sounds from other players online

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000464

Zandronum

[All Projects] Bug

public

2011-05-23 09:04

2018-09-30 19:51

Reporter

unknownna

Assigned To

TIHan

Priority

low

Severity

trivial

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

98d

Target Version

Fixed in Version

1.0

Summary

0000464: Louder/duplicate DSOOF sounds from other players online

Description

I noticed that some sounds from other players are louder online.

Steps To Reproduce

1. Start a server with the example WAD loaded.
2. Connect 2 clients to the server.
3. Join the game with both clients.
4. "snd_sfxvolume 0" in the console with client A.
5. Drop down with client A.

Client B will hear a duplicate DSOOF sound when client A drops down. But if client A jumps down, no duplicate DSOOF sound will be present.

Attached Files

dsoof_vol_test_01.wad [^] (2,694 bytes) 2011-05-23 09:04

Relationships

related to	0000303	closed	Dusk	A_FireCustomMissile plays multiple sounds online
related to	0002393	confirmed		Duplicate/Fast chainsaw idle sounds from other players depending on your ping

Notes
(0002882) TIHan (reporter) 2012-03-25 08:27	Fixed. 'https://bitbucket.org/TIHan/tst/changeset/b5dcc44ad7a3 [^]' Took me a little bit to find this specific function: NETWORK_IsConsolePlayerOrNotInClientMode. Very helpful. :)

(0002888) Torr Samaho (administrator) 2012-03-25 14:04	>'https://bitbucket.org/TIHan/tst/changeset/b5dcc44ad7a3 [^]' I added your patch with a small modification: Since it's not guaranteed that ZDoom in the future won't put non-sound code below the check you added, I moved the check into the if condition that is responsible for the sound. Which variant is better really depends on how the ZDoom code there will evolve, currently both should lead to the exactly same result. > NETWORK_IsConsolePlayerOrNotInClientMode. Very helpful. :) Over the years I introduced functions for most occasions :), it just takes some time to get an overview of what's available.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-05-23 09:04	unknownna	New Issue
2011-05-23 09:04	unknownna	File Added: dsoof_vol_test_01.wad
2011-05-23 09:06	unknownna	Relationship added	related to 0000303
2012-03-25 03:00	TIHan	Assigned To	=> TIHan
2012-03-25 03:00	TIHan	Status	new => assigned
2012-03-25 08:27	TIHan	Note Added: 0002882
2012-03-25 14:04	Torr Samaho	Note Added: 0002888
2012-03-25 14:04	Torr Samaho	Status	assigned => resolved
2012-03-25 14:04	Torr Samaho	Fixed in Version	=> 1.0
2012-03-25 14:04	Torr Samaho	Resolution	open => fixed
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2015-08-09 17:55	unknownna	Relationship added	related to 0002393
2018-09-30 19:51	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.