MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000464Zandronum[All Projects] Bugpublic2011-05-23 09:042018-09-30 19:51
Reporterunknownna 
Assigned ToTIHan 
PrioritylowSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version1.0 
Summary0000464: Louder/duplicate DSOOF sounds from other players online
DescriptionI noticed that some sounds from other players are louder online.
Steps To Reproduce1. Start a server with the example WAD loaded.
2. Connect 2 clients to the server.
3. Join the game with both clients.
4. "snd_sfxvolume 0" in the console with client A.
5. Drop down with client A.

Client B will hear a duplicate DSOOF sound when client A drops down. But if client A jumps down, no duplicate DSOOF sound will be present.
Additional Information
TagsNo tags attached.
Relationships
related to 0000303closed Dusk A_FireCustomMissile plays multiple sounds online 
related to 0002393confirmed  Duplicate/Fast chainsaw idle sounds from other players depending on your ping 
Attached Files? dsoof_vol_test_01.wad (2,694) 2011-05-23 09:04
/tracker/file_download.php?file_id=338&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-05-23 09:04unknownnaNew Issue
2011-05-23 09:04unknownnaFile Added: dsoof_vol_test_01.wad
2011-05-23 09:06unknownnaRelationship addedrelated to 0000303
2012-03-25 03:00TIHanAssigned To => TIHan
2012-03-25 03:00TIHanStatusnew => assigned
2012-03-25 08:27TIHanNote Added: 0002882
2012-03-25 14:04Torr SamahoNote Added: 0002888
2012-03-25 14:04Torr SamahoStatusassigned => resolved
2012-03-25 14:04Torr SamahoFixed in Version => 1.0
2012-03-25 14:04Torr SamahoResolutionopen => fixed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2015-08-09 17:55unknownnaRelationship addedrelated to 0002393
2018-09-30 19:51Blzut3Statusresolved => closed

Notes
(0002882)
TIHan   
2012-03-25 08:27   
Fixed.
'https://bitbucket.org/TIHan/tst/changeset/b5dcc44ad7a3 [^]'

Took me a little bit to find this specific function: NETWORK_IsConsolePlayerOrNotInClientMode. Very helpful. :)
(0002888)
Torr Samaho   
2012-03-25 14:04   
>'https://bitbucket.org/TIHan/tst/changeset/b5dcc44ad7a3 [^]'

I added your patch with a small modification: Since it's not guaranteed that ZDoom in the future won't put non-sound code below the check you added, I moved the check into the if condition that is responsible for the sound. Which variant is better really depends on how the ZDoom code there will evolve, currently both should lead to the exactly same result.

> NETWORK_IsConsolePlayerOrNotInClientMode. Very helpful. :)

Over the years I introduced functions for most occasions :), it just takes some time to get an overview of what's available.