Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004507Zandronum[All Projects] Bugpublic2025-04-18 15:492025-04-18 22:10
Reporterunknownna 
Assigned ToKaminsky 
PrioritynormalSeveritytextReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.2 
Target VersionFixed in Version3.2 
Summary0004507: [3.2] Team "tied" string at intermission screen uses "are tied" instead of "have tied" with "sv_suddendeath 0"
DescriptionUnlike non-team games, the "tied" string uses "are tied" instead of "have tied" when the game has ended and it's a draw game. I suppose for the sake of consistency, it should do the same as non-team games. See the attached screenshot.
Steps To Reproduce1. zandronum -host -file countdown_deathcount_02.wad +ctf 1 +timelimit 0.1 +sv_suddendeath 0
2. Connect a client to the server and let the timelimit run out. The string will be displayed during the intermission screen.
Additional InformationLink to example wad:'https://zandronum.com/tracker/file_download.php?file_id=3225&type=bug [^]'
Attached Filespng file icon Screenshot_Doom_20250418_173623.png [^] (24,094 bytes) 2025-04-18 15:49


png file icon Screenshot_Doom_20250418_191300.png [^] (18,407 bytes) 2025-04-18 17:29


png file icon Screenshot_Doom_20250418_190512.png [^] (13,734 bytes) 2025-04-18 17:29


png file icon Screenshot_Doom_20250418_203045.png [^] (201,578 bytes) 2025-04-18 18:58

- Relationships

-  Notes
User avatar (0024469)
Kaminsky (developer)
2025-04-18 16:39
edited on: 2025-04-18 16:40

 I corrected the grammar here:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/311 [^]'

It'll still say "teams are tied at x" in the middle of a level, but during intermissions, it'll now say "teams have tied at x".
User avatar (0024473)
unknownna (updater)
2025-04-18 17:30

 Nice work. Before marking this as resolved, I want your feedback on 2 issues that popped up:

* The "points", "frags" and "wins" is missing proper grammar treatment in some circumstances. Instead of "1 point", it's "1 points". However, it still displays proper "1 point" when multiple teams tie. See the attached screenshots.

* If more than 2 teams exist, it will not tie them, but let everyone win. Maybe it should be changed from "teams that won with" to "teams that tied with/at" to make it consistent with "sv_maxteams 2"? See the attached screenshot.

Does "tied at" sound better and more right to you than "tied with"? Maybe the latter sounds more natural. I'm not sure which is the most proper.
User avatar (0024474)
Kaminsky (developer)
2025-04-18 18:12

 I amended the commit to fix the improper grammar treatment you mentioned and rephrased the "teams that won with" statement to "teams that tied at". I don't think it's wrong to use either "tied at" or "tied with" in this context, but somehow, the former sounds better to me. Though, it could be that these messages have always been phrased this way and I've become accustomed to it.
User avatar (0024475)
unknownna (updater)
2025-04-18 18:57

 Thanks, that seems to work and look better.

Just one more final thing: If 3 teams are tied for the lead, there's an additional comma after the 2nd team. This does not happen if only 2 teams are tied. Would it be better to remove the comma, or leave it as is? Maybe it would look a bit cleaner without the comma there. See the attached screenshot.
User avatar (0024476)
Kaminsky (developer)
2025-04-18 19:55
Quote from unknownna
Just one more final thing: If 3 teams are tied for the lead, there's an additional comma after the 2nd team. This does not happen if only 2 teams are tied. Would it be better to remove the comma, or leave it as is? Maybe it would look a bit cleaner without the comma there.


Since there's no standard rule on whether the serial/oxford comma should be included or omitted from a list, I think it's okay to leave it as is (I also think the oxford comma is used in other lists in Zandronum too). Personally, I use them when listing items in writing, but I can understand if others don't, since using them or not has both advantages and disadvantages.
User avatar (0024478)
unknownna (updater)
2025-04-18 20:45
Quote from Kaminsky
Since there's no standard rule on whether the serial/oxford comma should be included or omitted from a list, I think it's okay to leave it as is (I also think the oxford comma is used in other lists in Zandronum too). Personally, I use them when listing items in writing, but I can understand if others don't, since using them or not has both advantages and disadvantages.


You know, I think I'll make a separate suggestion for this, since I believe it would make "sv_maxteams 4" games look a bit less cluttered when the score changes fast between 2- and 3-team ties. IIRC, I remember noticing this issue way back on Skulltag many years ago when participating in multi-team DM games.

While we're at it, looking at the text on the scoreboard and large frag messages some more, when multiple teams are tied mid-game, it says "teams leading with x:", yet when all teams are tied, it says "teams are tied at x:".

Shouldn't it perhaps be changed from "teams leading with x:" to "teams tied at x:" to make it consistent with the string when all teams are tied? Even though 2+ teams might have a higher score than the other teams, if they're technically tied, they're not really in the lead, right?

What are your thoughts on this? I know I'm starting to get very technical here, but I just want to look over this thoroughly with you so it's cleared up before moving on.
User avatar (0024479)
unknownna (updater)
2025-04-18 22:10

 I'll split the issue into its own ticket.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2025-04-18 15:49 unknownna New Issue
2025-04-18 15:49 unknownna File Added: Screenshot_Doom_20250418_173623.png
2025-04-18 16:39 Kaminsky Note Added: 0024469
2025-04-18 16:40 Kaminsky Note Edited: 0024469 View Revisions
2025-04-18 16:41 Kaminsky Assigned To => Kaminsky
2025-04-18 16:41 Kaminsky Status new => needs review
2025-04-18 16:41 Kaminsky Product Version => 3.2
2025-04-18 17:29 unknownna File Added: Screenshot_Doom_20250418_191300.png
2025-04-18 17:29 unknownna File Added: Screenshot_Doom_20250418_190512.png
2025-04-18 17:30 unknownna Note Added: 0024473
2025-04-18 18:12 Kaminsky Note Added: 0024474
2025-04-18 18:57 unknownna Note Added: 0024475
2025-04-18 18:58 unknownna File Added: Screenshot_Doom_20250418_203045.png
2025-04-18 19:55 Kaminsky Note Added: 0024476
2025-04-18 20:45 unknownna Note Added: 0024478
2025-04-18 22:10 unknownna Note Added: 0024479
2025-04-18 22:10 unknownna Status needs review => resolved
2025-04-18 22:10 unknownna Fixed in Version => 3.2
2025-04-18 22:10 unknownna Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker