0004467: Spectate Freely during Demo missing Source Spectator Clipping

(0024254)
Kaminsky (developer)
2025-03-17 15:37

This MR should fix the problem:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/276 [^]'

(0024282)
unknownna (updater)
2025-03-20 22:09

It works partially, but if the demo recorder turns into a real player from being a spectator in the demo, it still breaks.

(0024288)
Kaminsky (developer)
2025-03-22 11:23

Quote from unknownna
It works partially, but if the demo recorder turns into a real player from being a spectator in the demo, it still breaks.

I can't reproduce anything that seems broken here. Maybe I'm missing something, but if I'm freely spectating and the demo recorder joins the game (from spectators), then freely spectating still works with the correct spectator mode I'm currently using.

(0024289)
unknownna (updater)
2025-03-22 11:30
edited on: 2025-03-22 11:32

Does it happen to you if you turn into a demo spectator before the demo recorder turns into a player?

It still breaks for me when testing the pipeline build.
The demo spectator starts to become blocked by the floor when the demo recorder turns into a player if I turned into a demo spectator before the demo recorder turned into a player.

I'm testing this on a regular Doom 2 coop server.

(0024291)
Kaminsky (developer)
2025-03-22 13:55
edited on: 2025-03-22 13:57

Quote from unknownna
Does it happen to you if you turn into a demo spectator before the demo recorder turns into a player?

Yes, I was already in free spectate mode before the recorder joined the game, and it worked fine for me.

Quote from unknownna
The demo spectator starts to become blocked by the floor when the demo recorder turns into a player if I turned into a demo spectator before the demo recorder turned into a player.

So after the recorder joins, does it only prevent you from going through the floor/ceiling, but you can still pass through the walls?

(0024293)
unknownna (updater)
2025-03-22 14:08

Quote from Kaminsky
So after the recorder joins, does it only prevent you from going through the floor/ceiling, but you can still pass through the walls?

Correct. I uploaded the demo I recorded earlier. You can check whether it also happens to you there if you want.
It actually also happens when I turn into a demo spectator after the demo recorder turns into a player.

(0024295)
Kaminsky (developer)
2025-03-22 14:15

Thanks! I'll take a look whenever I can.

(0024298)
Kaminsky (developer)
2025-03-23 01:15

I'm sorry, but I still can't reproduce the issue you're talking about, even with the demo you uploaded. Note that I tried entering free spectator mode (with cl_spectatormode 1) before and after you joined the game, and found no issues. I was still able to travel through the walls, floors, and ceilings without any trouble. It's only when I set cl_spectatormode to 0 (i.e. the old spectator mode) that I can't move through solid surfaces.

(0024299)
unknownna (updater)
2025-03-23 09:26

Ok, since it didn't happen to you, I tried reproducing it with a fresh ini.

The culprit seems to be the software renderer (vid_renderer 0). It only breaks when using it.

(0024301)
Kaminsky (developer)
2025-03-23 12:56

Quote from unknownna
The culprit seems to be the software renderer (vid_renderer 0). It only breaks when using it.

Ah, okay. I normally test and play in the OpenGL renderer, but I was able to reproduce the issue in the software renderer. Thanks for pointing that out. I updated the MR and it should be fixed now.

(0024303)
unknownna (updater)
2025-03-23 18:54

Tested the latest pipeline build and it fixed it. Thank you.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Notes
(0024254) Kaminsky (developer) 2025-03-17 15:37	This MR should fix the problem:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/276 [^]'

(0024282) unknownna (updater) 2025-03-20 22:09	It works partially, but if the demo recorder turns into a real player from being a spectator in the demo, it still breaks.

(0024288) Kaminsky (developer) 2025-03-22 11:23	Quote from unknownna It works partially, but if the demo recorder turns into a real player from being a spectator in the demo, it still breaks. I can't reproduce anything that seems broken here. Maybe I'm missing something, but if I'm freely spectating and the demo recorder joins the game (from spectators), then freely spectating still works with the correct spectator mode I'm currently using.

(0024289) unknownna (updater) 2025-03-22 11:30 edited on: 2025-03-22 11:32	Does it happen to you if you turn into a demo spectator before the demo recorder turns into a player? It still breaks for me when testing the pipeline build. The demo spectator starts to become blocked by the floor when the demo recorder turns into a player if I turned into a demo spectator before the demo recorder turned into a player. I'm testing this on a regular Doom 2 coop server.

(0024291) Kaminsky (developer) 2025-03-22 13:55 edited on: 2025-03-22 13:57	Quote from unknownna Does it happen to you if you turn into a demo spectator before the demo recorder turns into a player? Yes, I was already in free spectate mode before the recorder joined the game, and it worked fine for me. Quote from unknownna The demo spectator starts to become blocked by the floor when the demo recorder turns into a player if I turned into a demo spectator before the demo recorder turned into a player. So after the recorder joins, does it only prevent you from going through the floor/ceiling, but you can still pass through the walls?

(0024293) unknownna (updater) 2025-03-22 14:08	Quote from Kaminsky So after the recorder joins, does it only prevent you from going through the floor/ceiling, but you can still pass through the walls? Correct. I uploaded the demo I recorded earlier. You can check whether it also happens to you there if you want. It actually also happens when I turn into a demo spectator after the demo recorder turns into a player.

(0024295) Kaminsky (developer) 2025-03-22 14:15	Thanks! I'll take a look whenever I can.

(0024298) Kaminsky (developer) 2025-03-23 01:15	I'm sorry, but I still can't reproduce the issue you're talking about, even with the demo you uploaded. Note that I tried entering free spectator mode (with cl_spectatormode 1) before and after you joined the game, and found no issues. I was still able to travel through the walls, floors, and ceilings without any trouble. It's only when I set cl_spectatormode to 0 (i.e. the old spectator mode) that I can't move through solid surfaces.

(0024299) unknownna (updater) 2025-03-23 09:26	Ok, since it didn't happen to you, I tried reproducing it with a fresh ini. The culprit seems to be the software renderer (vid_renderer 0). It only breaks when using it.

(0024301) Kaminsky (developer) 2025-03-23 12:56	Quote from unknownna The culprit seems to be the software renderer (vid_renderer 0). It only breaks when using it. Ah, okay. I normally test and play in the OpenGL renderer, but I was able to reproduce the issue in the software renderer. Thanks for pointing that out. I updated the MR and it should be fixed now.

(0024303) unknownna (updater) 2025-03-23 18:54	Tested the latest pipeline build and it fixed it. Thank you.

Issue History
Date Modified	Username	Field	Change
2025-03-15 23:26	__Sidle	New Issue
2025-03-17 15:37	Kaminsky	Note Added: 0024254
2025-03-17 15:37	Kaminsky	Assigned To	=> Kaminsky
2025-03-17 15:37	Kaminsky	Status	new => needs review
2025-03-17 15:37	Kaminsky	Product Version	=> 3.2
2025-03-17 15:37	Kaminsky	Target Version	=> 3.2
2025-03-20 22:09	unknownna	Note Added: 0024282
2025-03-22 11:23	Kaminsky	Note Added: 0024288
2025-03-22 11:30	unknownna	Note Added: 0024289
2025-03-22 11:31	unknownna	Status	needs review => feedback
2025-03-22 11:32	unknownna	Note Edited: 0024289	View Revisions
2025-03-22 13:55	Kaminsky	Note Added: 0024291
2025-03-22 13:57	Kaminsky	Note Edited: 0024291	View Revisions
2025-03-22 14:08	unknownna	Note Added: 0024293
2025-03-22 14:09	unknownna	File Added: 2025.03.22_12.37.54_doom2.cld
2025-03-22 14:15	Kaminsky	Note Added: 0024295
2025-03-23 01:15	Kaminsky	Note Added: 0024298
2025-03-23 09:26	unknownna	Note Added: 0024299
2025-03-23 12:56	Kaminsky	Note Added: 0024301
2025-03-23 12:56	Kaminsky	Status	feedback => needs review
2025-03-23 18:54	unknownna	Note Added: 0024303
2025-03-23 18:54	unknownna	Status	needs review => resolved
2025-03-23 18:54	unknownna	Fixed in Version	=> 3.2
2025-03-23 18:54	unknownna	Resolution	open => fixed

Relationships