0004389: [3.2] Intermission screen lasts 5 seconds too short if MAPINFO present

Notes
(0023997) Kaminsky (developer) 2024-09-03 11:56	This merge request should fix the discrepancy:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/186 [^]'

(0024003) unknownna (updater) 2024-09-05 13:22	Why on earth is the intermission timer supposed to be 5 seconds shorter than normal when there's MAPINFO present? The timer is in sync now in general, but if you go to regular MAP02 it's 20 seconds long instead of 15 with MAPINFO present. Is this a ZDoom thing? Feels bugged and strange. And if you use "changemap" between MAPINFO and non-MAPINFO maps during the intermission screen, the timer still bugs out and desyncs.

(0024009) Kaminsky (developer) 2024-09-05 16:13	Quote from "unknownna" Why on earth is the intermission timer supposed to be 5 seconds shorter than normal when there's MAPINFO present? The timer is in sync now in general, but if you go to regular MAP02 it's 20 seconds long instead of 15 with MAPINFO present. Is this a ZDoom thing? Feels bugged and strange. FYI, and as I mentioned in the MR, this was only the case if the map was part of the cluster. If the map wasn't, as was the case in your minimal example WAD, then the intermission was 4-5 seconds shorter. This is how the intermission code was handling it. In any case, I updated the merge request so that the intermission and the timer on the scoreboard are always 15 seconds long, regardless of whether the map is part of a cluster or not. I think the shorter intermission time is preferable when players want to transition from one map to the next as quickly as possible. Please test the merge request again when you have a chance to confirm that it fixes the issue(s).

(0024015) unknownna (updater) 2024-09-05 20:18	Quote from Kaminsky Please test the merge request again when you have a chance to confirm that it fixes the issue(s). This works better, thank you! Two minor nitpicks: * All the headers move sideways a little depending on how many seconds there are left on the timer. Is there a way around this? * It says "x second(s)". Wouldn't it be better if it said "seconds" and "second" when there's 1 second left? Maybe it would look a bit cleaner with the small font? Just mentioning it here before we mark this as resolved. If the above issues aren't a problem, I won't make any separate tickets for them.

(0024024) Kaminsky (developer) 2024-09-09 02:56 edited on: 2024-09-09 02:58	Quote from "unknownna" All the headers move sideways a little depending on how many seconds there are left on the timer. Is there a way around this? At least for me, only the relevant line here (i.e. "Entering MAPXX: {mapname} in x second(s)") moves side-to-side as the countdown ticks down. All of the other lines in the main header remain still, as they're supposed to. However, depending on the resolution and/or renderer that you're playing on, it could also be some minor round-off issue since everything's connected together and aligned to the centre of the screen. Quote from "unknownna" It says "x second(s)". Wouldn't it be better if it said "seconds" and "second" when there's 1 second left? Maybe it would look a bit cleaner with the small font? This is originally how I wanted to format this string since it obviously looks better. This required implementing a pluralize function for SCORINFO since there'd need to be a way to dynamically change between using "second" or "seconds" in the string, depending on how much time is left on the intermission screen. About a year ago, I thought about how such a function would work, and later decided that it would've been too much effort to be worth adding for that one string. So, I decided to use "second(s)" as a lazy way of working around it. However, for the last few days, I took a look at it again and came up with something that should work fine:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/188 [^]' So now, the string should look better on the scoreboard.

(0024029) unknownna (updater) 2024-09-09 18:26 edited on: 2024-09-09 18:33	Quote from Kaminsky However, depending on the resolution and/or renderer that you're playing on, it could also be some minor round-off issue since everything's connected together and aligned to the centre of the screen. Hmm, using both the OpenGL and software renderer in windowed mode at 640x480 seems to make the headers move around a little on my display. Pay close attention to the bigfront red "RANKINGS" and see if you notice it too. If you go from MAP06 to MAP07 in vanilla Doom 2, the "Cooperative - MAP06: The Crusher" string will move sideways too, and even the "server name" string depending on server name length. I get the impression that it's caused by the pixel width of the graphics used for the different seconds. And it also seems to dependent on the amount of players. It moves around a lot more if I play without any bots for instance. Quote from Kaminsky So now, the string should look better on the scoreboard. Wow, I didn't expect you to go above and beyond like that to address this, incredible! I have to agree it looks much better now indeed. Thanks.

Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-08-19 16:50	unknownna	New Issue
2024-08-19 16:50	unknownna	File Added: intermissiontimer_01.wad
2024-09-03 11:56	Kaminsky	Note Added: 0023997
2024-09-03 11:56	Kaminsky	Assigned To	=> Kaminsky
2024-09-03 11:56	Kaminsky	Status	new => needs review
2024-09-03 11:56	Kaminsky	Target Version	=> 3.2
2024-09-05 13:22	unknownna	Note Added: 0024003
2024-09-05 13:22	unknownna	Status	needs review => feedback
2024-09-05 16:13	Kaminsky	Note Added: 0024009
2024-09-05 16:13	Kaminsky	Status	feedback => needs review
2024-09-05 20:18	unknownna	Note Added: 0024015
2024-09-05 20:18	unknownna	Status	needs review => feedback
2024-09-09 02:56	Kaminsky	Note Added: 0024024
2024-09-09 02:56	Kaminsky	Status	feedback => needs review
2024-09-09 02:58	Kaminsky	Note Edited: 0024024	View Revisions
2024-09-09 18:26	unknownna	Note Added: 0024029
2024-09-09 18:33	unknownna	Note Edited: 0024029	View Revisions

Relationships