0004344: Maplists don't work offline

Notes
(0023790) Kaminsky (developer) 2024-07-14 21:59	FYI, the map rotation system was coded to work only in online games. I wouldn't necessarily consider this a bug, since it seems intentional that it shouldn't work in offline games, notwithstanding the fact that you can still add/remove maps from the rotation and use the "maplist" CCMD anyways. However, if it's desirable to use the map rotation in offline multiplayer games too, then it could be done.

(0023796) unknownna (updater) 2024-07-15 23:14	It's no big deal, it would just be convenient to have the offline and online behavior match if sv_maprotation is 1. I use Doom Explorer where I can press "Test in Singleplayer" instead of starting a server with my saved config for CTF, and that's when I noticed the difference. The IDL wads require you to have a maplist enabled to progress between maps, otherwise a single map will just repeat until a mapvote is called or you manually change maps. There is no urgency however in having this fixed.

(0023799) Kaminsky (developer) 2024-07-17 19:59	Removing the "NETWORK_GetState( ) == NETSTATE_SERVER" checks wherever the map rotation code is used shouldn't be too much trouble, but I probably won't prioritize in addressing this issue for 3.2 at this time.

(0023993) Kaminsky (developer) 2024-09-02 20:09	Looks like I was able to address this after all. Here is the merge request:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/185 [^]'

(0024000) unknownna (updater) 2024-09-05 12:12	Hey sir, it doesn't seem to work as expected when I test it. I tested it with the IDL CTF wad through Doom Explorer. When I launch the game with the same config as a server, sv_maprotation is set to 0 for some reason. If I manually set sv_maprotation to 1 after starting the offline game, the maplist works as expected. And if I manually add "sv_maprotation 1" as a custom parameter to the saved config, it works as expected. On top of this, it seems that the value is archived. Is this intentional? This leads me to believe this is a Doom Explorer bug, where it doesn't set "sv_maprotation 1" when the config is launched as an offline game. Will mark as resolved if you think it's ok.

(0024006) Kaminsky (developer) 2024-09-05 15:18	Quote from "unknownna" On top of this, it seems that the value is archived. Is this intentional? Considering that CVAR_ARCHIVE is a flag that must be manually added to CVar definitions to be archived, I'd say it was most likely done intentionally. I don't see a problem with archiving these CVars though. Why should this be changed? Quote from "unknownna" This leads me to believe this is a Doom Explorer bug, where it doesn't set "sv_maprotation 1" when the config is launched as an offline game. This sounds more like an issue with Doom Explorer than something wrong with Zandronum. I didn't have this problem when I tested these changes with Doomseeker, which is what I use. Any issues with Doom Explorer (or Doomseeker, hypothetically speaking) should be reported to the developers of those projects.

(0024011) unknownna (updater) 2024-09-05 18:45	Quote from Kaminsky Considering that CVAR_ARCHIVE is a flag that must be manually added to CVar definitions to be archived, I'd say it was most likely done intentionally. I don't see a problem with archiving these CVars though. Why should this be changed? I'm not a programmer, so forgive me if it doesn't appear obvious to me. It just felt like some feature you'd set for one session and then it would revert back off to normal. Quote from Kaminsky This sounds more like an issue with Doom Explorer than something wrong with Zandronum. I didn't have this problem when I tested these changes with Doomseeker, which is what I use. Any issues with Doom Explorer (or Doomseeker, hypothetically speaking) should be reported to the developers of those projects. I think so too, and I'll make a note of it in case I report it there. So with that, we can mark this as resolved.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-07-11 19:18	unknownna	New Issue
2024-07-14 21:59	Kaminsky	Note Added: 0023790
2024-07-15 23:14	unknownna	Note Added: 0023796
2024-07-17 19:59	Kaminsky	Note Added: 0023799
2024-09-02 20:09	Kaminsky	Note Added: 0023993
2024-09-02 20:09	Kaminsky	Assigned To	=> Kaminsky
2024-09-02 20:09	Kaminsky	Status	new => needs review
2024-09-02 20:09	Kaminsky	Target Version	=> 3.2
2024-09-05 12:12	unknownna	Note Added: 0024000
2024-09-05 12:12	unknownna	Status	needs review => feedback
2024-09-05 15:18	Kaminsky	Note Added: 0024006
2024-09-05 18:45	unknownna	Note Added: 0024011
2024-09-05 18:45	unknownna	Status	feedback => assigned
2024-09-05 18:45	unknownna	Status	assigned => resolved
2024-09-05 18:45	unknownna	Fixed in Version	=> 3.2
2024-09-05 18:45	unknownna	Resolution	open => fixed
2024-10-17 20:31	unknownna	Relationship added	parent of 0004430