0004312: Turn "allies left" message green in TeamLMS, change "opponents" color/name and remove redundant comma

Notes
(0023793) Kaminsky (developer) 2024-07-15 15:37	Can you elaborate more on the "redundant comma"? I just want your feedback on how you think the text should be formatted. For example, when there's opponents but no allies left, the text will print: "x opponents left - allies dead", so "opponents" and "allies" are separated by a hyphen. For the sake of consistency, should the text be changed to "x opponents left - y allies left", or just "x opponents y allies left"? Would an ampersand also work? I have no problem with changing the text colours to match those used in the target identification.

(0023794) unknownna (updater) 2024-07-15 20:58	Quote from Kaminsky or just "x opponents y allies left" Yes, this is what I meant. Remove the comma after opponents and just do this instead. When all allies are dead, a hyphen will do fine since it can be placed where the "y" number was. Let the hyphen be the same white color as the numbers, and it should feel intuitive and consistent like that.

(0023800) Kaminsky (developer) 2024-07-17 20:41	I see, thanks for the clarification.

(0023801) Kaminsky (developer) 2024-07-17 21:44	I created a new merge request for this:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/136 [^]'

(0023807) Kaminsky (developer) 2024-07-21 14:19	This commit just got pushed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/665e794264c333ce4a68e728a60787d8abb58731 [^]'

(0023808) unknownna (updater) 2024-07-21 18:15	I tested this after discovering the pipeline build feature on the heptapod site. It seems to work well, but the hyphen however seems to be of a dark red color instead of the same color as the former ally number. See the attached screenshot. Was this intentional as a choice? And shouldn't the ally/enemy number colors be white instead of gray for more clarity? Maybe I don't have the best vision in the world, but the gray numbers seem a bit faded and unclear compared to white sometimes. Thank you very much for looking into this BTW, I hope you guys think the new colors look cool as well.

(0023810) Kaminsky (developer) 2024-07-21 19:26	Quote from "unknownna" It seems to work well, but the hyphen however seems to be of a dark red color instead of the same color as the former ally number. See the attached screenshot. Was this intentional as a choice? Yes, because text like "following {player name}" and the hyphens have always been printed in red, or the text colour of which team the spied player belongs to. It's more noticeable now that "allies" and "enemies" aren't printed in the same red colour, but dark green and dark red respectively. I've considered changing the text colour in non-team game modes to a neutral colour like grey or white, but didn't want to go beyond what the ticket requested. Quote from "unknownna" And shouldn't the ally/enemy number colors be white instead of gray for more clarity? Maybe I don't have the best vision in the world, but the gray numbers seem a bit faded and unclear compared to white sometimes. Actually, the numbers have always been printed in grey instead of white. Since this ticket didn't specifically mention changing the text colour, I assumed that the current one was acceptable and kept it (note: the only text that's printed in white is "Free Spectate Mode"). Frankly, I can't notice much of a difference between white or grey text using Doom's SmallFont, but I don't have any problem with changing it to white. Quote from "unknownna" Thank you very much for looking into this BTW, I hope you guys think the new colors look cool as well. Yes, the new colours look pretty nice and consistent. I like the distinction between "allies" and "enemies" now. :)

(0023812) unknownna (updater) 2024-07-21 22:19 edited on: 2024-07-22 01:51	Quote from Kaminsky Yes, because text like "following {player name}" and the hyphens have always been printed in red, or the text colour of which team the spied player belongs to. It's more noticeable now that "allies" and "enemies" aren't printed in the same red colour, but dark green and dark red respectively. Ok, understood. Quote from Kaminsky Actually, the numbers have always been printed in grey instead of white. True. Maybe it would be worth trying white. I think the off-white color of the gray might blend more with the background colors, like the plasmarifle colors. Maybe white would stand out better. Actually, thinking about it, it might just be me and my monitor. Marking as resolved, thanks!

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-06-07 13:31	unknownna	New Issue
2024-06-07 13:31	unknownna	File Added: Screenshot_Doom_20240607_133231_02.png
2024-07-15 15:37	Kaminsky	Note Added: 0023793
2024-07-15 15:37	Kaminsky	Status	new => feedback
2024-07-15 20:58	unknownna	Note Added: 0023794
2024-07-15 20:58	unknownna	Status	feedback => new
2024-07-17 20:41	Kaminsky	Note Added: 0023800
2024-07-17 21:44	Kaminsky	Note Added: 0023801
2024-07-17 21:44	Kaminsky	Assigned To	=> Kaminsky
2024-07-17 21:44	Kaminsky	Status	new => needs review
2024-07-17 21:44	Kaminsky	Target Version	=> 3.2
2024-07-21 14:19	Kaminsky	Note Added: 0023807
2024-07-21 14:19	Kaminsky	Status	needs review => needs testing
2024-07-21 18:15	unknownna	File Added: Screenshot_Doom_20240721_193808.png
2024-07-21 18:15	unknownna	Note Added: 0023808
2024-07-21 18:15	unknownna	Status	needs testing => feedback
2024-07-21 19:26	Kaminsky	Note Added: 0023810
2024-07-21 22:19	unknownna	Note Added: 0023812
2024-07-21 22:19	unknownna	Status	feedback => assigned
2024-07-22 01:51	unknownna	Note Edited: 0023812	View Revisions
2024-07-22 01:52	unknownna	Status	assigned => resolved
2024-07-22 01:52	unknownna	Fixed in Version	=> 3.2
2024-07-22 01:52	unknownna	Resolution	open => fixed

Relationships