Chat on our Discord Server
Get the latest version: 3.1Source Code
| Anonymous | Login | Signup for a new account | 2024-07-27 11:24 UTC |  |
| My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0004190 | Zandronum | [All Projects] Suggestion | public | 2024-01-30 04:52 | 2024-04-08 19:51 | ||||
| Reporter | StrikerMan780 | ||||||||
| Assigned To | |||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||
| Product Version | 3.1 | ||||||||
| Target Version | 3.2 | Fixed in Version | 3.2 | ||||||
| Summary | 0004190: GAMEEVENT_ACTOR_ARMORDAMAGED doesn't fire if actor lacks an inventory | ||||||||
| Description | GAMEEVENT_ACTOR_ARMORDAMAGED doesn't seem to trigger when hit by radius damage, even though radius damage can affect armor. | ||||||||
| Steps To Reproduce | Just make an event script checking for type == GAMEEVENT_ACTOR_ARMORDAMAGED, and have it print when fired. Use the rocket launcher on some enemies, and you'll notice that the script will only fire for enemies that were directly hit, and not for any that were hit with splash damage. | ||||||||
| Attached Files | |||||||||
 Relationships |
|
 Relationships |
|
Notes |
|
 (0023060)WaTaKiD (updater) 2024-02-09 14:58 |
example wad please |
 (0023065)StrikerMan780 (reporter) 2024-02-09 16:06 |
About to go to sleep, but I'll get one uploaded when I wake up tomorrow. |
|
(0023067) StrikerMan780 (reporter) 2024-02-09 20:31 edited on: 2024-02-09 22:09 |
Had some interesting findings. There's a Inventory != NULL check before executing the event in P_DamageMobj, and if a monster doesn't have any inventory, the event won't fire. This means if you give the monster so much as a clip, or other random item, the event will then fire. Perhaps the ticket title/description should be renamed "GAMEEVENT_ACTOR_ARMORDAMAGED doesn't fire if actor lacks an inventory." I propose moving the event call up a line, out of that block, and naming the event something more appropriate, like GAMEEVENT_ACTOR_DAMAGE_PREARMOR, as this code occurs BEFORE any armor takes damage, not when it is taking damage. This way, it'll behave more consistently, but still keep its current use/function. It would also mean one doesn't have to go around giving everyone dummy items so it works across all monsters/players. |
|
(0023522) StrikerMan780 (reporter) 2024-04-06 00:22 |
MR with proposed changes:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/90 [^]' |
 (0023524)Kaminsky (developer) 2024-04-06 13:32 |
I changed this to a suggestion because GAMEEVENT_ACTOR_ARMORDAMAGED was intended to only trigger for actors that have inventory items that can potentially absorb some of the damage (thus, actors without an inventory shouldn't have triggered the event). This isn't a bug and the MR only improves the behaviour. |
 (0023525)Ru5tK1ng (updater) 2024-04-07 20:28 |
Changes were merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/da48bf1babf89393ba97cfa9e090d7d5c7a6b38e [^]' |
|
(0023543) StrikerMan780 (reporter) 2024-04-07 23:03 |
Cheers. |
|
(0023556) Ru5tK1ng (updater) 2024-04-08 19:51 |
Marking as resolved since Strikerman extensively tested this for a performance check. |
|
Notes |
|
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
| Supporters: | No one explicitly supports this issue yet. |
| Opponents: | No one explicitly opposes this issue yet. |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-01-30 04:52 | StrikerMan780 | New Issue | |
| 2024-02-09 14:58 | WaTaKiD | Note Added: 0023060 | |
| 2024-02-09 16:06 | StrikerMan780 | Note Added: 0023065 | |
| 2024-02-09 20:31 | StrikerMan780 | Note Added: 0023067 | |
| 2024-02-09 20:31 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 20:32 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 20:33 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 21:48 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 21:49 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 21:49 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 21:51 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 21:55 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 22:08 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-02-09 22:09 | StrikerMan780 | Note Edited: 0023067 | View Revisions |
| 2024-04-06 00:22 | StrikerMan780 | Note Added: 0023522 | |
| 2024-04-06 02:22 | Kaminsky | Status | new => needs review |
| 2024-04-06 02:22 | Kaminsky | Summary | GAMEEVENT_ACTOR_ARMORDAMAGED doesn't fire for radius damage => GAMEEVENT_ACTOR_ARMORDAMAGED doesn't fire if actor lacks an inventory |
| 2024-04-06 13:32 | Kaminsky | Note Added: 0023524 | |
| 2024-04-06 13:32 | Kaminsky | Category | Bug => Suggestion |
| 2024-04-07 20:28 | Ru5tK1ng | Note Added: 0023525 | |
| 2024-04-07 20:28 | Ru5tK1ng | Status | needs review => needs testing |
| 2024-04-07 20:28 | Ru5tK1ng | Target Version | => 3.2 |
| 2024-04-07 23:03 | StrikerMan780 | Note Added: 0023543 | |
| 2024-04-08 19:51 | Ru5tK1ng | Note Added: 0023556 | |
| 2024-04-08 19:51 | Ru5tK1ng | Status | needs testing => resolved |
| 2024-04-08 19:51 | Ru5tK1ng | Resolution | open => fixed |
| 2024-04-08 19:51 | Ru5tK1ng | Fixed in Version | => 3.2 |
|
Issue History |
| Copyright © 2000 - 2024 MantisBT Team |
 |
ZDoom
Doom Wiki
id Software
Doomworld
Odamex
Doomseeker
Internet Doom Explorer
The Sentinel's Playground Servers