0004172: +TOUCHY doesn't work in zandro, but theres code written for it

Notes
(0022924) WaTaKiD (updater) 2023-11-28 15:01	can you provide a minimal example wad? is the issue also present in gzdoom 1.8.6?

(0022925) here100 (reporter) 2023-11-29 02:37 edited on: 2023-11-29 02:38	I have uploaded a wad called 'TOUCHY TEST.wad' it's only 1 kb in size. It replaces the Lost soul, i took this out of a different wad btw doesnt matter, and gives it some different functions. The point is that the Lost Soul is suppose to die upon being touched. On GZdoom 1.8.6 it dies upon touch On ZDOOM it dies upon touch On Zandro it doesnt die note: you have to use the fly cheat to touch the lost souls

(0022926) here100 (reporter) 2023-11-29 10:48	I compared all the pieces of code that mention +TOUCHY and the only difference between Gzdoom 1.8.6 and Zandronum i found was this: In zandronum this piece of code after 'NULL' is commented out: 'https://github.com/TorrSamaho/zandronum/blob/a27eaef3246672dae1fb24099ac7d34137178585/src/p_map.cpp#L991C1-L991C1 [^]' In Gzdoom 1.8.6 it's not: 'https://github.com/ZDoom/gzdoom/blob/g1.8.6/src/p_map.cpp#L917 [^]'

(0022927) here100 (reporter) 2023-12-01 17:16	NOTE: +TOUCHY Works on zandro 2.1.2

(0022928) Kaminsky (developer) 2023-12-02 01:20 edited on: 2023-12-02 01:21	For the record, the regression was caused by this commit: 'http://hg.osdn.net/view/zandronum/zandronum-stable/rev/cc82bb513aff [^]' Followed by this merge: 'http://hg.osdn.net/view/zandronum/zandronum-stable/rev/3f7914cc986b [^]'

(0023411) Ru5tK1ng (updater) 2024-03-16 22:27	Should work offline and online with this: 'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/65 [^]'

(0023417) Kaminsky (developer) 2024-03-17 13:48	This got pushed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/7252077c7d42513e1519fe092674a4de63aadf8c [^]'

(0023470) Ru5tK1ng (updater) 2024-03-23 05:36	Pulled the latest changes and touchy wad works fine offline and online now.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2023-11-27 02:09	here100	New Issue
2023-11-28 15:01	WaTaKiD	Note Added: 0022924
2023-11-29 02:37	here100	File Added: TOUCHY TEST.wad
2023-11-29 02:37	here100	Note Added: 0022925
2023-11-29 02:38	here100	Note Edited: 0022925	View Revisions
2023-11-29 10:48	here100	Note Added: 0022926
2023-12-01 17:16	here100	Note Added: 0022927
2023-12-02 01:20	Kaminsky	Note Added: 0022928
2023-12-02 01:21	Kaminsky	Note Edited: 0022928	View Revisions
2024-03-16 22:27	Ru5tK1ng	Note Added: 0023411
2024-03-16 22:27	Ru5tK1ng	Status	new => needs review
2024-03-17 13:48	Kaminsky	Note Added: 0023417
2024-03-17 13:48	Kaminsky	Status	needs review => needs testing
2024-03-17 13:48	Kaminsky	Target Version	=> 3.2
2024-03-23 05:36	Ru5tK1ng	Note Added: 0023470
2024-03-23 05:36	Ru5tK1ng	Fixed in Version	=> 3.2
2024-03-23 05:36	Ru5tK1ng	Status	needs testing => resolved
2024-03-23 05:36	Ru5tK1ng	Resolution	open => fixed

Relationships