Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004168Zandronum[All Projects] Bugpublic2023-10-31 19:162024-03-23 05:56
ReporterRusselCS 
Assigned ToKaminsky 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformPCOSWindowsOS Version10.04 x86-64
Product Version3.1 
Target Version3.2Fixed in Version3.2 
Summary0004168: Server CVars do not save to LocalServerInfo.mod when in multiplayer emulation
DescriptionWhen playing offline with multiplayer emulation enabled (ie, offline bot matches of any sort--including campaigns) you cannot update server cvars defined by CVARINFO.
Steps To Reproduce1) Load the attached wad onto a server
2) In the server, set `user_sv_testtoggle` to `true`.
3) Connect to the server.
4) Close your client.
5) Re-open the client, but do not connect to the server.
6) Open Offline Skirmish in any map in Deathmatch.
7) Set `user_sv_testtoggle` to `false`.
8) Close and re-open the game, re-enter offline skirmish. Check the status of `user_sv_testtoggle`.

Expected: `user_sv_testtoggle` should be `false`.
Actual: `user_sv_testtoggle` is `true`.
Additional InformationConversation with Kaminsky came to the conclusion that server cvars changed by the client are not properly stored into the "LocalServerInfo.mod" block of the ini when the client's netstate is NETSTATE_SINGLE_MULTIPLAYER. Is it only properly persisted into that block when the client's netstate is NETSTATE_SINGLE.
Attached Files? file icon 3.2_cvartesttoggle.pk3 [^] (1,534 bytes) 2023-10-31 19:16

- Relationships

-  Notes
User avatar (0023397)
Kaminsky (developer)
2024-03-14 15:59

 I opened a new merge request to address this issue:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/58 [^]'

Something else that I noticed when addressing this is that the server's settings also get archived when the client closes the game. Personally, I believe the server's settings should be discarded when the client disconnects. As such, the MR also includes a commit to discard the server's settings upon disconnecting, especially so they don't overwrite the client's when they're archived.
User avatar (0023405)
RusselCS (reporter)
2024-03-15 00:58
edited on: 2024-03-15 00:59

 This appears to solve the issue.
Tested with the above wad, using different test scenarios I could think of.
Turned the variable on in deathmatch, closed the game, relaunched and the setting was properly persisted.

I also tested with the server -> client transfer as discussed, and the cvars do not remain on the client after they leave the server.

Tested in MM8BDM with its new settings and the issue does not appear there with this build either.
User avatar (0023409)
Kaminsky (developer)
2024-03-16 04:34

 Thanks for testing! It sounds like everything's working as intended and solves the issue.
User avatar (0023416)
Kaminsky (developer)
2024-03-17 12:13

 The merge request above has been pushed into the main repository.
User avatar (0023472)
Ru5tK1ng (updater)
2024-03-23 05:55

 Tested in 3.2 and it seemed that the CVAR's value stuck to what the client specified. Connecting to the server did not overwrite anything.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2023-10-31 19:16 RusselCS New Issue
2023-10-31 19:16 RusselCS File Added: 3.2_cvartesttoggle.pk3
2024-03-14 15:59 Kaminsky Note Added: 0023397
2024-03-14 15:59 Kaminsky Assigned To => Kaminsky
2024-03-14 15:59 Kaminsky Status new => needs review
2024-03-14 15:59 Kaminsky Target Version => 3.2
2024-03-15 00:58 RusselCS Note Added: 0023405
2024-03-15 00:59 RusselCS Note Edited: 0023405 View Revisions
2024-03-16 04:34 Kaminsky Note Added: 0023409
2024-03-17 12:13 Kaminsky Note Added: 0023416
2024-03-17 12:13 Kaminsky Status needs review => needs testing
2024-03-23 05:55 Ru5tK1ng Note Added: 0023472
2024-03-23 05:55 Ru5tK1ng Fixed in Version => 3.2
2024-03-23 05:56 Ru5tK1ng Status needs testing => resolved
2024-03-23 05:56 Ru5tK1ng Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker