0000414: Player turns into a team spectator after a changemap map change if sv_maxplayers is altered

Notes
(0001485) unknownna (updater) 2011-04-27 13:27 edited on: 2011-04-28 03:04	OK, I finally managed to reproduce the NO TEAM issue. 1. Start a TeamPossession server with sv_keepteams set to 1 and sv_maxplayers set to 0. 2. Connect a client to the server. 3. "join" in the console. 4. "sv_maxplayers 1-32" in the server console. 5. "join" in the console. You'll be put on a team. 6. Turn into a spectator. You'll be put on NO TEAM instead of turning into a spectator. I forgot to mention that this happens in all team modes.

(0001517) Torr Samaho (administrator) 2011-04-30 23:27	This should fix the issue described in note 1485.

(0001519) Torr Samaho (administrator) 2011-05-01 00:42	This should also fix the team spectator after chanegemap map change issue, the player is still forced to spectate though: If you make sv_maxplayers lower than the number of players in the server what is Skulltag supposed to do? Apparently the admin wants some of the players removed, Skulltag just postpones this to the next map change to not interrupt the current game (actually this is not really done on purpose but a consequence of the game mechanics and IMO a consistent behavior). The only sane way to prevent players from being forced to spectate by this I see would be to forbid the admin to make sv_maxplayers smaller than the number of player currently in the game. Note: If you only considered the part that the spectator is on a team to be a bug, just ignore this paragraph ;-).

(0001521) unknownna (updater) 2011-05-01 03:38	It fixed the issues. But if the sv_maxplayers value is raised while in the intermission screen, the players in the queue will be forced to join and this bug will be present.

(0001525) Torr Samaho (administrator) 2011-05-01 12:47	Since increasing the sv_maxplayers value intentionally makes the players waiting in line join, it's to be expected that they are affected by the same bug as players who manually join during the intermission. So I consider this issue to be resolved, 0000325 still needs to be fixed though of course.

(0001528) unknownna (updater) 2011-05-01 13:13 edited on: 2011-05-01 13:17	You turn into a team spectator in the intermission screen, and then you turn into a normal spectator again at map start if sv_keepteams is set to 0.

(0001530) Torr Samaho (administrator) 2011-05-01 16:20	> You turn into a team spectator in the intermission screen, and then you turn into a normal spectator again at map start if sv_keepteams is set to 0. Can you elaborate how to reproduce this?

(0001531) unknownna (updater) 2011-05-01 16:38 edited on: 2011-05-01 16:45	1. Start a TDM server with sv_maxplayers set to 0. 2. Connect a client to the server. 3. "join" in the console. 4. "changemap map01" in the server console. 5. "sv_maxplayers 1-32" in the server console.

(0001533) Torr Samaho (administrator) 2011-05-01 17:33	I see. Letting players join during intermission introduces some timing issues. This should fix the issue, in the sense that even if sv_maxplayers is increased during a map change, the players only join after the map change (it doesn't cover players who try to join during intermission manually yet). Unfortunately, this is another far reaching change and may have an effect during map changes in all game modes that don't use sv_maxlives.

(0001535) unknownna (updater) 2011-05-01 18:15 edited on: 2011-05-01 18:32	> it doesn't cover players who try to join during intermission manually yet Indeed, I can still turn into a team spectator if I manually join the game during the intermission screen. Separate issue: My "switchonpickup" alias forces me to use the fist at map starts in non-coop modes if I hold +attack when leaving the intermission screen. This doesn't happen in 98d. However, this also happens in build 3195.

(0001536) Torr Samaho (administrator) 2011-05-01 20:07	This should prevent players from joining during intermission in general. Instead they are put in line and join after the map change. So this should also fix 0000325. PS: The fact that you are possible shown as spectator on a team while the map changes is done should not considered to be a bug. The spectator is put on a team and scheduled to join at the same time, but the join only happens when the map change is complete. Regarding switchonpickup: This most likely has nothing to do with this report, but likely is related to the weapon sync changes.

(0001545) unknownna (updater) 2011-05-02 04:07	> This should prevent players from joining during intermission in general. Instead they are put in line and join after the map change. So this should also fix 0000325. It fixed the issues. But players aren't put in the queue if they use the "team" command.

(0001571) Torr Samaho (administrator) 2011-05-08 18:09	Hmm, I checked the code and noticed that Skulltag actively prevents team and changeteam from being used during intermission. I wonder if I should soften this restriction to allow spectators to join the queue during intermission or just keep it as it as and acceped this minor inconsistency.

(0001573) unknownna (updater) 2011-05-08 19:00	> I wonder if I should soften this restriction to allow spectators to join the queue during intermission or just keep it as it as and acceped this minor inconsistency. Would it be possible to only allow spectators to use the commands during the intermission screen? With the new behavior, they will not appear as being on a team until the map actually changes. It's a very trivial issue though. And although they might join the queue during the intermission screen, they are still turned into a regular spectator in the next map if sv_keepteams is set to 0.

(0001582) Torr Samaho (administrator) 2011-05-08 23:25 edited on: 2011-05-08 23:33	Ok, this should allow spectators to join the queue with team/changeteam during intermission.

(0001584) unknownna (updater) 2011-05-09 09:40 edited on: 2011-05-09 09:47	> Ok, this should allow spectators to join the queue with team/changeteam during intermission. It fixed the issue, but I'm not put in the queue with the changeteam command. And spectators are not put on a team at map start if sv_keepteams or sv_noteamselect is set to 0. It's not a bug though.

(0001586) Torr Samaho (administrator) 2011-05-09 12:29	> but I'm not put in the queue with the changeteam command "changeteam teamname" work fine for me. changeteam without argument is supposed to put you on the next team, i.e. if you are on team one you are put on team two and so forth. In particular, it always puts you on the other team, if there are only two teams. If you are not on a team, there is no "next" or "other" team, so the command simply does nothing in this case. If you think that this behavior is unexpected, I can add a message that tells the spectator that it can't toggle its team without being on a team.

(0001587) unknownna (updater) 2011-05-09 12:50	> "changeteam teamname" work fine for me. changeteam without argument is supposed to put you on the next team, i.e. if you are on team one you are put on team two and so forth. In particular, it always puts you on the other team, if there are only two teams. I see. I only used "changeteam". > If you think that this behavior is unexpected, I can add a message that tells the spectator that it can't toggle its team without being on a team. That'd be nice.

(0001602) Torr Samaho (administrator) 2011-05-14 15:14	>> If you think that this behavior is unexpected, I can add a message that tells the spectator that it can't toggle its team without being on a team. > That'd be nice. Done.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-04-27 12:26	unknownna	New Issue
2011-04-27 12:26	unknownna	File Added: Screenshot_Doom_20110427_141527.png
2011-04-27 12:26	unknownna	Description Updated	View Revisions
2011-04-27 12:27	unknownna	File Added: Screenshot_Doom_20110427_131841.png
2011-04-27 12:28	unknownna	File Added: Screenshot_Doom_20110427_131851.png
2011-04-27 13:27	unknownna	Note Added: 0001485
2011-04-27 13:27	unknownna	Status	new => confirmed
2011-04-27 13:47	unknownna	File Added: Screenshot_Doom_20110427_151723.png
2011-04-27 13:47	unknownna	File Deleted: Screenshot_Doom_20110427_131841.png
2011-04-27 13:47	unknownna	File Deleted: Screenshot_Doom_20110427_131851.png
2011-04-28 03:04	unknownna	Note Edited: 0001485	View Revisions
2011-04-30 23:27	Torr Samaho	Note Added: 0001517
2011-04-30 23:27	Torr Samaho	Assigned To	=> Torr Samaho
2011-04-30 23:27	Torr Samaho	Status	confirmed => feedback
2011-04-30 23:33	Torr Samaho	Note Added: 0001518
2011-04-30 23:37	Torr Samaho	Note Edited: 0001518	View Revisions
2011-05-01 00:01	Torr Samaho	Note Deleted: 0001518
2011-05-01 00:42	Torr Samaho	Note Added: 0001519
2011-05-01 03:38	unknownna	Note Added: 0001521
2011-05-01 03:38	unknownna	Status	feedback => assigned
2011-05-01 03:40	unknownna	File Added: Screenshot_Doom_20110501_053519.png
2011-05-01 12:47	Torr Samaho	Note Added: 0001525
2011-05-01 13:13	unknownna	Note Added: 0001528
2011-05-01 13:17	unknownna	Note Edited: 0001528	View Revisions
2011-05-01 13:19	Torr Samaho	Status	assigned => resolved
2011-05-01 13:19	Torr Samaho	Fixed in Version	=> 1.0
2011-05-01 13:19	Torr Samaho	Resolution	open => fixed
2011-05-01 16:17	Torr Samaho	Status	resolved => assigned
2011-05-01 16:20	Torr Samaho	Note Added: 0001530
2011-05-01 16:22	Torr Samaho	Status	assigned => feedback
2011-05-01 16:38	unknownna	Note Added: 0001531
2011-05-01 16:38	unknownna	Status	feedback => assigned
2011-05-01 16:41	unknownna	Note Edited: 0001531	View Revisions
2011-05-01 16:45	unknownna	Note Edited: 0001531	View Revisions
2011-05-01 17:33	Torr Samaho	Note Added: 0001533
2011-05-01 17:37	Torr Samaho	Status	assigned => feedback
2011-05-01 18:15	unknownna	Note Added: 0001535
2011-05-01 18:15	unknownna	Status	feedback => assigned
2011-05-01 18:18	unknownna	File Added: Screenshot_Doom_20110501_200832.png
2011-05-01 18:32	unknownna	Note Edited: 0001535	View Revisions
2011-05-01 20:07	Torr Samaho	Note Added: 0001536
2011-05-01 20:07	Torr Samaho	Note Added: 0001537
2011-05-01 20:15	Torr Samaho	Note Deleted: 0001537
2011-05-01 20:16	Torr Samaho	Status	assigned => feedback
2011-05-02 04:07	unknownna	Note Added: 0001545
2011-05-02 04:07	unknownna	Status	feedback => assigned
2011-05-08 18:09	Torr Samaho	Note Added: 0001571
2011-05-08 18:13	Torr Samaho	Status	assigned => feedback
2011-05-08 19:00	unknownna	Note Added: 0001573
2011-05-08 19:00	unknownna	Status	feedback => assigned
2011-05-08 23:25	Torr Samaho	Note Added: 0001582
2011-05-08 23:33	Torr Samaho	Note Edited: 0001582	View Revisions
2011-05-08 23:34	Torr Samaho	Status	assigned => feedback
2011-05-09 09:40	unknownna	Note Added: 0001584
2011-05-09 09:40	unknownna	Status	feedback => assigned
2011-05-09 09:47	unknownna	Note Edited: 0001584	View Revisions
2011-05-09 12:29	Torr Samaho	Note Added: 0001586
2011-05-09 12:34	Torr Samaho	Status	assigned => feedback
2011-05-09 12:50	unknownna	Note Added: 0001587
2011-05-09 12:50	unknownna	Status	feedback => assigned
2011-05-14 15:14	Torr Samaho	Note Added: 0001602
2011-05-14 15:14	Torr Samaho	Status	assigned => resolved
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2018-09-30 20:04	Blzut3	Status	resolved => closed

Relationships