0004128: Shaders for lights can't be enabled unless compiling with MSVC

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004128

Zandronum

[All Projects] Bug

public

2023-04-22 02:50

2024-04-08 01:10

Reporter

TDRR

Assigned To

Kaminsky

Priority

normal

Severity

trivial

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

3.1

Target Version

3.2

Fixed in Version

3.2

Summary

0004128: Shaders for lights can't be enabled unless compiling with MSVC

Description

In gl_framebuffer.cpp > OpenGLFrameBuffer::InitializeState, gl_PrintStartupLog is guarded behind a _MSC_VER ifdef, so it never gets called at all unless compiling with MSVC. Which is, well, impossible for every platform except Windows.

gl_PrintStartupLog handles printing the OpenGL info at startup time and also (for some reason) setting gl.maxuniforms. gl.maxuniforms is required to be at least 1024 to allow enabling shaders for lights, however it'll remain at 0 if the function is never called.

That could be moved outside of gl_PrintStartupLog, or the _MSC_VER check could be removed (or alternatively replaced with #ifndef __MINGW32__), since the source only mentions it being a problem for MinGW, and I can confirm there's no crash when compiling with GCC on Linux. That way the startup GL info will also be shown.

gl_dynlight_shader allows for much higher framerates and makes it possible to make user shaders interact with dynamic lights, so I believe it's at least somewhat important to have it working on Linux too.

Attached Files

Relationships

Notes
(0023544) TDRR (reporter) 2024-04-08 00:21	Fix was recently merged, so the issue has been resolved. 'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/d6971f687d1ee8625163f71117d682bfc8cc326f [^]'

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2023-04-22 02:50	TDRR	New Issue
2024-04-08 00:21	TDRR	Note Added: 0023544
2024-04-08 00:25	Kaminsky	Status	new => resolved
2024-04-08 00:25	Kaminsky	Fixed in Version	=> 3.2
2024-04-08 00:25	Kaminsky	Resolution	open => fixed
2024-04-08 00:25	Kaminsky	Assigned To	=> Kaminsky
2024-04-08 01:10	Ru5tK1ng	Status	resolved => feedback
2024-04-08 01:10	Ru5tK1ng	Resolution	fixed => reopened
2024-04-08 01:10	Ru5tK1ng	Status	feedback => resolved
2024-04-08 01:10	Ru5tK1ng	Resolution	reopened => fixed
2024-04-08 01:10	Ru5tK1ng	Target Version	=> 3.2

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.