0004042: server crash when a custom team wins via points

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004042

Zandronum

[All Projects] Bug

public

2022-10-02 23:04

2024-01-01 01:09

Reporter

WaTaKiD

Assigned To

Kaminsky

Priority

normal

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

3.1

Target Version

3.2

Fixed in Version

3.2

Summary

0004042: server crash when a custom team wins via points

Description

'https://euroboros.net/zandronum/download.php?file=tsb_inhumanmonstrosityv0.31.pk3 [^]'

this mod crashes servers when the "monstrosities" team wins via collecting souls from fragged "inhuman" team players

Steps To Reproduce

host a server with the mentioned wad with team deathmatch on map IMM01 with a pointlimit of 1
connect 2 clients, have em join different teams
take the monstrosity player and kill the inhuman player
a green floating orb will drop, go to it and press use
server crash

Additional Information

crash happens in both zan 3.1 and 3.2
windows and linux
no crash report is generated, even in 32 bit
only the mod's custom maps IMM01-IMM05 crash
while nothing of value shows up in a windows server log, the tspg linux log showed this: [22-10-02 15:39:39] *** buffer overflow detected ***: terminated

Attached Files

Relationships

Notes
(0022430) Kaminsky (developer) 2022-10-03 00:54	For the record, the crash occurs in TEAM_DoWinSequence in team.cpp: char szString[32]; DHUDMessageFadeOut *pMsg; // Display "%s WINS!" HUD message. if ( ulTeamIdx < teams.Size( ) ) sprintf( szString, "\\c%s%s WINS!", TEAM_GetTextColorName( ulTeamIdx ), TEAM_GetName( ulTeamIdx )); else sprintf( szString, "DRAW GAME!\n" ); A string like "\x1c[Blue]Monstrosities united WINS!" can't fit completely in a char array with only 32 elements.

(0022818) Kaminsky (developer) 2023-03-22 04:38	This particular issue should've been fixed now with:'http://hg.osdn.net/view/zandronum/zandronum-stable/rev/cca76668e470 [^]'

(0022945) Ru5tK1ng (updater) 2024-01-01 01:08	Tested with r231220 and was unable to invoke a crash when following the outlined instructions with provided pk3.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2022-10-02 23:04	WaTaKiD	New Issue
2022-10-02 23:07	WaTaKiD	Additional Information Updated	View Revisions
2022-10-02 23:09	WaTaKiD	Additional Information Updated	View Revisions
2022-10-03 00:50	Kaminsky	Assigned To	=> Kaminsky
2022-10-03 00:50	Kaminsky	Status	new => confirmed
2022-10-03 00:54	Kaminsky	Note Added: 0022430
2022-11-13 21:40	WaTaKiD	Target Version	=> 3.2
2023-03-22 04:38	Kaminsky	Note Added: 0022818
2023-03-22 04:38	Kaminsky	Status	confirmed => needs testing
2024-01-01 01:08	Ru5tK1ng	Note Added: 0022945
2024-01-01 01:09	Ru5tK1ng	Status	needs testing => resolved
2024-01-01 01:09	Ru5tK1ng	Resolution	open => fixed
2024-01-01 01:09	Ru5tK1ng	Fixed in Version	=> 3.2

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.