Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004027Doomseeker[All Projects] Documentationpublic2022-09-07 12:132024-11-03 19:12
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytweakReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004027: IpToCountry_v3.dat.SPECS.txt is ambiguous about the support for multiple sections with the same Type field
Description0003952:0022367:
Quote from WubTheCaptain
What I did not understand from reading the V3 spec is if there can be multiple sections with the same Type BYTE, e.g. multiple Type 0 (license) sections.
Steps To Reproduce'https://bitbucket.org/Doomseeker/doomseeker-blobs/src/1401483906a6a6efede29f55eb7a0542165fdf46/IpToCountry_v3.dat.SPECS.txt [^]'
Quote
Section
-------

Sections can contain any arbitrary data. The Type of the section informs
what should be expected in the given section and how should it be parsed.

The sections can appear in any order, so the file can have Types
"2, 0, 1" just as well as "0, 1, 2". No section is mandatory either.


  Field    | Size      | Description
  -----------------------------------
  Type     | BYTE      | 0 for Licence, 1 for GeoIP, 2 for URL.
  Size     | ULONGLONG | Size of the section in bytes.
  Payload  | <Size>    | Contents of the section.
Additional InformationThe above quoted text in steps to reproduce has the following copyright notice:
Quote
Copyright
=========

Copyright (C) 2022 The Doomseeker Team

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.  This file is offered as-is,
without any warranty.
Attached Files

- Relationships

-  Notes
User avatar (0022368)
WubTheCaptain (reporter)
2022-09-07 12:22

V3 also has an unfortunate design: There is no easy way to tie multiple Type 0 ("license", aka "Text of the licence note.") and Type 2 ("URL", aka "The URL to the database's home page.") together? Specifically with Creative Commons attribution licenses, these two need to be tied together by the license's requirements. I detailed this more in my other note 0003952:0022365.
User avatar (0022371)
Zalewa (developer)
2022-09-07 12:52
edited on: 2022-09-07 12:52

Acknowledging that this is an omission in the spec. The licence and geoip sections can exist many times and the program should parse them as they go and append the data to the already known data. The URL section can also theoretically exist more than once but I don't see a purpose for that. Maybe to have more than one home page? The current implementation will just overwrite the previous URL if this section occurs again. In any of these cases it should be considered abnormal to have more than one of each section.

Quote from WubTheCaptain
There is no easy way to tie multiple Type 0 ("license", aka "Text of the licence note.") and Type 2 ("URL", aka "The URL to the database's home page.") together?

Because those sections aren't meant to be associated together. If you need an URL to the licence you can embed it in the licence note. The program won't make it clickable though.

User avatar (0022375)
Zalewa (developer)
2022-09-07 15:27

I hope this will explain the ambiguities:'https://bitbucket.org/Doomseeker/doomseeker-blobs/commits/70c550c129105304d0a415260f6575b2ea80c49e [^]'
User avatar (0022639)
Zalewa (developer)
2023-01-05 12:08

Since there are no further remarks I consider this as resolved.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2022-09-07 12:13 WubTheCaptain New Issue
2022-09-07 12:22 WubTheCaptain Note Added: 0022368
2022-09-07 12:42 WubTheCaptain Note Added: 0022369
2022-09-07 12:45 WubTheCaptain Note Edited: 0022369 View Revisions
2022-09-07 12:45 WubTheCaptain Note Edited: 0022369 View Revisions
2022-09-07 12:47 WubTheCaptain Note Deleted: 0022369
2022-09-07 12:52 Zalewa Note Added: 0022371
2022-09-07 12:52 Zalewa Assigned To => Zalewa
2022-09-07 12:52 Zalewa Status new => acknowledged
2022-09-07 12:52 Zalewa Note Edited: 0022371 View Revisions
2022-09-07 15:27 Zalewa Note Added: 0022375
2022-09-07 15:27 Zalewa Status acknowledged => needs review
2022-09-10 14:30 Zalewa Target Version => 1.4.0
2023-01-05 12:08 Zalewa Note Added: 0022639
2023-01-05 12:08 Zalewa Status needs review => resolved
2023-01-05 12:08 Zalewa Fixed in Version => 1.4.0
2023-01-05 12:08 Zalewa Resolution open => fixed
2024-11-03 19:12 Zalewa Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker