0003913: Zandro crashes on exit when CF 4.x is loaded.

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003913

Zandronum

[All Projects] Bug

public

2021-10-28 20:07

2021-12-04 18:17

Reporter

Mr. Satan

Assigned To

Kaminsky

Priority

normal

Severity

crash

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Microsoft

Windows

OS Version

8.1

Product Version

3.1-beta

Target Version

Fixed in Version

3.1-beta

Summary

0003913: Zandro crashes on exit when CF 4.x is loaded.

Description

Zandronum X64 build 211026-1439 crashes when CF is loaded, then Zandro is exited via menu or the close button in windowed mode. This happens in full screen or windowed mode.

Unhandled exception at 0x00007FF60CD44F3F in zandronum.exe: 0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFF.

Steps To Reproduce

Load CF.
bulletpuff_fix.wad
complex-doom.v26a2.pk3
lca-v1.5.9.6.pk3
randomons-1.2.5.1.pk3
complex-clusterfuck-v4.1.2
Start then Zandro then exit.

Additional Information

while (*cp != 0)
{
  // 28 is the escape code for a color change.
  if ((*cp == 28 && bpos != 0) || bpos == 255)
  {
    buf[bpos] = 0;
    if (edit != NULL)
    {
      ToEditControl(edit, buf, wbuf, bpos);
    }
    if (StdOut != NULL)
    {
      DWORD bytes_written;
      WriteFile(StdOut, buf, bpos, &bytes_written, NULL);
    }
    bpos = 0;
  }
  if (*cp != 28)
  {
    buf[bpos++] = *cp++;
  }
  else
  {
    const BYTE *color_id = (const BYTE *)cp + 1;
    EColorRange range = V_ParseFontColor(color_id, CR_UNTRANSLATED, CR_YELLOW);
    cp = (const char *)color_id;
    if (range != CR_UNDEFINED)
    {
      // Change the color of future text added to the control.
      PalEntry color = V_LogColorFromColorRange(range);
      if (StdOut != NULL && FancyStdOut)
      {
    // Unfortunately, we are pretty limited here: There are only
    // eight basic colors, and each comes in a dark and a bright
    // variety.
    float h, s, v, r, g, b;
    WORD attrib = 0;
    RGBtoHSV(color.r / 255.f, color.g / 255.f, color.b / 255.f, &h, &s, &v);
    if (s != 0)
    { // color
      HSVtoRGB(&r, &g, &b, h, 1, 1);
      if (r == 1) attrib = FOREGROUND_RED;
      if (g == 1) attrib |= FOREGROUND_GREEN;
      if (b == 1) attrib |= FOREGROUND_BLUE;
      if (v > 0.6) attrib |= FOREGROUND_INTENSITY;
    }
    else
    { // gray
      if (v < 0.33) attrib = FOREGROUND_INTENSITY;
      else if (v < 0.90) attrib = FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE;
      else attrib = FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY;
    }
    SetConsoleTextAttribute(StdOut, attrib);
      }
      if (edit != NULL)
      {
    // GDI uses BGR colors, but color is RGB, so swap the R and the B.
    swapvalues(color.r, color.b);
    // Change the color.
    format.cbSize = sizeof(format);
    format.dwMask = CFM_COLOR;
    format.dwEffects = 0;
    format.crTextColor = color;
    SendMessage(edit, EM_SETCHARFORMAT, SCF_SELECTION, (LPARAM)&format);
      }
    }
  }
}

Attached Files

CrashReport CF.zip [^] (51,671 bytes) 2021-10-28 21:19

Relationships

Notes
(0021847) Kaminsky (developer) 2021-12-04 18:17	Marking this as resolved, as WaTaKiD confirmed that the crashes don't occur anymore after testing with the 32-bit and 64-bit Windows builds.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2021-10-28 20:07	Mr. Satan	New Issue
2021-10-28 21:19	Mr. Satan	File Added: CrashReport CF.zip
2021-10-29 03:51	Kaminsky	Assigned To	=> Kaminsky
2021-10-29 03:51	Kaminsky	Status	new => confirmed
2021-10-30 18:30	Kaminsky	Status	confirmed => needs review
2021-10-31 15:59	Kaminsky	Status	needs review => needs testing
2021-12-04 18:17	Kaminsky	Note Added: 0021847
2021-12-04 18:17	Kaminsky	Status	needs testing => resolved
2021-12-04 18:17	Kaminsky	Fixed in Version	=> 3.1-beta
2021-12-04 18:17	Kaminsky	Resolution	open => fixed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.