Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003824Doomseeker[All Projects] Cleanuppublic2020-06-09 14:382020-06-15 00:22
ReporterWubTheCaptain 
Assigned To 
PrioritynoneSeveritytrivialReproducibilityalways
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003824: No AUTOUIC, qt5_wrap_ui() macro is used
DescriptionCMake's build files handle Qt's XML format user interface definition (.ui) files manually, with qt5_wrap_ui() macro. May be more ideal to use CMake's AUTOUIC to avoid cluttering the build files, which has been supported since CMake 3.0 or so.
Steps To Reproduce
$ grep -r "qt5_wrap_ui" .
./src/plugins/zandronum/CMakeLists.txt:qt5_wrap_ui(ZANDRONUM_UI_FILES
./src/core/CMakeLists.txt:qt5_wrap_ui(doomseekerUI ${UI_FILES})

$ grep -r "UI_FILES" .
./src/plugins/zandronum/CMakeLists.txt:qt5_wrap_ui(ZANDRONUM_UI_FILES
./src/plugins/zandronum/CMakeLists.txt: ${ZANDRONUM_UI_FILES}
./src/plugins/zandronum/CMakeLists.txt: ${ZANDRONUM_UI_FILES}
./src/core/CMakeSpawnFileListing.cmake:file(GLOB_RECURSE UI_FILES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} 
"*.ui")
./src/core/CMakeSpawnFileListing.cmake:append_file_list(${FILE_NAME} "UI_FILES" "${UI_FILES}")

./src/core/CMakeLists.txt:qt5_wrap_ui(doomseekerUI ${UI_FILES})
./src/core/CMakeLists.txt:      ${UI_FILES}
./src/core/CMakeFileListing.cmake:set(UI_FILES
Additional Informationhttps://cmake.org/cmake/help/latest/prop_tgt/AUTOUIC.html [^]
https://stackoverflow.com/a/42331649 [^]
git blame src/core/CMakeLists.txt says git show 95cdd026d, by Pol M.
Attached Files

- Relationships

-  Notes
User avatar (0021460)
WubTheCaptain (developer)
2020-06-09 14:40

And no offense to Pol M, the previous qt4_wrap_ui() that commit mentioned in OP was likely predating CMake 3.0 too.
User avatar (0021463)
Pol M (developer)
2020-06-15 00:22

Pretty in favor, I did not know this existed and it seems cleaner and more future proof. Any shenanigans that we do in cmake that can be automated further are a clear improvement.
No offense taken, I just took the simple path as at the time that was as much as it was needed.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Zalewa Pol M
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-09 14:38 WubTheCaptain New Issue
2020-06-09 14:40 WubTheCaptain Note Added: 0021460
2020-06-09 14:40 WubTheCaptain Severity feature => trivial
2020-06-15 00:22 Pol M Note Added: 0021463
2020-06-15 00:22 Pol M Status new => confirmed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker