0003816: We don't use clang-tidy and it's not integrated to CMake

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003816

Doomseeker

[All Projects] Suggestion

public

2020-06-07 06:19

2020-06-07 20:54

Reporter

WubTheCaptain

Assigned To

Priority

low

Severity

feature

Reproducibility

N/A

Status

feedback

Resolution

open

Platform

OS Version

Product Version

1.3

Target Version

Fixed in Version

Summary

0003816: We don't use clang-tidy and it's not integrated to CMake

Description

So... Integrating clang-tidy into CMake.
Issue 0003591 initially suggested .clang-format. The issue ended up with uncrustify.
I have to admit I never ran uncrustify. Now I learned there's CMAKE_CXX_CLANG_TIDY for CMake, and that seems... more optimal, in a way.
Given that I've been looking for clang-tidy issues manually and reporting issues (12+ I count) from it today (without actually running clang-tidy), it seems like an useful tool. I should ask: Should we integrate clang-tidy with our CMake build process? May turn uncrustify unnecessary, I don't know.

Additional Information

'https://ortogonal.github.io/cmake-clang-tidy/ [^]'

Attached Files

Relationships

Notes
(0021390) Pol M (developer) 2020-06-07 20:53	Quote May turn uncrustify unnecessary, I don't know. Nope :). uncrustify provides us with formatting, which is important in order to simplify a global coding convention, while clang-tidy does a different job, which is to report on suspicious code patterns. Onto whether it should be integrated into cmake, I'd argue that it is not necessary. You can accually just generate a "compile_commands.json" file and with a script like'https://clang.llvm.org/extra/doxygen/run-clang-tidy_8py_source.html [^]' you can run it through the entirety of our code. No need to touch cmake! :D

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2020-06-07 06:19	WubTheCaptain	New Issue
2020-06-07 20:53	Pol M	Note Added: 0021390
2020-06-07 20:54	Pol M	Status	new => feedback

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.