Anonymous | Login | Signup for a new account | 2024-04-25 05:32 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003798 | Doomseeker | [All Projects] Cleanup | public | 2020-06-05 09:22 | 2021-08-16 19:11 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Blzut3 | ||||||||
Priority | normal | Severity | trivial | Reproducibility | have not tried | ||||
Status | closed | Resolution | invalid | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.2 | ||||||||
Target Version | 1.3.2 | Fixed in Version | |||||||
Summary | 0003798: Unused <cstdio> in src/core/main.cpp | ||||||||
Description | 'https://en.cppreference.com/w/cpp/header/cstdio [^]' None of that is needed or in use @ main.cpp. | ||||||||
Attached Files | 0001-core-main-Remove-unused-cstdio.patch [^] (819 bytes) 2020-06-05 09:23 [Show Content] | ||||||||
Notes | |
(0021356) WubTheCaptain (reporter) 2020-06-05 20:09 |
git blame points to commit d459773f039f39fec1df7a8fc1243470547f3ed9 for a cause.Quote from Zalewa That uses <QFile>. gLog is: src/core/log.h:#define gLog Log::instance. And sure enough, <cstdio> is in src/core/log.cpp too. |
(0021410) Blzut3 (administrator) 2020-06-08 02:03 |
It may use QFile but it also uses the stdout variable from cstdio. 'https://bitbucket.org/Doomseeker/doomseeker/src/b04ff58466cc3e9bba3f367fba308ae975e720cd/src/core/main.cpp#lines-299 [^]' |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2020-06-05 09:22 | WubTheCaptain | New Issue | |
2020-06-05 09:22 | WubTheCaptain | Status | new => assigned |
2020-06-05 09:22 | WubTheCaptain | Assigned To | => WubTheCaptain |
2020-06-05 09:23 | WubTheCaptain | File Added: 0001-core-main-Remove-unused-cstdio.patch | |
2020-06-05 09:23 | WubTheCaptain | Assigned To | WubTheCaptain => |
2020-06-05 09:23 | WubTheCaptain | Status | assigned => needs review |
2020-06-05 20:09 | WubTheCaptain | Note Added: 0021356 | |
2020-06-05 20:13 | WubTheCaptain | Product Version | 1.3.1 => 1.2 |
2020-06-08 02:03 | Blzut3 | Note Added: 0021410 | |
2020-06-08 02:04 | Blzut3 | Status | needs review => resolved |
2020-06-08 02:04 | Blzut3 | Resolution | open => invalid |
2020-06-08 02:04 | Blzut3 | Assigned To | => Blzut3 |
2021-08-07 16:52 | Blzut3 | Status | resolved => closed |
2021-08-16 19:11 | WubTheCaptain | Target Version | 1.3.3 => 1.3.2 |
Copyright © 2000 - 2024 MantisBT Team |