Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003798Doomseeker[All Projects] Cleanuppublic2020-06-05 09:222020-06-08 02:04
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusresolvedResolutioninvalid 
PlatformOSOS Version
Product Version1.2 
Target Version1.4Fixed in Version 
Summary0003798: Unused <cstdio> in src/core/main.cpp
Descriptionhttps://en.cppreference.com/w/cpp/header/cstdio [^]
None of that is needed or in use @ main.cpp.
Attached Filespatch file icon 0001-core-main-Remove-unused-cstdio.patch [^] (819 bytes) 2020-06-05 09:23 [Show Content]

- Relationships

-  Notes
User avatar (0021356)
WubTheCaptain (developer)
2020-06-05 20:09

git blame points to commit d459773f039f39fec1df7a8fc1243470547f3ed9 for a cause.

Quote from Zalewa
- --version-json can now dump to stdout if file argument is omitted or specified as '-'. Addresses 0003282.


That uses <QFile>.

gLog is: src/core/log.h:#define gLog Log::instance. And sure enough, <cstdio> is in src/core/log.cpp too.
User avatar (0021410)
Blzut3 (administrator)
2020-06-08 02:03

It may use QFile but it also uses the stdout variable from cstdio.

https://bitbucket.org/Doomseeker/doomseeker/src/b04ff58466cc3e9bba3f367fba308ae975e720cd/src/core/main.cpp#lines-299 [^]

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-06-05 09:22 WubTheCaptain New Issue
2020-06-05 09:22 WubTheCaptain Status new => assigned
2020-06-05 09:22 WubTheCaptain Assigned To => WubTheCaptain
2020-06-05 09:23 WubTheCaptain File Added: 0001-core-main-Remove-unused-cstdio.patch
2020-06-05 09:23 WubTheCaptain Assigned To WubTheCaptain =>
2020-06-05 09:23 WubTheCaptain Status assigned => needs review
2020-06-05 20:09 WubTheCaptain Note Added: 0021356
2020-06-05 20:13 WubTheCaptain Product Version 1.3.1 => 1.2
2020-06-08 02:03 Blzut3 Note Added: 0021410
2020-06-08 02:04 Blzut3 Status needs review => resolved
2020-06-08 02:04 Blzut3 Resolution open => invalid
2020-06-08 02:04 Blzut3 Assigned To => Blzut3






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker