MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003798Doomseeker[All Projects] Cleanuppublic2020-06-05 09:222021-08-16 19:11
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutioninvalid 
PlatformOSOS Version
Product Version1.2 
Target Version1.3.2Fixed in Version 
Summary0003798: Unused <cstdio> in src/core/main.cpp
Description'https://en.cppreference.com/w/cpp/header/cstdio [^]'
None of that is needed or in use @ main.cpp.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-core-main-Remove-unused-cstdio.patch (819) 2020-06-05 09:23
/tracker/file_download.php?file_id=2606&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-06-05 09:22WubTheCaptainNew Issue
2020-06-05 09:22WubTheCaptainStatusnew => assigned
2020-06-05 09:22WubTheCaptainAssigned To => WubTheCaptain
2020-06-05 09:23WubTheCaptainFile Added: 0001-core-main-Remove-unused-cstdio.patch
2020-06-05 09:23WubTheCaptainAssigned ToWubTheCaptain =>
2020-06-05 09:23WubTheCaptainStatusassigned => needs review
2020-06-05 20:09WubTheCaptainNote Added: 0021356
2020-06-05 20:13WubTheCaptainProduct Version1.3.1 => 1.2
2020-06-08 02:03Blzut3Note Added: 0021410
2020-06-08 02:04Blzut3Statusneeds review => resolved
2020-06-08 02:04Blzut3Resolutionopen => invalid
2020-06-08 02:04Blzut3Assigned To => Blzut3
2021-08-07 16:52Blzut3Statusresolved => closed
2021-08-16 19:11WubTheCaptainTarget Version1.3.3 => 1.3.2

Notes
(0021356)
WubTheCaptain   
2020-06-05 20:09   
git blame points to commit d459773f039f39fec1df7a8fc1243470547f3ed9 for a cause.

Quote from Zalewa
- --version-json can now dump to stdout if file argument is omitted or specified as '-'. Addresses 0003282.


That uses <QFile>.

gLog is: src/core/log.h:#define gLog Log::instance. And sure enough, <cstdio> is in src/core/log.cpp too.
(0021410)
Blzut3   
2020-06-08 02:03   
It may use QFile but it also uses the stdout variable from cstdio.

'https://bitbucket.org/Doomseeker/doomseeker/src/b04ff58466cc3e9bba3f367fba308ae975e720cd/src/core/main.cpp#lines-299 [^]'