0000367: Backport extended nodes

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000367

Zandronum

[All Projects] Suggestion

public

2011-04-04 12:25

2018-09-30 20:07

Reporter

Gez

Assigned To

Torr Samaho

Priority

normal

Severity

trivial

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

1.0

Summary

0000367: Backport extended nodes

Description

I'm suggesting an out-of-order backport to add support for extended nodes (XNOD, XGLN, XGL2 signatures) to Skulltag for the next official version.

Why? Because they are already supported by non-ZDoom ports such as Eternity and PrBoom+ and are used by some high-profile projects, notably Mechadon's Vela Pax and Gazebo's Sunder. Having Skulltag adopt them as soon as possible would be a big step for cross-compatibility.

On the technical side, it shouldn't be intrusive in anyway, the code is already there to read compressed nodes, this is the same just skipping the decompression step.

Additional Information

This corresponds to ZDoom revision 2287. You may also want to port r2285 while you're at it, though it isn't necessary.

Attached Files

Relationships

Notes
(0001295) Torr Samaho (administrator) 2011-04-06 01:13	I agree, Cross-compatibility is important and backported the changes from revision 2287. I also had a look at the changes from revision 2285. To port them without conflicts I'd also need to backport 2263. Do you know if this could have any undesired side effects?

(0001298) Gez (reporter) 2011-04-06 10:59	Other than fixing script problems in CIF3 and taking up more memory for some data structures since shorts are expanded to words, there shouldn't be side effects as far as I know.

(0001316) Torr Samaho (administrator) 2011-04-09 14:46	I noticed that 2285 is also intertwined with 2151. Since you said 2285 is not necessary, it's probably better to not backport it for now.

(0001372) Gez (reporter) 2011-04-15 11:27	I guess this can be marked as resolved now?

(0001374) Torr Samaho (administrator) 2011-04-16 17:56	Yes :).

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-04-04 12:25	Gez	New Issue
2011-04-06 01:13	Torr Samaho	Note Added: 0001295
2011-04-06 01:14	Torr Samaho	Assigned To	=> Torr Samaho
2011-04-06 01:14	Torr Samaho	Status	new => feedback
2011-04-06 10:59	Gez	Note Added: 0001298
2011-04-06 10:59	Gez	Status	feedback => assigned
2011-04-09 14:46	Torr Samaho	Note Added: 0001316
2011-04-09 14:46	Torr Samaho	Status	assigned => feedback
2011-04-15 11:27	Gez	Note Added: 0001372
2011-04-15 11:27	Gez	Status	feedback => assigned
2011-04-16 17:56	Torr Samaho	Note Added: 0001374
2011-04-16 17:56	Torr Samaho	Status	assigned => resolved
2011-04-16 17:56	Torr Samaho	Fixed in Version	=> 1.0
2011-04-16 17:56	Torr Samaho	Resolution	open => fixed
2018-09-30 20:07	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.