0000363: Spheres Affected by Gravity compatflag

(0001276)
Edward-san (developer)
2011-04-03 18:17
edited on: 2011-04-03 18:20

You can see a funny thing:

use the example wad of'http://skulltag.net/tracker/view.php?id=319 [^]' ;
'noclip' to the voodoo dolls area near you;
you can see the megaspheres not moving from the initial position.

(0001288)
Gez (reporter)
2011-04-04 12:32

In truth, it probably should be reverted to the normal behavior and maybe gravityless variants of the powerup created to replace their standard variants in the few maps that "required" this change.

(0001291)
unknownna (updater)
2011-04-05 12:09
edited on: 2011-04-05 12:13

> In truth, it probably should be reverted to the normal behavior

I agree.

Skulltag:

// [BC] I've applied +NOGRAVITY to all sphere powerups.

ACTOR Megasphere : CustomInventory 83
{
    Game Doom
    SpawnID 132
    +COUNTITEM
    +NOGRAVITY
    +INVENTORY.ALWAYSPICKUP
    Inventory.PickupMessage "$GOTMSPHERE"
    Inventory.PickupSound "misc/p_pkup"
    Inventory.PickupAnnouncerEntry "megasphere"
    States
    {
    Spawn:
        MEGA ABCD 6 BRIGHT
        Loop
    Pickup:
        TNT1 A 0 A_GiveInventory("BlueArmorForMegasphere", 1)
        TNT1 A 0 A_GiveInventory("MegasphereHealth", 1)
        Stop
    }
}

GZDoom 323:

ACTOR Megasphere : CustomInventory 83
{
    Game Doom
    SpawnID 132
    +COUNTITEM
    +INVENTORY.ALWAYSPICKUP
    Inventory.PickupMessage "$GOTMSPHERE"
    Inventory.PickupSound "misc/p_pkup"
    States
    {
    Spawn:
        MEGA ABCD 6 BRIGHT
        Loop
    Pickup:
        TNT1 A 0 A_GiveInventory("BlueArmorForMegasphere", 1)
        TNT1 A 0 A_GiveInventory("MegasphereHealth", 1)
        Stop
    }
}

(0001292)
Torr Samaho (administrator)
2011-04-05 12:17

> In truth, it probably should be reverted to the normal behavior

I agree with this, too. Nevertheless I think we need a compat flag that restores the current behavior then because some mods rely on it.

(0001319)
Torr Samaho (administrator)
2011-04-09 21:04

Ok, I removed NOGRAVITY from InvulnerabilitySphere, Soulsphere, Megasphere and BlurSphere and added the new compatflag "nogravity spheres", controlled by the new CVAR compat_nogravity_spheres. The compatflag gives these spheres the NOGRAVITY flag again, but only when they are spawned by the map. Please test.

(0001321)
unknownna (updater)
2011-04-09 22:24
edited on: 2011-04-09 22:28

> Please test.

It works, but if sv_itemrespawn and sv_respawnsuper is 1, the NOGRAVITY spheres will not respawn with the flag applied to them.

(0001322)
Torr Samaho (administrator)
2011-04-10 01:44

This hopefully fixes the respawn issue.

(0001323)
unknownna (updater)
2011-04-10 11:19

Yes, it seems to work now.

(0001324)
Torr Samaho (administrator)
2011-04-10 12:26

Ok, so I can consider this to be resolved, right?

(0001401)
unknownna (updater)
2011-04-20 23:22

Not yet. The spheres don't have the NOGRAVITY flag applied to them after a map reset if compat_nogravity_spheres is set to 1.

(0001448)
Torr Samaho (administrator)
2011-04-24 21:37

Ok, this should also fix the problems after a map reset.

(0001451)
unknownna (updater)
2011-04-24 22:12

It seems to work under normal conditions, but I somehow managed to desync the spheres. I don't know how to reproduce it yet.

(0001468)
unknownna (updater)
2011-04-25 13:01

1. Start a survival server with nogravity_sphere_test_02.wad loaded. Make sure that compat_nogravity_spheres is set to 1.
2. Connect a client to the server.
3. Join the game.
4. During the warm-up countdown, "compat_nogravity_spheres 0" in the console.

It doesn't always desync though. But in the worst case, none of the spheres will be affected by gravity when compat_nogravity_spheres is set to 0.

(0001483)
Torr Samaho (administrator)
2011-04-26 23:49

Well, compat_nogravity_spheres is not supposed to be changed during the game (but there is no convenient way to prevent it from being toggled freely). It's just a crutch to keep the few existing maps that rely on it working. As long as it fulfills this purpose, I think we shouldn't put any more work into it.

(0001484)
unknownna (updater)
2011-04-27 00:04

I agree, but I wonder if this is a symptom of a deeper problem.

(0001488)
Torr Samaho (administrator)
2011-04-28 01:21

Depends on what you mean with desync: Does this mean that client and server don't agree on whether the sphere has NOGRAVITY?

(0001489)
unknownna (updater)
2011-04-28 01:27

> Does this mean that client and server don't agree on whether the sphere has NOGRAVITY?

No, it seems that the client and server are synced together.

(0001497)
unknownna (updater)
2011-04-29 01:25
edited on: 2011-04-29 01:59

I found another issue: Spheres aren't affected by the compatflag after a map reset in (Team)Possession. Perhaps it's not a bug.

Edit:

It seems that if sv_itemrespawn/sv_respawnsuper is set to 0, items will not respawn during map resets in (Team)Possession.

(0001527)
Torr Samaho (administrator)
2011-05-01 13:12
edited on: 2011-05-01 13:18

For some reason possession deliberately doesn't do a full map reset. It just respawns everything that would respawn based on the current dmflags. So I'd say this is not really a bug.

Nevertheless, does anybody see a good reason why possession doesn't do a full map reset?

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-04-03 01:08	XutaWoo	New Issue
2011-04-03 18:17	Edward-san	Note Added: 0001276
2011-04-03 18:20	Edward-san	Note Edited: 0001276	View Revisions
2011-04-04 12:32	Gez	Note Added: 0001288
2011-04-05 12:09	unknownna	Note Added: 0001291
2011-04-05 12:13	unknownna	Note Edited: 0001291	View Revisions
2011-04-05 12:13	unknownna	Note Edited: 0001291	View Revisions
2011-04-05 12:17	Torr Samaho	Note Added: 0001292
2011-04-09 21:04	Torr Samaho	Note Added: 0001319
2011-04-09 21:07	Torr Samaho	Assigned To	=> Torr Samaho
2011-04-09 21:07	Torr Samaho	Status	new => feedback
2011-04-09 22:24	unknownna	Note Added: 0001321
2011-04-09 22:28	unknownna	Note Edited: 0001321	View Revisions
2011-04-09 22:29	unknownna	Status	feedback => assigned
2011-04-10 01:44	Torr Samaho	Note Added: 0001322
2011-04-10 01:47	Torr Samaho	Status	assigned => feedback
2011-04-10 11:19	unknownna	Note Added: 0001323
2011-04-10 11:23	unknownna	Status	feedback => assigned
2011-04-10 11:23	unknownna	File Added: nogravity_sphere_test_01.wad
2011-04-10 12:26	Torr Samaho	Note Added: 0001324
2011-04-10 12:34	Torr Samaho	Status	assigned => feedback
2011-04-20 23:21	unknownna	File Added: nogravity_sphere_test_02.wad
2011-04-20 23:22	unknownna	Note Added: 0001401
2011-04-24 21:37	Torr Samaho	Note Added: 0001448
2011-04-24 22:04	unknownna	File Added: Screenshot_Doom_20110425_000202.png
2011-04-24 22:12	unknownna	Note Added: 0001451
2011-04-25 13:01	unknownna	Note Added: 0001468
2011-04-26 23:49	Torr Samaho	Note Added: 0001483
2011-04-27 00:04	unknownna	Note Added: 0001484
2011-04-28 01:21	Torr Samaho	Note Added: 0001488
2011-04-28 01:27	unknownna	Note Added: 0001489
2011-04-29 01:25	unknownna	Note Added: 0001497
2011-04-29 01:33	unknownna	Note Edited: 0001497	View Revisions
2011-04-29 01:58	unknownna	Note Edited: 0001497	View Revisions
2011-04-29 01:59	unknownna	Note Edited: 0001497	View Revisions
2011-05-01 13:12	Torr Samaho	Note Added: 0001527
2011-05-01 13:18	Torr Samaho	Note Edited: 0001527	View Revisions
2011-05-22 13:52	Torr Samaho	Relationship added	parent of 0000461
2012-04-13 14:41	Edward-san	Relationship added	parent of 0000768
2015-09-01 21:02	Dusk	Status	feedback => resolved
2015-09-01 21:02	Dusk	Resolution	open => fixed
2018-09-30 22:37	Blzut3	Status	resolved => closed

Notes
(0001276) Edward-san (developer) 2011-04-03 18:17 edited on: 2011-04-03 18:20	You can see a funny thing: use the example wad of'http://skulltag.net/tracker/view.php?id=319 [^]' ; 'noclip' to the voodoo dolls area near you; you can see the megaspheres not moving from the initial position.

(0001288) Gez (reporter) 2011-04-04 12:32	In truth, it probably should be reverted to the normal behavior and maybe gravityless variants of the powerup created to replace their standard variants in the few maps that "required" this change.

(0001291) unknownna (updater) 2011-04-05 12:09 edited on: 2011-04-05 12:13	> In truth, it probably should be reverted to the normal behavior I agree. Skulltag: // [BC] I've applied +NOGRAVITY to all sphere powerups. ACTOR Megasphere : CustomInventory 83 { Game Doom SpawnID 132 +COUNTITEM +NOGRAVITY +INVENTORY.ALWAYSPICKUP Inventory.PickupMessage "$GOTMSPHERE" Inventory.PickupSound "misc/p_pkup" Inventory.PickupAnnouncerEntry "megasphere" States { Spawn: MEGA ABCD 6 BRIGHT Loop Pickup: TNT1 A 0 A_GiveInventory("BlueArmorForMegasphere", 1) TNT1 A 0 A_GiveInventory("MegasphereHealth", 1) Stop } } GZDoom 323: ACTOR Megasphere : CustomInventory 83 { Game Doom SpawnID 132 +COUNTITEM +INVENTORY.ALWAYSPICKUP Inventory.PickupMessage "$GOTMSPHERE" Inventory.PickupSound "misc/p_pkup" States { Spawn: MEGA ABCD 6 BRIGHT Loop Pickup: TNT1 A 0 A_GiveInventory("BlueArmorForMegasphere", 1) TNT1 A 0 A_GiveInventory("MegasphereHealth", 1) Stop } }

(0001292) Torr Samaho (administrator) 2011-04-05 12:17	> In truth, it probably should be reverted to the normal behavior I agree with this, too. Nevertheless I think we need a compat flag that restores the current behavior then because some mods rely on it.

(0001319) Torr Samaho (administrator) 2011-04-09 21:04	Ok, I removed NOGRAVITY from InvulnerabilitySphere, Soulsphere, Megasphere and BlurSphere and added the new compatflag "nogravity spheres", controlled by the new CVAR compat_nogravity_spheres. The compatflag gives these spheres the NOGRAVITY flag again, but only when they are spawned by the map. Please test.

(0001321) unknownna (updater) 2011-04-09 22:24 edited on: 2011-04-09 22:28	> Please test. It works, but if sv_itemrespawn and sv_respawnsuper is 1, the NOGRAVITY spheres will not respawn with the flag applied to them.

(0001322) Torr Samaho (administrator) 2011-04-10 01:44	This hopefully fixes the respawn issue.

(0001323) unknownna (updater) 2011-04-10 11:19	Yes, it seems to work now.

(0001324) Torr Samaho (administrator) 2011-04-10 12:26	Ok, so I can consider this to be resolved, right?

(0001401) unknownna (updater) 2011-04-20 23:22	Not yet. The spheres don't have the NOGRAVITY flag applied to them after a map reset if compat_nogravity_spheres is set to 1.

(0001448) Torr Samaho (administrator) 2011-04-24 21:37	Ok, this should also fix the problems after a map reset.

(0001451) unknownna (updater) 2011-04-24 22:12	It seems to work under normal conditions, but I somehow managed to desync the spheres. I don't know how to reproduce it yet.

(0001468) unknownna (updater) 2011-04-25 13:01	1. Start a survival server with nogravity_sphere_test_02.wad loaded. Make sure that compat_nogravity_spheres is set to 1. 2. Connect a client to the server. 3. Join the game. 4. During the warm-up countdown, "compat_nogravity_spheres 0" in the console. It doesn't always desync though. But in the worst case, none of the spheres will be affected by gravity when compat_nogravity_spheres is set to 0.

(0001483) Torr Samaho (administrator) 2011-04-26 23:49	Well, compat_nogravity_spheres is not supposed to be changed during the game (but there is no convenient way to prevent it from being toggled freely). It's just a crutch to keep the few existing maps that rely on it working. As long as it fulfills this purpose, I think we shouldn't put any more work into it.

(0001484) unknownna (updater) 2011-04-27 00:04	I agree, but I wonder if this is a symptom of a deeper problem.

(0001488) Torr Samaho (administrator) 2011-04-28 01:21	Depends on what you mean with desync: Does this mean that client and server don't agree on whether the sphere has NOGRAVITY?

(0001489) unknownna (updater) 2011-04-28 01:27	> Does this mean that client and server don't agree on whether the sphere has NOGRAVITY? No, it seems that the client and server are synced together.

(0001497) unknownna (updater) 2011-04-29 01:25 edited on: 2011-04-29 01:59	I found another issue: Spheres aren't affected by the compatflag after a map reset in (Team)Possession. Perhaps it's not a bug. Edit: It seems that if sv_itemrespawn/sv_respawnsuper is set to 0, items will not respawn during map resets in (Team)Possession.

(0001527) Torr Samaho (administrator) 2011-05-01 13:12 edited on: 2011-05-01 13:18	For some reason possession deliberately doesn't do a full map reset. It just respawns everything that would respawn based on the current dmflags. So I'd say this is not really a bug. Nevertheless, does anybody see a good reason why possession doesn't do a full map reset?