Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003542Doomseeker[All Projects] Bugpublic2018-10-07 08:372019-05-01 17:16
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritylowSeverityfeatureReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.3Fixed in Version1.3 
Summary0003542: No CXX_STANDARD defined in CMake build files
DescriptionWe could get more precise warnings from the C++ compiler, if it knew the standards version to use. There's a macro CMAKE_CXX_STANDARD for that, and CXX_STANDARD for build files.
Additional Informationhttps://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD.html [^]
https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html [^]

https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD_REQUIRED.html [^]
https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html [^]

As far as I'm aware, Doomseeker conforms to C++03 standard.
Attached Filespatch file icon 0001-CMake-Enforce-C++98-standard-_without-extensions_.patch [^] (961 bytes) 2018-12-10 14:08 [Show Content]

- Relationships
related to 0003599assignedPol M Allow Adding Maps En Masse To Playlist 
related to 0003514resolvedZalewa Drop support for compiling with Qt4 (in favor of Qt5+) 

-  Notes
User avatar (0020113)
WubTheCaptain (developer)
2018-10-13 18:45
edited on: 2018-10-13 18:48

Is it enough to set this once in /CMakeLists.txt, or do I need to also do the same for these?

  • src/core/CMakeLists.txt
  • src/plugins/CMakeLists.txt
  • src/plugins/*/CMakeLists.txt
  • src/wadseeker/CMakeLists.txt


User avatar (0020114)
Zalewa (developer)
2018-10-13 19:28

Off the top of my head, setting a variable in the top-level CMakeLists.txt should propagate its value to the whole solution. Unless there are some caveats I'm not aware of, setting the CMAKE_* variables to proper values should do the job.
User avatar (0020238)
WubTheCaptain (developer)
2018-12-10 14:08

Should be easy enough, patch attached. Needs testing?
User avatar (0020241)
Blzut3 (administrator)
2018-12-11 05:01

Turning off CMAKE_CXX_EXTENSIONS will break compiling on some platforms which use those extensions in their system headers (i.e. some Mac SDKs).

It would probably be a good idea to consider src/wadseeker/CMakeLists.txt a top level to preempt adding work to 0003280.
User avatar (0020445)
Pol M (developer)
2019-03-17 19:15

pr
User avatar (0020516)
Zalewa (developer)
2019-04-20 08:35

Pr merged through squash of the intermediate "pipelines" commit and then rebase on the current tip:

1.https://bitbucket.org/Doomseeker/doomseeker/commits/6bba593bf44b110a0680c422ad773d876551e922 [^]
2.https://bitbucket.org/Doomseeker/doomseeker/commits/052971a41c1ddc5f2e59ab4e6fb182d8cae9d8ef [^]
User avatar (0020601)
WubTheCaptain (developer)
2019-05-01 17:16

I hope we can close this as resolved.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-10-07 08:37 WubTheCaptain New Issue
2018-10-07 08:37 WubTheCaptain Status new => assigned
2018-10-07 08:37 WubTheCaptain Assigned To => WubTheCaptain
2018-10-07 08:38 WubTheCaptain Status assigned => acknowledged
2018-10-07 08:39 WubTheCaptain Description Updated View Revisions
2018-10-07 08:39 WubTheCaptain Additional Information Updated View Revisions
2018-10-07 09:17 WubTheCaptain Additional Information Updated View Revisions
2018-10-07 11:31 WubTheCaptain Priority normal => low
2018-10-13 18:28 WubTheCaptain Status acknowledged => assigned
2018-10-13 18:45 WubTheCaptain Note Added: 0020113
2018-10-13 18:45 WubTheCaptain Status assigned => feedback
2018-10-13 18:48 WubTheCaptain Note Edited: 0020113 View Revisions
2018-10-13 19:28 Zalewa Note Added: 0020114
2018-10-14 12:48 WubTheCaptain Status feedback => confirmed
2018-12-10 13:59 WubTheCaptain Status confirmed => assigned
2018-12-10 14:08 WubTheCaptain File Added: 0001-CMake-Enforce-C++98-standard-_without-extensions_.patch
2018-12-10 14:08 WubTheCaptain Note Added: 0020238
2018-12-10 14:08 WubTheCaptain Status assigned => needs review
2018-12-11 05:01 Blzut3 Note Added: 0020241
2018-12-11 13:49 WubTheCaptain Status needs review => confirmed
2019-03-17 19:01 Pol M Assigned To WubTheCaptain => Pol M
2019-03-17 19:01 Pol M Status confirmed => assigned
2019-03-17 19:15 Pol M Note Added: 0020445
2019-03-17 19:16 Pol M Status assigned => needs review
2019-03-17 19:18 Pol M Relationship added related to 0003599
2019-03-19 17:09 Pol M Relationship added related to 0003514
2019-04-20 08:35 Zalewa Note Added: 0020516
2019-04-20 08:35 Zalewa Status needs review => needs testing
2019-05-01 17:16 WubTheCaptain Note Added: 0020601
2019-05-01 17:16 WubTheCaptain Status needs testing => resolved
2019-05-01 17:16 WubTheCaptain Fixed in Version => 1.3
2019-05-01 17:16 WubTheCaptain Resolution open => fixed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker