MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003542Doomseeker[All Projects] Bugpublic2018-10-07 08:372019-07-30 10:13
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritylowSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.3Fixed in Version1.3 
Summary0003542: No CXX_STANDARD defined in CMake build files
DescriptionWe could get more precise warnings from the C++ compiler, if it knew the standards version to use. There's a macro CMAKE_CXX_STANDARD for that, and CXX_STANDARD for build files.
Steps To Reproduce
Additional Information'https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD.html [^]'
'https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html [^]'

'https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD_REQUIRED.html [^]'
'https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html [^]'

As far as I'm aware, Doomseeker conforms to C++03 standard.
TagsNo tags attached.
Relationships
related to 0003599closed Pol M Allow Adding Maps En Masse To Playlist 
related to 0003514closed Zalewa Drop support for compiling with Qt4 (in favor of Qt5+) 
Attached Filespatch 0001-CMake-Enforce-C++98-standard-_without-extensions_.patch (961) 2018-12-10 14:08
https://zandronum.com/tracker/file_download.php?file_id=2444&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-07 08:37WubTheCaptainNew Issue
2018-10-07 08:37WubTheCaptainStatusnew => assigned
2018-10-07 08:37WubTheCaptainAssigned To => WubTheCaptain
2018-10-07 08:38WubTheCaptainStatusassigned => acknowledged
2018-10-07 08:39WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=12164#r12164
2018-10-07 08:39WubTheCaptainAdditional Information Updatedbug_revision_view_page.php?rev_id=12166#r12166
2018-10-07 09:17WubTheCaptainAdditional Information Updatedbug_revision_view_page.php?rev_id=12167#r12167
2018-10-07 11:31WubTheCaptainPrioritynormal => low
2018-10-13 18:28WubTheCaptainStatusacknowledged => assigned
2018-10-13 18:45WubTheCaptainNote Added: 0020113
2018-10-13 18:45WubTheCaptainStatusassigned => feedback
2018-10-13 18:48WubTheCaptainNote Edited: 0020113bug_revision_view_page.php?bugnote_id=20113#r12261
2018-10-13 19:28ZalewaNote Added: 0020114
2018-10-14 12:48WubTheCaptainStatusfeedback => confirmed
2018-12-10 13:59WubTheCaptainStatusconfirmed => assigned
2018-12-10 14:08WubTheCaptainFile Added: 0001-CMake-Enforce-C++98-standard-_without-extensions_.patch
2018-12-10 14:08WubTheCaptainNote Added: 0020238
2018-12-10 14:08WubTheCaptainStatusassigned => needs review
2018-12-11 05:01Blzut3Note Added: 0020241
2018-12-11 13:49WubTheCaptainStatusneeds review => confirmed
2019-03-17 19:01Pol MAssigned ToWubTheCaptain => Pol M
2019-03-17 19:01Pol MStatusconfirmed => assigned
2019-03-17 19:15Pol MNote Added: 0020445
2019-03-17 19:16Pol MStatusassigned => needs review
2019-03-17 19:18Pol MRelationship addedrelated to 0003599
2019-03-19 17:09Pol MRelationship addedrelated to 0003514
2019-04-20 08:35ZalewaNote Added: 0020516
2019-04-20 08:35ZalewaStatusneeds review => needs testing
2019-05-01 17:16WubTheCaptainNote Added: 0020601
2019-05-01 17:16WubTheCaptainStatusneeds testing => resolved
2019-05-01 17:16WubTheCaptainFixed in Version => 1.3
2019-05-01 17:16WubTheCaptainResolutionopen => fixed
2019-07-30 10:13WubTheCaptainStatusresolved => closed

Notes
(0020113)
WubTheCaptain   
2018-10-13 18:45   
(edited on: 2018-10-13 18:48)
Is it enough to set this once in /CMakeLists.txt, or do I need to also do the same for these?

  • src/core/CMakeLists.txt
  • src/plugins/CMakeLists.txt
  • src/plugins/*/CMakeLists.txt
  • src/wadseeker/CMakeLists.txt
(0020114)
Zalewa   
2018-10-13 19:28   
Off the top of my head, setting a variable in the top-level CMakeLists.txt should propagate its value to the whole solution. Unless there are some caveats I'm not aware of, setting the CMAKE_* variables to proper values should do the job.
(0020238)
WubTheCaptain   
2018-12-10 14:08   
Should be easy enough, patch attached. Needs testing?
(0020241)
Blzut3   
2018-12-11 05:01   
Turning off CMAKE_CXX_EXTENSIONS will break compiling on some platforms which use those extensions in their system headers (i.e. some Mac SDKs).

It would probably be a good idea to consider src/wadseeker/CMakeLists.txt a top level to preempt adding work to 0003280.
(0020445)
Pol M   
2019-03-17 19:15   
pr
(0020516)
Zalewa   
2019-04-20 08:35   
Pr merged through squash of the intermediate "pipelines" commit and then rebase on the current tip:

1.'https://bitbucket.org/Doomseeker/doomseeker/commits/6bba593bf44b110a0680c422ad773d876551e922 [^]'
2.'https://bitbucket.org/Doomseeker/doomseeker/commits/052971a41c1ddc5f2e59ab4e6fb182d8cae9d8ef [^]'
(0020601)
WubTheCaptain   
2019-05-01 17:16   
I hope we can close this as resolved.