Anonymous | Login | Signup for a new account | 2025-06-14 14:43 UTC | ![]() |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003523 | Doomseeker | [All Projects] Suggestion | public | 2018-09-26 00:24 | 2018-10-27 22:54 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Pol M | ||||||||
Priority | high | Severity | feature | Reproducibility | N/A | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 1.1 | ||||||||
Target Version | 1.2 | Fixed in Version | 1.2 | ||||||
Summary | 0003523: Add support for textboxes in "about" dialogs of plugins | ||||||||
Description | We need to reproduce a BSD license for an engine plugin (Turok 2 Remaster), but Doomseeker's API doesn't support this yet in the ideal place (the plugin). | ||||||||
Additional Information | 0003511:Quote from Zalewa | ||||||||
Attached Files | |||||||||
![]() |
|
Pol M (developer) 2018-09-28 19:51 edited on: 2018-09-28 20:07 |
Ok! As stated, I've gone with option A, and it works as expected. I've made a commit in my personal repo: which you can find here. I won't make a pull request because it is technically unfinished work and the descriptions only have a simple text as a replacement right now. About the texts that should go in, I think that either you (as the team, not only Zalewa) tell me what to put in or I actually make the pull request and let that to the hands of someone else. Since this is out of the scope of this ticket, It will be discussed in 0003511 I've added a licence in the top of the "serverapi/textprovider.h" file. It is the same as the one of another file, but I've changed the "Copyright (C)" to my data: (// Copyright (C) 2018 "Pol Marcet Sardà" <polmarcetsarda@gmail.com>) I don't know if at the end I've broken the ABI. I tried not to, but it's the first time I even have to think about its existence. Anecdotical P.D: I had to debug for a few hours because I am stupid and put the "EP_AboutProvider" after "EP_Done". I know, I should have read the engineplugin.cpp in more detail, and for a few minutes, I was considering if I had forgotten how to even make if statements. That's a new record debugging stupid mistakes. |
Zalewa (developer) 2018-09-29 08:36 |
Review done at the provided commit link.Quote from Pol M Long, long time ago I was working on some project. I don't remember what it was right now, but I remember I already had lots of done on it and the program was working and I was happily working on further improvements. All of a sudden, the whole thing stopped compiling, throwing out hundreds of horrendous errors. None of the errors wre helpful in locating the problem. Nowadays in such situation it's a good idea to look at the diff of the code and try to see what you've changed. However, it happened back in the times when SVN was the king of version control systems and homebrewed developers barely knew of it, let alone knew how to actually use it beyond the "code backup" utility. I started cutting large portions of code furiously hoping to cut out the problem that caused all those errors in hope to narrow down its location. Eventually, I noticed that the problem is gone only after I remove the contents of the whole .cpp file. I couldn't figure out how is it possible that the whole file is suddenly broken, until I saw it. Right on the first line, on the first column, right before the header comment, before the two '//' characters, there was a letter 'k', sitting there. This one small letter caused the compiler to go nuts, spewing errors left and right. How it got there? Probably when I was switching between editor tabs, I mistakenly pressed this key on the keyboard. I don't remember how much time I spent on trying to find this, but I remember it tore me apart. |
Pol M (developer) 2018-09-29 09:02 |
Quote from Zalewa Since this is now reviewed, I'll now set this to "needs testing" and I'll change it to "resolved" once the parent ticket is done. Quote from Zalewa With keystrokes like those, who needs enemies 🤣 I feel you, more than once I've hit the "l" or "ñ" key after a ";" and made the compiler go crazy. Fortunately, this situation is a lot easier to narrow down, Since everything works okay until it reaches the line. |
Pol M (developer) 2018-09-29 13:25 |
address all mentioned. (except for the removal of the #include in engineplugin.h, which is necessary for QScopedPointer). For today I'm done, more tomorrow :) |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
![]() |
|||
Date Modified | Username | Field | Change |
2018-09-26 00:24 | WubTheCaptain | New Issue | |
2018-09-26 00:24 | WubTheCaptain | Relationship added | child of 0003511 |
2018-09-26 01:50 | WubTheCaptain | Status | new => acknowledged |
2018-09-26 05:54 | Pol M | Assigned To | => Pol M |
2018-09-26 05:54 | Pol M | Status | acknowledged => assigned |
2018-09-28 19:51 | Pol M | Note Added: 0019796 | |
2018-09-28 19:52 | Pol M | Status | assigned => needs review |
2018-09-28 20:07 | Pol M | Note Edited: 0019796 | View Revisions |
2018-09-29 08:36 | Zalewa | Note Added: 0019806 | |
2018-09-29 09:02 | Pol M | Note Added: 0019808 | |
2018-09-29 09:14 | Pol M | Status | needs review => needs testing |
2018-09-29 13:25 | Pol M | Note Added: 0019817 | |
2018-09-29 13:25 | Pol M | Status | needs testing => needs review |
2018-10-01 18:42 | Pol M | Status | needs review => needs testing |
2018-10-02 05:39 | WubTheCaptain | Status | needs testing => resolved |
2018-10-02 05:39 | WubTheCaptain | Resolution | open => fixed |
2018-10-02 05:39 | WubTheCaptain | Fixed in Version | => 1.2 |
2018-10-02 05:39 | WubTheCaptain | Target Version | => 1.2 |
2018-10-27 22:54 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2025 MantisBT Team |