0003445: SetMusicVolume() does not change the volume of music.

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003445

Zandronum

[All Projects] Bug

public

2018-08-04 14:32

2024-02-29 22:42

Reporter

eagle

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

confirmed

Resolution

backport later

Platform

Microsoft

Windows

OS Version

Server 2012 R2

Product Version

3.0

Target Version

Fixed in Version

Summary

0003445: SetMusicVolume() does not change the volume of music.

Description

if you run SetMusicVolume (0), the music plays without changing the volume.

Steps To Reproduce

if you run SetMusicVolume (0), the music plays without changing the volume.

Attached Files

acs_music.txt [^] (5,828 bytes) 2018-08-04 14:36 [Show Content] [Hide Content]

bool Is_Mon_Music_Playing = FALSE;
bool Is_Int_Music_Playing = FALSE;
bool Is_Weap_Music_Playing = FALSE;
bool Is_Player_Music_Playing = FALSE;
int Fired_Epic[LSD_MAX_CLIENT_COUNT];
int Music_priority = 0;
int MusicVolume = 1.0;

Script "StartPlayerMusic" (int mNum, int DemonType) //Legendary Player music start
{
	delay(5);
	str DemonTypeStr = "None";
	if(DemonType == 1)
	{
		DemonTypeStr = "Demon_LegendaryRevenant";
	}
	else if(DemonType == 2)
	{
		DemonTypeStr = "Demon_HellFireCyberdemon";
	}
	if(Is_Player_Music_Playing == FALSE)
	{
		Is_Player_Music_Playing = TRUE;
		while(MusicVolume > 0)
		{
			SetMusicVolume(MusicVolume);
			delay(1);
			MusicVolume -= 1;
		}
		while((Is_Player_Music_Playing == TRUE) && (CheckActorClass(0,DemonTypeStr) == true) && (GetActorProperty(0,APROP_Health) > 0))
		{
			MusicVolume = 1.0;
			ACS_NamedExecuteAlways("LSD_StartPlayerMusic",0,mNum,MusicVolume);
			delay(5);
		}
		SetMusic("*",0);
		MusicVolume = 1.0;
		SetMusicVolume(1.0);
		Is_Player_Music_Playing = FALSE;
	}
}

Script "StartMIntermissionMusic" (void) //monster music intermission
{
	Is_Int_Music_Playing = TRUE;
	while(MusicVolume > 0)
	{
		SetMusicVolume(MusicVolume);
		delay(1);
		MusicVolume -= 1;
	}
	MusicVolume = 1.0;
	ACS_NamedExecuteAlways("LSD_StartMIntermissionMusic",0,0,MusicVolume);
	delay(3150);
	Is_Int_Music_Playing = FALSE;
}

Script "StartMonsterMusic" (int mNum) //monster music start
{
	if((ClassifyActor(0) & ACTOR_ALIVE) && (GetUservariable(0,"user_music") == 0))
	{
		int priority = abs(GetActorProperty(0,APROP_SpawnHealth) + GetActorProperty(0,APROP_Health))+random(0,10);
		if((ClassifyActor(0) & ACTOR_ALIVE) && (Music_priority < priority) && (Is_Player_Music_Playing == FALSE) && (Is_Int_Music_Playing == FALSE))
		{
			SetUserVariable(0,"user_music",1);
			bool live = false;
			bool voldow = false;
			bool volex = false;
			Music_priority = priority;
			Is_Mon_Music_Playing = TRUE;
			Is_Weap_Music_Playing = FALSE;
			int counter;
			while((ClassifyActor(0) & ACTOR_ALIVE) && (GetUservariable(0,"user_music") == 1))
			{
				while((MusicVolume > 0) && (voldow == false))
				{
					SetMusicVolume(MusicVolume);
					delay(1);
					MusicVolume -= 0.015625;
					if(GetCVAR("lsd_debug") == true)PrintBold(s:"Music Volume: ", f:MusicVolume);
					if((Is_Int_Music_Playing == TRUE) || (Is_Player_Music_Playing == TRUE))
					{
						SetUserVariable(0,"user_music",0);
						Is_Mon_Music_Playing = FALSE;
						Music_priority = 0;
						live = true;
						volex = true;
					}
					else if(Music_priority > priority)
					{
						SetUserVariable(0,"user_music",0);
						live = true;
						volex = true;
					}
				}
				voldow = true;
				if(volex == false)
				{
					MusicVolume = 1.0;
					ACS_NamedExecuteAlways("LSD_StartMonsterMusic",0,mNum,MusicVolume);
					counter = 0;
					while(counter < 7)
					{
						delay(5);
						if((Is_Int_Music_Playing == TRUE) || (Is_Player_Music_Playing == TRUE))
						{
							SetUserVariable(0,"user_music",0);
							Is_Mon_Music_Playing = FALSE;
							Music_priority = 0;
							live = true;
						}
						else if(Music_priority > priority)
						{
							SetUserVariable(0,"user_music",0);
							live = true;
						}
						counter++;
					}
				}
			}
			if(live == false)
			{
				SetMusic("*",0);
				MusicVolume = 1.0;
				SetMusicVolume(1.0);
				Is_Mon_Music_Playing = FALSE;
				Music_priority = 0;
			}
		}
	}
}

Script "StartWeaponMusic" (int mNum) //weapon music start
{
	delay(1);
	if((Is_Weap_Music_Playing == FALSE) && (Is_Player_Music_Playing == FALSE) && (Is_Mon_Music_Playing == FALSE) && (Is_Int_Music_Playing == FALSE))
	{
		Fired_Epic[PlayerNumber()] = Fired_Epic[PlayerNumber()] + 1;
		if(Fired_Epic[PlayerNumber()] >= 5)
		{
			Is_Weap_Music_Playing = TRUE;
			MusicVolume = 1.0;
			ACS_NamedExecuteAlways("LSD_StartWeaponMusic",0,mNum,MusicVolume);
		}
	}
}

Script "StopWeaponMusic" (void) //weapon music stop
{
	if(Is_Weap_Music_Playing == TRUE)
	{
		SetMusic("*",0);
		MusicVolume = 1.0;
		SetMusicVolume(1.0);
		Fired_Epic[PlayerNumber()] = 0;
		Is_Weap_Music_Playing = FALSE;
	}
}

Script "StopMonsterMusic" (void) //monster music stop
{
	if((Is_Player_Music_Playing  == FALSE) && (Is_Mon_Music_Playing == TRUE)) 
	{
		SetMusic("*",0);
		MusicVolume = 1.0;
		SetMusicVolume(1.0);
		Is_Mon_Music_Playing = FALSE;
	}
}

Script "StopMIntermissionMusic" (void) //monster music intermission stop
{
	if(Is_Int_Music_Playing == TRUE)
	{
		SetMusic("*",0);
		MusicVolume = 1.0;
		SetMusicVolume(1.0);
		Is_Int_Music_Playing = FALSE;
	}
}

Script "LSD_StartMIntermissionMusic" (int mNum, int Volume) CLIENTSIDE
{
	if(GetUserCvar(ConsolePlayerNumber(),"lsd_legmusic") == 1)
	{
		SetMusic("LSDM_INT",0);
		SetMusicVolume(MusicVolume);
	}
	else
	{
		SetMusic("*",0);
		SetMusicVolume(1.0);
	}
}

Script "LSD_StartMonsterMusic" (int mNum, int Volume) CLIENTSIDE
{
	if(GetUserCvar(ConsolePlayerNumber(),"lsd_legmusic") == 1)
	{
		SetMusic(StrParam(s:"LSDM_",i:mNum),0);
		SetMusicVolume(MusicVolume);
	}
	else
	{
		SetMusic("*",0);
		SetMusicVolume(1.0);
	}
}

Script "LSD_StartWeaponMusic" (int mNum, int Volume) CLIENTSIDE
{
	if(GetUserCvar(ConsolePlayerNumber(),"lsd_legweapmusic") == 1)
	{
		SetMusic(StrParam(s:"LSDM_",i:mNum),0);
		SetMusicVolume(MusicVolume);
	}
	else
	{
		SetMusic("*",0);
		SetMusicVolume(1.0);
	}
}

Script "LSD_StartPlayerMusic" (int mNum, int Volume) CLIENTSIDE
{
	if(GetUserCvar(ConsolePlayerNumber(),"lsd_legplayermusic") == 1)
	{
		SetMusic(StrParam(s:"LSDM_",i:mNum),0);
		SetMusicVolume(MusicVolume);
	}
	else
	{
		SetMusic("*",0);
		SetMusicVolume(1.0);
	}
}

ZandronumTest_SetMusicVolume.pk3 [^] (728 bytes) 2018-08-22 19:32

Relationships

Notes
(0019313) eagle (reporter) 2018-08-07 15:11	In GZDoom version g3.2.1, this script works correctly.

(0019383) jdagenet (reporter) 2018-08-22 19:34	I can confirm this, I attached an example file. Pukename "SC_SETMUSICVOLUMETEST". Works in GZDoom but not Zandronum (offline nor online).

(0019386) Kaminsky (developer) 2018-08-22 21:56	Zandronum 3.0 is based off GZDoom 1.8.6 which doesn't support SetMusicVolume() either. It wasn't added until 2.4.0. Here's a link to the commit which adds the function:'https://zdoom.org/Changelog/a1e8d83/files [^]'

(0023135) Ru5tK1ng (updater) 2024-02-29 22:42	Might have to wait til 4.0. Setting to backport later in case this gets worked on.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	eagle jdagenet hyades
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2018-08-04 14:32	eagle	New Issue
2018-08-04 14:36	eagle	File Added: acs_music.txt
2018-08-07 15:11	eagle	Note Added: 0019313
2018-08-22 19:32	jdagenet	File Added: ZandronumTest_SetMusicVolume.pk3
2018-08-22 19:34	jdagenet	Note Added: 0019383
2018-08-22 21:56	Kaminsky	Note Added: 0019386
2024-02-29 22:42	Ru5tK1ng	Note Added: 0023135
2024-02-29 22:42	Ru5tK1ng	Status	new => confirmed
2024-02-29 22:42	Ru5tK1ng	Resolution	open => backport later

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.