0003360: Assume http if no protocol is given

Notes
(0018984) WubTheCaptain (reporter) 2018-01-07 22:46 edited on: 2018-01-07 22:47	Without any information available to reproduce this, I can only assume what's going on. Under "normal" circumstances, this shouldn't happen. There is (probably) a misconfigured server somewhere with a broken URI (missing scheme) in the server descriptor causing this. (Regardless, the WAD list built-in to Doomseeker configuration should have the given static.allfearthesentinel.net URI.) There's no explanation why the default assumption should be HTTP, or why specifically to make any assumption at all. (Web browsers, curl, etc. typically assume HTTP.) RFC 3986 is 61 pages long; I'm not going to read through all of it, but I also cannot find anything that would say the scheme to sensibly default to HTTP or a group of protocols (schemes) to attempt. (Hint: Port numbers may define the default scheme, if defined. Page 22.) In the end, I also don't think this is a problem Doomseeker would have to resolve. The behavior exists across all Qt5 programs (QNetworkReply). It'd be best to file such bug against Qt (upstream) or link a relevant ticket of resolution here. It also does not seem this suggestion to be an urgent matter to resolve, so I've adjusted the ticket priority and severity accordingly. I'd be willing to decline this suggestion as out of scope.

(0018985) WubTheCaptain (reporter) 2018-01-07 22:55	aka "working as intended" because no port number or scheme was provided.

(0018986) WubTheCaptain (reporter) 2018-01-07 23:19	I think the answer also lies within section 4.5 (suffix reference) of RFC 3986. An URI consisting only of an authority (static.allfearthesentinel.net) and path (/wads/) is "primarily intended for human interpretation rather than for machines". Furthermore, this practice "should be avoided whenever possible and should never be used in situations where long-term references are expected." Yadda yadda, insert more about heuristics and security issues. URIs are meant to be unambiguous references. The one in the OP (missing a scheme and/or port number) is an ambiguous reference. I'm inclined to strongly reject this suggestion.

(0018987) Dark-Assassin (administrator) 2018-01-08 12:01	I understand that this is an issue (or not) beyond WadSeeker itself. I purposely disabled all the WAD sites to test to see if it actually worked but saw it didn't. However for some reason, if I make it'http://static.allfearthesentinel.net/wads/ [^]' by default on the site, it'll just be http: and treat the rest as a comment. If I escape the // it'll end up being http:\/\/static.allfearthesentinel.net/wads/ Note that sv_hostname is set from dynamically generated exec files rather than a command line parameter. But that is an issue I should figure out how to fix myself without forcing it to be a command line parameter. Feel free to close the issue.

(0018988) Empyre (reporter) 2018-01-08 15:49	I am probably displaying my ignorance, but I will say this anyway just in case it helps. Maybe if you put the whole address in quotes the // won't make the rest of the line a comment.

(0018989) WubTheCaptain (reporter) 2018-01-08 16:28	Right. A little bit confusing what was just said, but I think I understand the underlying issue. I checked now: All TSPG servers from Zandronum master server currently advertise an URI without a scheme. The correct place to file a bug about this is The Sentinel's bug tracker. The underlying suggestion should be filed against Qt bug tracker, though I concern myself there is no need to change anything and the current behavior is correct. Please re-open (Zalewa, Blzut3) if you have more concerns.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	WubTheCaptain

Issue History
Date Modified	Username	Field	Change
2018-01-07 22:13	Dark-Assassin	New Issue
2018-01-07 22:28	WubTheCaptain	Priority	high => normal
2018-01-07 22:28	WubTheCaptain	Severity	block => tweak
2018-01-07 22:46	WubTheCaptain	Note Added: 0018984
2018-01-07 22:47	WubTheCaptain	Note Edited: 0018984	View Revisions
2018-01-07 22:55	WubTheCaptain	Note Added: 0018985
2018-01-07 23:00	WubTheCaptain	Status	new => feedback
2018-01-07 23:19	WubTheCaptain	Note Added: 0018986
2018-01-08 12:01	Dark-Assassin	Note Added: 0018987
2018-01-08 12:01	Dark-Assassin	Status	feedback => new
2018-01-08 12:01	Dark-Assassin	Assigned To	=> Dark-Assassin
2018-01-08 12:01	Dark-Assassin	Status	new => feedback
2018-01-08 15:49	Empyre	Note Added: 0018988
2018-01-08 16:28	WubTheCaptain	Note Added: 0018989
2018-01-08 16:28	WubTheCaptain	Status	feedback => closed
2018-01-08 16:28	WubTheCaptain	Resolution	open => out of scope

Relationships