Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003251Doomseeker[All Projects] Bugpublic2017-09-01 19:002018-10-27 22:55
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynoneSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64 (really cross-platform)OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003251: Duplicated and identical Huffman coding in plugin source tree (Skulltag & Zandronum)
DescriptionSkulltag and Zandronum engine plugins both have a directory with identical source code.
Steps To Reproduce
ยง diff -s src/plugins/skulltag/huffman/ src/plugins/zandronum/huffman
Files src/plugins/skulltag/huffman/bitreader.cpp and src/plugins/zandronum/huffman/bitreader.cpp are 
identical
Files src/plugins/skulltag/huffman/bitreader.h and src/plugins/zandronum/huffman/bitreader.h are identical

Files src/plugins/skulltag/huffman/bitwriter.cpp and src/plugins/zandronum/huffman/bitwriter.cpp are 
identical
Files src/plugins/skulltag/huffman/bitwriter.h and src/plugins/zandronum/huffman/bitwriter.h are identical

Files src/plugins/skulltag/huffman/codec.h and src/plugins/zandronum/huffman/codec.h are identical
Files src/plugins/skulltag/huffman/huffcodec.cpp and src/plugins/zandronum/huffman/huffcodec.cpp are 
identical
Files src/plugins/skulltag/huffman/huffcodec.h and src/plugins/zandronum/huffman/huffcodec.h are identical

Files src/plugins/skulltag/huffman/huffman.cpp and src/plugins/zandronum/huffman/huffman.cpp are identical

Files src/plugins/skulltag/huffman/huffman.h and src/plugins/zandronum/huffman/huffman.h are identical
Additional InformationSkulltag is, of course, unsupported. Should be refactored or cleaned up if possible. (I mean, could get rid of it or distribute it seperately. It's almost dead code. Who's going to maintain it? And Zandronum is based on Skulltag, how fun.)
Attached Files

- Relationships

-  Notes
User avatar (0018231)
Blzut3 (administrator)
2017-09-04 20:16

 I think at this point it's fair to say that Zandronum is going to be the only fork from Skulltag so that plugin is worthless to keep around in the source distribution.

Also deleted ZDaemon since it's unlikely that the plugin would be of any use even if someone wanted to play the cat and mouse game.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-09-01 19:00 WubTheCaptain New Issue
2017-09-04 20:12 Blzut3 Assigned To => Blzut3
2017-09-04 20:12 Blzut3 Status new => assigned
2017-09-04 20:16 Blzut3 Note Added: 0018231
2017-09-04 20:16 Blzut3 Status assigned => resolved
2017-09-04 20:16 Blzut3 Fixed in Version => 1.2
2017-09-04 20:16 Blzut3 Resolution open => fixed
2017-09-04 20:16 Blzut3 Target Version => 1.2
2018-10-27 22:55 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker