MantisBT - Doomseeker
View Issue Details
0003251Doomseeker[All Projects] Bugpublic2017-09-01 19:002018-10-27 22:55
WubTheCaptain 
Blzut3 
nonetrivialalways
closedfixed 
x86_64 (really cross-platform)Debian GNU/Linuxbuster/sid
1.1 
1.21.2 
0003251: Duplicated and identical Huffman coding in plugin source tree (Skulltag & Zandronum)
Skulltag and Zandronum engine plugins both have a directory with identical source code.
ยง diff -s src/plugins/skulltag/huffman/ src/plugins/zandronum/huffman
Files src/plugins/skulltag/huffman/bitreader.cpp and src/plugins/zandronum/huffman/bitreader.cpp are 
identical
Files src/plugins/skulltag/huffman/bitreader.h and src/plugins/zandronum/huffman/bitreader.h are identical

Files src/plugins/skulltag/huffman/bitwriter.cpp and src/plugins/zandronum/huffman/bitwriter.cpp are 
identical
Files src/plugins/skulltag/huffman/bitwriter.h and src/plugins/zandronum/huffman/bitwriter.h are identical

Files src/plugins/skulltag/huffman/codec.h and src/plugins/zandronum/huffman/codec.h are identical
Files src/plugins/skulltag/huffman/huffcodec.cpp and src/plugins/zandronum/huffman/huffcodec.cpp are 
identical
Files src/plugins/skulltag/huffman/huffcodec.h and src/plugins/zandronum/huffman/huffcodec.h are identical

Files src/plugins/skulltag/huffman/huffman.cpp and src/plugins/zandronum/huffman/huffman.cpp are identical

Files src/plugins/skulltag/huffman/huffman.h and src/plugins/zandronum/huffman/huffman.h are identical
Skulltag is, of course, unsupported. Should be refactored or cleaned up if possible. (I mean, could get rid of it or distribute it seperately. It's almost dead code. Who's going to maintain it? And Zandronum is based on Skulltag, how fun.)
No tags attached.
Issue History
2017-09-01 19:00WubTheCaptainNew Issue
2017-09-04 20:12Blzut3Assigned To => Blzut3
2017-09-04 20:12Blzut3Statusnew => assigned
2017-09-04 20:16Blzut3Note Added: 0018231
2017-09-04 20:16Blzut3Statusassigned => resolved
2017-09-04 20:16Blzut3Fixed in Version => 1.2
2017-09-04 20:16Blzut3Resolutionopen => fixed
2017-09-04 20:16Blzut3Target Version => 1.2
2018-10-27 22:55WubTheCaptainStatusresolved => closed

Notes
(0018231)
Blzut3   
2017-09-04 20:16   
I think at this point it's fair to say that Zandronum is going to be the only fork from Skulltag so that plugin is worthless to keep around in the source distribution.

Also deleted ZDaemon since it's unlikely that the plugin would be of any use even if someone wanted to play the cat and mouse game.