Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003201Zandronum[All Projects] Bugpublic2017-07-27 17:162024-03-11 08:20
ReporterKorshun 
Assigned ToKaminsky 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.1Fixed in Version3.1 
Summary0003201: A_StopSound doesn't work in CustomInventory Pickup state online
DescriptionA_StopSound works fine in multilpayer on weapons, but not in CustomInventory Pickup state.
Steps To ReproduceRun the wad and puke 1 to get an item that calls A_PlaySound with looping chainsaw sound.

puke 2 to get an item that calls A_StopSound, which only works in singleplayer.
Additional InformationThis bug is present in both 2.1.2 and 3.0.
Attached Files? file icon CustomInventory_StopSound.wad [^] (742 bytes) 2017-07-27 17:16

- Relationships

-  Notes
User avatar (0018103)
Dusk (developer)
2017-07-27 20:13

 A_StopSound doesn't have any netcode at all.
User avatar (0018104)
Korshun (reporter)
2017-07-27 20:31

 Yes, it sends no servercommands. But it works on weapons!
User avatar (0018112)
HexaDoken (reporter)
2017-07-28 10:13

 Yo.

Editing the example wad really quickly to have the StopSound item's Pickup state to end with Stop instead of Fail makes it properly work online.
User avatar (0018113)
Fused (reporter)
2017-07-28 10:57
Quote

Editing the example wad really quickly to have the StopSound item's Pickup state to end with Stop instead of Fail makes it properly work online.


Can confirm this fixed the issue on my end.
User avatar (0018138)
Dusk (developer)
2017-08-03 16:56

 I've fixed this in a new fork, will put for review when 3.0 is released.
User avatar (0020026)
Ivan (reporter)
2018-10-08 20:49

 The version with "Fail" in the item states doesn't work with 3.1 build here (https://zandronum.com/forum/viewtopic.php?f=55&t=9340) but the modification to replace the "Fail" with "Stop" does work in 3.1.
User avatar (0021687)
Kaminsky (developer)
2021-08-08 11:16

 Since clients never execute a CustomInventory item's Pickup state if it failed, I had to modify A_StopSound and give it a special case where the server sends a command to the client to stop playing a sound when called from a CustomInventory item. Other than that, the function still doesn't use netcode.

So now, it should always work properly in a CustomInventory's states online in 3.1.
User avatar (0023353)
unknownna (updater)
2024-03-11 08:20

 The example wad works fine in 3.1 compared to before. Good work.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Korshun Fused
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-07-27 17:16 Korshun New Issue
2017-07-27 17:16 Korshun File Added: CustomInventory_StopSound.wad
2017-07-27 20:12 Dusk Assigned To => Dusk
2017-07-27 20:12 Dusk Status new => confirmed
2017-07-27 20:13 Dusk Note Added: 0018103
2017-07-27 20:13 Dusk Target Version => 3.1
2017-07-27 20:31 Korshun Note Added: 0018104
2017-07-28 10:13 HexaDoken Note Added: 0018112
2017-07-28 10:57 Fused Note Added: 0018113
2017-08-03 16:56 Dusk Status confirmed => assigned
2017-08-03 16:56 Dusk Note Added: 0018138
2017-08-03 18:27 Fused Note Added: 0018139
2017-08-03 18:33 Fused Note Edited: 0018139 View Revisions
2017-08-04 20:06 Fused Note Deleted: 0018139
2018-10-08 20:49 Ivan Note Added: 0020026
2019-06-04 21:54 Dusk Status assigned => new
2021-08-08 11:16 Kaminsky Note Added: 0021687
2021-08-08 11:16 Kaminsky Status new => needs testing
2021-08-08 11:17 Kaminsky Summary A_StopSound doesn't work in CustomInventory Picktup state online => A_StopSound doesn't work in CustomInventory Pickup state online
2024-03-11 08:20 unknownna Note Added: 0023353
2024-03-11 08:20 unknownna Assigned To Dusk => Kaminsky
2024-03-11 08:20 unknownna Status needs testing => resolved
2024-03-11 08:20 unknownna Resolution open => fixed
2024-03-11 08:20 unknownna Fixed in Version => 3.1




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker