MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003201Zandronum[All Projects] Bugpublic2017-07-27 17:162024-03-11 08:20
ReporterKorshun 
Assigned ToKaminsky 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.1Fixed in Version3.1 
Summary0003201: A_StopSound doesn't work in CustomInventory Pickup state online
DescriptionA_StopSound works fine in multilpayer on weapons, but not in CustomInventory Pickup state.
Steps To ReproduceRun the wad and puke 1 to get an item that calls A_PlaySound with looping chainsaw sound.

puke 2 to get an item that calls A_StopSound, which only works in singleplayer.
Additional InformationThis bug is present in both 2.1.2 and 3.0.
TagsNo tags attached.
Relationships
Attached Files? CustomInventory_StopSound.wad (742) 2017-07-27 17:16
https://zandronum.com/tracker/file_download.php?file_id=2156&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-27 17:16KorshunNew Issue
2017-07-27 17:16KorshunFile Added: CustomInventory_StopSound.wad
2017-07-27 20:12DuskAssigned To => Dusk
2017-07-27 20:12DuskStatusnew => confirmed
2017-07-27 20:13DuskNote Added: 0018103
2017-07-27 20:13DuskTarget Version => 3.1
2017-07-27 20:31KorshunNote Added: 0018104
2017-07-28 10:13HexaDokenNote Added: 0018112
2017-07-28 10:57FusedNote Added: 0018113
2017-08-03 16:56DuskStatusconfirmed => assigned
2017-08-03 16:56DuskNote Added: 0018138
2017-08-03 18:27FusedNote Added: 0018139
2017-08-03 18:33FusedNote Edited: 0018139bug_revision_view_page.php?rev_id=10850
2017-08-04 20:06FusedNote Deleted: 0018139
2018-10-08 20:49IvanNote Added: 0020026
2019-06-04 21:54DuskStatusassigned => new
2021-08-08 11:16KaminskyNote Added: 0021687
2021-08-08 11:16KaminskyStatusnew => needs testing
2021-08-08 11:17KaminskySummaryA_StopSound doesn't work in CustomInventory Picktup state online => A_StopSound doesn't work in CustomInventory Pickup state online
2024-03-11 08:20unknownnaNote Added: 0023353
2024-03-11 08:20unknownnaAssigned ToDusk => Kaminsky
2024-03-11 08:20unknownnaStatusneeds testing => resolved
2024-03-11 08:20unknownnaResolutionopen => fixed
2024-03-11 08:20unknownnaFixed in Version => 3.1

Notes
(0018103)
Dusk   
2017-07-27 20:13   
A_StopSound doesn't have any netcode at all.
(0018104)
Korshun   
2017-07-27 20:31   
Yes, it sends no servercommands. But it works on weapons!
(0018112)
HexaDoken   
2017-07-28 10:13   
Yo.

Editing the example wad really quickly to have the StopSound item's Pickup state to end with Stop instead of Fail makes it properly work online.
(0018113)
Fused   
2017-07-28 10:57   
Quote

Editing the example wad really quickly to have the StopSound item's Pickup state to end with Stop instead of Fail makes it properly work online.


Can confirm this fixed the issue on my end.
(0018138)
Dusk   
2017-08-03 16:56   
I've fixed this in a new fork, will put for review when 3.0 is released.
(0020026)
Ivan   
2018-10-08 20:49   
The version with "Fail" in the item states doesn't work with 3.1 build here (https://zandronum.com/forum/viewtopic.php?f=55&t=9340) but the modification to replace the "Fail" with "Stop" does work in 3.1.
(0021687)
Kaminsky   
2021-08-08 11:16   
Since clients never execute a CustomInventory item's Pickup state if it failed, I had to modify A_StopSound and give it a special case where the server sends a command to the client to stop playing a sound when called from a CustomInventory item. Other than that, the function still doesn't use netcode.

So now, it should always work properly in a CustomInventory's states online in 3.1.
(0023353)
unknownna   
2024-03-11 08:20   
The example wad works fine in 3.1 compared to before. Good work.