0003009: ACS DropItem does not work on CTF Flags.

(0016831)
Unknown (reporter)
2017-02-10 10:45

Also TakeInventory and ConsoleCommand.

(0016853)
Torr Samaho (administrator)
2017-02-12 21:04

Can you elaborate? What happens and what do you think should happen instead? Also can you post a minimal example wad?

(0016863)
Unknown (reporter)
2017-02-14 13:10
edited on: 2017-02-14 16:15

I Was trying to recreate some CTF Mode Mechanics, In which Flag carrier is supposed to drop flag on hurt, However apparently flags cannot be taken from flag carrier inventory manually via ACS, Example .pk3 uploaded, try it with any CTF Map.

EDIT : Forgot to add #library, Please do it before you load the .pk3, ACS Source is included.

(0016875)
Torr Samaho (administrator)
2017-02-18 16:02

Quote from "Torr Samaho"
Can you elaborate? What happens and what do you think should happen instead?

You did not answer this. I ran I quick test with your example wad and it seems that a new flag is dropped when the carrier is hurt, but the carrier still keeps the flag it was carrying. Is this what you observe?

(0016876)
Unknown (reporter)
2017-02-18 19:10

Yea, I don't want to keep it on his inventory :/.

(0016879)
Torr Samaho (administrator)
2017-02-19 18:04

I checked the source. As far as I can tell, the ZDoom ACS function DropItem is not supposed to remove the item from the inventory of the activator, it will just make the activator toss an instance of the item, no matter if the actor has that item in its inventory at all. So it sounds as if DropItem is doing what ZDoom intends it to do.

You said that TakeInventory doesn't work. Can you elaborate? Do you mean it simply doesn't remove the flag from the inventory or what is happening?

(0016880)
Unknown (reporter)
2017-02-19 19:25
edited on: 2017-02-19 19:32

Yes It doesn't remove the flag, It doesn't work on flags for some reason, What I mean is there's no way to remove flag from carrier inventory unless he's dead, seems like a bug or a missing feature to me.

(0016881)
Torr Samaho (administrator)
2017-02-19 20:12

I did a quick test and TakeInventory does work just fine on flags for me. It removes the flag from the inventory. Of course, the flag is completely gone then. You'll need to spawn a new flag yourself somewhere, if you removed one from the game with TakeInventory. Not that a player will immediately pick up the flag in case you spawn it with DropItem from his position.

(0016883)
Unknown (reporter)
2017-02-19 20:44
edited on: 2017-02-19 20:57

Weird, TakeInventory doesn't work on Pain States for me, I'm also using the latest zandronum, and I'm using that pk3 you attatched, well I added the TakeInventory to the script and it still didn't work, neither against bots nor against myself (joined my server twice) and I'm running just Doom2 with that pk3, Is something wrong ?

EDIT : Oooh, the flag was being picked up immediately after it's dropped, dumb me, feel free to close this, so sorry about the inconvinience.

(0016887)
Torr Samaho (administrator)
2017-02-19 21:09

No problem. I'll close this then.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-02-10 10:44	Unknown	New Issue
2017-02-10 10:45	Unknown	Note Added: 0016831
2017-02-12 21:04	Torr Samaho	Note Added: 0016853
2017-02-12 21:05	Torr Samaho	Status	new => feedback
2017-02-14 13:10	Unknown	File Added: DropFlag_OnHurt.pk3
2017-02-14 13:10	Unknown	Note Added: 0016863
2017-02-14 13:10	Unknown	Status	feedback => new
2017-02-14 13:11	Unknown	Note Edited: 0016863	View Revisions
2017-02-14 16:15	Unknown	Note Edited: 0016863	View Revisions
2017-02-18 16:02	Torr Samaho	Note Added: 0016875
2017-02-18 19:10	Unknown	Note Added: 0016876
2017-02-19 17:53	Torr Samaho	File Added: DropFlag_OnHurt2.pk3
2017-02-19 18:04	Torr Samaho	Note Added: 0016879
2017-02-19 19:25	Unknown	Note Added: 0016880
2017-02-19 19:32	Unknown	Note Edited: 0016880	View Revisions
2017-02-19 20:12	Torr Samaho	Note Added: 0016881
2017-02-19 20:44	Unknown	Note Added: 0016883
2017-02-19 20:45	Unknown	Note Edited: 0016883	View Revisions
2017-02-19 20:46	Unknown	File Added: DropFlag_OnHurt3_PlusTakeInventory.pk3
2017-02-19 20:57	Unknown	Note Edited: 0016883	View Revisions
2017-02-19 21:09	Torr Samaho	Note Added: 0016887
2017-02-19 21:11	Torr Samaho	Status	new => closed
2017-02-19 21:11	Torr Samaho	Resolution	open => no change required

Notes
(0016831) Unknown (reporter) 2017-02-10 10:45	Also TakeInventory and ConsoleCommand.

(0016853) Torr Samaho (administrator) 2017-02-12 21:04	Can you elaborate? What happens and what do you think should happen instead? Also can you post a minimal example wad?

(0016863) Unknown (reporter) 2017-02-14 13:10 edited on: 2017-02-14 16:15	I Was trying to recreate some CTF Mode Mechanics, In which Flag carrier is supposed to drop flag on hurt, However apparently flags cannot be taken from flag carrier inventory manually via ACS, Example .pk3 uploaded, try it with any CTF Map. EDIT : Forgot to add #library, Please do it before you load the .pk3, ACS Source is included.

(0016875) Torr Samaho (administrator) 2017-02-18 16:02	Quote from "Torr Samaho" Can you elaborate? What happens and what do you think should happen instead? You did not answer this. I ran I quick test with your example wad and it seems that a new flag is dropped when the carrier is hurt, but the carrier still keeps the flag it was carrying. Is this what you observe?

(0016876) Unknown (reporter) 2017-02-18 19:10	Yea, I don't want to keep it on his inventory :/.

(0016879) Torr Samaho (administrator) 2017-02-19 18:04	I checked the source. As far as I can tell, the ZDoom ACS function DropItem is not supposed to remove the item from the inventory of the activator, it will just make the activator toss an instance of the item, no matter if the actor has that item in its inventory at all. So it sounds as if DropItem is doing what ZDoom intends it to do. You said that TakeInventory doesn't work. Can you elaborate? Do you mean it simply doesn't remove the flag from the inventory or what is happening?

(0016880) Unknown (reporter) 2017-02-19 19:25 edited on: 2017-02-19 19:32	Yes It doesn't remove the flag, It doesn't work on flags for some reason, What I mean is there's no way to remove flag from carrier inventory unless he's dead, seems like a bug or a missing feature to me.

(0016881) Torr Samaho (administrator) 2017-02-19 20:12	I did a quick test and TakeInventory does work just fine on flags for me. It removes the flag from the inventory. Of course, the flag is completely gone then. You'll need to spawn a new flag yourself somewhere, if you removed one from the game with TakeInventory. Not that a player will immediately pick up the flag in case you spawn it with DropItem from his position.

(0016883) Unknown (reporter) 2017-02-19 20:44 edited on: 2017-02-19 20:57	Weird, TakeInventory doesn't work on Pain States for me, I'm also using the latest zandronum, and I'm using that pk3 you attatched, well I added the TakeInventory to the script and it still didn't work, neither against bots nor against myself (joined my server twice) and I'm running just Doom2 with that pk3, Is something wrong ? EDIT : Oooh, the flag was being picked up immediately after it's dropped, dumb me, feel free to close this, so sorry about the inconvinience.

(0016887) Torr Samaho (administrator) 2017-02-19 21:09	No problem. I'll close this then.

Relationships