0002986: Online, if a morph powerup is taken away when there is no ammo, server crashes.

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002986

Zandronum

[All Projects] Bug

public

2017-01-17 16:53

2018-09-30 21:49

Reporter

HexaDoken

Assigned To

Edward-san

Priority

high

Severity

crash

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

2.1

Target Version

3.0

Fixed in Version

3.0

Summary

0002986: Online, if a morph powerup is taken away when there is no ammo, server crashes.

Description

Pretty much that. The server crashes if a morph powerup is taken away and the morph weapon does not have enough ammo to fire. This only happens in online multiplayer, in singleplayer the player unmorphs normally.

Please find an example wad attached.

The morph weapon will go to Deselect state if left in your hands for long enough, where it will take the morph powerup away. This will not crash the game if you have enough ammo for a shot. However, if you fire the weapon twice immediately after morphing, it won't have enough ammo on the second shot, will go to Deselect, take the morph away, and promptly crash.

Incidentally, if you remove A_TakeInventory from the Deselect state, the player upon running out of ammo will put the weapon away and merrily pull whatever weapon they have from the default class. I honestly have no idea whether it's a bug or feature or what.

Steps To Reproduce

1) Host a server with wad attached. Join.
2) summon TestMorphSphere
3) Pick it up
4) Immediately start firing the weapon
5) As soon as you run out of ammo, the server will crash,

Attached Files

testmorph.wad [^] (1,706 bytes) 2017-01-17 16:53

Relationships

Notes
(0016650) Edward-san (developer) 2017-01-17 21:51	It happens also in 2.1.

(0016651) Edward-san (developer) 2017-01-17 23:06	'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/195/fixed-the-server-could-crash-if-a-morph/diff [^]'

(0016675) Torr Samaho (administrator) 2017-01-24 06:59	Patch added.

(0016805) Ru5tK1ng (updater) 2017-02-07 00:42	Tested the latest build and I wasn't able to crash the server following the steps provided.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-01-17 16:53	HexaDoken	New Issue
2017-01-17 16:53	HexaDoken	File Added: testmorph.wad
2017-01-17 21:51	Edward-san	Note Added: 0016650
2017-01-17 21:51	Edward-san	Product Version	3.0-beta => 2.1
2017-01-17 23:06	Edward-san	Note Added: 0016651
2017-01-17 23:06	Edward-san	Assigned To	=> Edward-san
2017-01-17 23:06	Edward-san	Status	new => needs review
2017-01-24 06:59	Torr Samaho	Note Added: 0016675
2017-01-24 06:59	Torr Samaho	Status	needs review => needs testing
2017-01-30 04:24	Ru5tK1ng	Target Version	=> 3.0
2017-02-07 00:42	Ru5tK1ng	Note Added: 0016805
2017-02-07 00:42	Ru5tK1ng	Status	needs testing => resolved
2017-02-07 00:42	Ru5tK1ng	Resolution	open => fixed
2017-02-07 00:42	Ru5tK1ng	Fixed in Version	=> 3.0
2018-09-30 21:49	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.