MantisBT - Zandronum
View Issue Details
0002986Zandronum[All Projects] Bugpublic2017-01-17 16:532018-09-30 21:49
HexaDoken 
Edward-san 
highcrashalways
closedfixed 
MicrosoftWindowsXP/Vista/7
2.1 
3.03.0 
0002986: Online, if a morph powerup is taken away when there is no ammo, server crashes.
Pretty much that. The server crashes if a morph powerup is taken away and the morph weapon does not have enough ammo to fire. This only happens in online multiplayer, in singleplayer the player unmorphs normally.

Please find an example wad attached.

The morph weapon will go to Deselect state if left in your hands for long enough, where it will take the morph powerup away. This will not crash the game if you have enough ammo for a shot. However, if you fire the weapon twice immediately after morphing, it won't have enough ammo on the second shot, will go to Deselect, take the morph away, and promptly crash.


Incidentally, if you remove A_TakeInventory from the Deselect state, the player upon running out of ammo will put the weapon away and merrily pull whatever weapon they have from the default class. I honestly have no idea whether it's a bug or feature or what.
1) Host a server with wad attached. Join.
2) summon TestMorphSphere
3) Pick it up
4) Immediately start firing the weapon
5) As soon as you run out of ammo, the server will crash,
No tags attached.
? testmorph.wad (1,706) 2017-01-17 16:53
/tracker/file_download.php?file_id=2011&type=bug
Issue History
2017-01-17 16:53HexaDokenNew Issue
2017-01-17 16:53HexaDokenFile Added: testmorph.wad
2017-01-17 21:51Edward-sanNote Added: 0016650
2017-01-17 21:51Edward-sanProduct Version3.0-beta => 2.1
2017-01-17 23:06Edward-sanNote Added: 0016651
2017-01-17 23:06Edward-sanAssigned To => Edward-san
2017-01-17 23:06Edward-sanStatusnew => needs review
2017-01-24 06:59Torr SamahoNote Added: 0016675
2017-01-24 06:59Torr SamahoStatusneeds review => needs testing
2017-01-30 04:24Ru5tK1ngTarget Version => 3.0
2017-02-07 00:42Ru5tK1ngNote Added: 0016805
2017-02-07 00:42Ru5tK1ngStatusneeds testing => resolved
2017-02-07 00:42Ru5tK1ngResolutionopen => fixed
2017-02-07 00:42Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:49Blzut3Statusresolved => closed

Notes
(0016650)
Edward-san   
2017-01-17 21:51   
It happens also in 2.1.
(0016651)
Edward-san   
2017-01-17 23:06   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/195/fixed-the-server-could-crash-if-a-morph/diff [^]'
(0016675)
Torr Samaho   
2017-01-24 06:59   
Patch added.
(0016805)
Ru5tK1ng   
2017-02-07 00:42   
Tested the latest build and I wasn't able to crash the server following the steps provided.