Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002877Zandronum[All Projects] Bugpublic2016-10-10 01:382018-09-30 21:53
Reporterunknownna 
Assigned ToTorr Samaho 
PriorityimmediateSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002877: Duel queue broken in 3.0
DescriptionIf one of the players in-game disconnect, the next player in line is not put into the game. In addition to this, the line numbers get messed up, with one player displayed as being in the queue while in the game as a non-spectator. See attached screenshot.
Attached Filespng file icon Screenshot_Doom_20161010_033459.png [^] (49,790 bytes) 2016-10-10 01:38


png file icon Screenshot_Doom_20161010_055822.png [^] (149,282 bytes) 2016-10-10 04:09

- Relationships

-  Notes
User avatar (0015876)
WaTaKiD (updater)
2016-10-10 02:00
edited on: 2016-10-10 02:41

 does not happen in the 151004-2012 beta, but does in 151228-1140

ill find the culprit

edit: bingo: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/92a3264f3984218f6663229420695f7f4eaeac34 [^]'
User avatar (0015877)
unknownna (updater)
2016-10-10 03:44
edited on: 2016-10-10 04:09

 Nice find. This also breaks sv_maxplayers and allows you to create a 3rd dummy player after increasing sv_maxplayers if both players are in line before increasing max players.

1. zandronum -host -iwad doom2.wad +sv_maxplayers 1
2. zandronum -iwad doom2.wad -connect localhost
3. zandronum -iwad doom2.wad -connect localhost
4. Client A joins the game.
5. Client B joins the game, putting it in line.
6. Client A disconnects.
7. Client B joins the game.
8. Client A reconnects.
9. Client A joins, putting it in line.
10. "sv_maxplayers 2" in the server console. Both clients respawn at map start and client B leaves dummy body behind that turns into a dummy player if you shoot it.
User avatar (0015959)
Torr Samaho (administrator)
2016-10-13 19:33
edited on: 2016-10-13 19:34

 This change should fix the duel problem, but I'm not sure if it has any side effects. Thus, I only pushed it to the sandbox for further testing.
User avatar (0015965)
WaTaKiD (updater)
2016-10-13 21:36

 this build contains the above commit: 'https://www.dropbox.com/s/mlvoaqtm6fogh6g/zandronum-3.0-r161013-1928-0d767c9-windows.zip?dl=0 [^]'
User avatar (0015970)
unknownna (updater)
2016-10-13 23:15
edited on: 2016-10-14 00:25

 Thanks for the build, WaTaKiD.

The build seems to have fixed the disconnect issue. I tested with spectating and disconnecting, manipulating line positions and raising sv_maxplayers and the server seemed to properly allow the correct players in line to enter the game when sv_maxplayers was raised.

I'd like to keep the ticket open for a while to test it some more.

Edit:

I also tested it in CTF and it seems to work well there too now.
User avatar (0015974)
Dusk (developer)
2016-10-14 05:03

 The sandbox head was tainted by a duplicate commit and has thus been moved to a new one:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/3df2c26d6a0af63a5219284f09a1e950e64a40af [^]'
User avatar (0016200)
Combinebobnt (reporter)
2016-11-16 02:22

 Tested the duel queue upon disconnects and stuff and everything worked. Didn't test anything in CTF.
User avatar (0016499)
Ru5tK1ng (updater)
2016-12-16 07:29

 I went ahead and did the rest of the queue testing for ctf and it seemed to work fine with spectating and disconnects.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Combinebobnt capodecima
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-10-10 01:38 unknownna New Issue
2016-10-10 01:38 unknownna File Added: Screenshot_Doom_20161010_033459.png
2016-10-10 01:38 unknownna Priority urgent => immediate
2016-10-10 02:00 WaTaKiD Note Added: 0015876
2016-10-10 02:41 WaTaKiD Note Edited: 0015876 View Revisions
2016-10-10 03:44 unknownna Note Added: 0015877
2016-10-10 04:09 unknownna Note Edited: 0015877 View Revisions
2016-10-10 04:09 unknownna File Added: Screenshot_Doom_20161010_055822.png
2016-10-11 19:42 unknownna Target Version => 3.0
2016-10-13 19:20 Torr Samaho Assigned To => Torr Samaho
2016-10-13 19:20 Torr Samaho Status new => assigned
2016-10-13 19:33 Torr Samaho Note Added: 0015959
2016-10-13 19:34 Torr Samaho Note Edited: 0015959 View Revisions
2016-10-13 19:34 Torr Samaho Note Revision Dropped: 15959: 0009709
2016-10-13 19:34 Torr Samaho Status assigned => needs testing
2016-10-13 21:36 WaTaKiD Note Added: 0015965
2016-10-13 23:15 unknownna Note Added: 0015970
2016-10-14 00:25 unknownna Note Edited: 0015970 View Revisions
2016-10-14 05:03 Dusk Note Added: 0015974
2016-11-16 02:22 Combinebobnt Note Added: 0016200
2016-12-16 07:29 Ru5tK1ng Note Added: 0016499
2016-12-16 07:29 Ru5tK1ng Status needs testing => resolved
2016-12-16 07:29 Ru5tK1ng Resolution open => fixed
2016-12-16 07:29 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:53 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker