MantisBT - Zandronum
View Issue Details
0002877Zandronum[All Projects] Bugpublic2016-10-10 01:382018-09-30 21:53
unknownna 
Torr Samaho 
immediatefeaturealways
closedfixed 
3.0-beta 
3.03.0 
0002877: Duel queue broken in 3.0
If one of the players in-game disconnect, the next player in line is not put into the game. In addition to this, the line numbers get messed up, with one player displayed as being in the queue while in the game as a non-spectator. See attached screenshot.
No tags attached.
png Screenshot_Doom_20161010_033459.png (49,790) 2016-10-10 01:38
/tracker/file_download.php?file_id=1927&type=bug
png

png Screenshot_Doom_20161010_055822.png (149,282) 2016-10-10 04:09
/tracker/file_download.php?file_id=1928&type=bug
png
Issue History
2016-10-10 01:38unknownnaNew Issue
2016-10-10 01:38unknownnaFile Added: Screenshot_Doom_20161010_033459.png
2016-10-10 01:38unknownnaPriorityurgent => immediate
2016-10-10 02:00WaTaKiDNote Added: 0015876
2016-10-10 02:41WaTaKiDNote Edited: 0015876bug_revision_view_page.php?bugnote_id=15876#r9655
2016-10-10 03:44unknownnaNote Added: 0015877
2016-10-10 04:09unknownnaNote Edited: 0015877bug_revision_view_page.php?bugnote_id=15877#r9657
2016-10-10 04:09unknownnaFile Added: Screenshot_Doom_20161010_055822.png
2016-10-11 19:42unknownnaTarget Version => 3.0
2016-10-13 19:20Torr SamahoAssigned To => Torr Samaho
2016-10-13 19:20Torr SamahoStatusnew => assigned
2016-10-13 19:33Torr SamahoNote Added: 0015959
2016-10-13 19:34Torr SamahoNote Edited: 0015959bug_revision_view_page.php?bugnote_id=15959#r9710
2016-10-13 19:34Torr SamahoNote Revision Dropped: 15959: 0009709
2016-10-13 19:34Torr SamahoStatusassigned => needs testing
2016-10-13 21:36WaTaKiDNote Added: 0015965
2016-10-13 23:15unknownnaNote Added: 0015970
2016-10-14 00:25unknownnaNote Edited: 0015970bug_revision_view_page.php?bugnote_id=15970#r9720
2016-10-14 05:03DuskNote Added: 0015974
2016-11-16 02:22CombinebobntNote Added: 0016200
2016-12-16 07:29Ru5tK1ngNote Added: 0016499
2016-12-16 07:29Ru5tK1ngStatusneeds testing => resolved
2016-12-16 07:29Ru5tK1ngResolutionopen => fixed
2016-12-16 07:29Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:53Blzut3Statusresolved => closed

Notes
(0015876)
WaTaKiD   
2016-10-10 02:00   
(edited on: 2016-10-10 02:41)
does not happen in the 151004-2012 beta, but does in 151228-1140

ill find the culprit

edit: bingo: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/92a3264f3984218f6663229420695f7f4eaeac34 [^]'

(0015877)
unknownna   
2016-10-10 03:44   
(edited on: 2016-10-10 04:09)
Nice find. This also breaks sv_maxplayers and allows you to create a 3rd dummy player after increasing sv_maxplayers if both players are in line before increasing max players.

1. zandronum -host -iwad doom2.wad +sv_maxplayers 1
2. zandronum -iwad doom2.wad -connect localhost
3. zandronum -iwad doom2.wad -connect localhost
4. Client A joins the game.
5. Client B joins the game, putting it in line.
6. Client A disconnects.
7. Client B joins the game.
8. Client A reconnects.
9. Client A joins, putting it in line.
10. "sv_maxplayers 2" in the server console. Both clients respawn at map start and client B leaves dummy body behind that turns into a dummy player if you shoot it.

(0015959)
Torr Samaho   
2016-10-13 19:33   
(edited on: 2016-10-13 19:34)
This change should fix the duel problem, but I'm not sure if it has any side effects. Thus, I only pushed it to the sandbox for further testing.

(0015965)
WaTaKiD   
2016-10-13 21:36   
this build contains the above commit: 'https://www.dropbox.com/s/mlvoaqtm6fogh6g/zandronum-3.0-r161013-1928-0d767c9-windows.zip?dl=0 [^]'
(0015970)
unknownna   
2016-10-13 23:15   
(edited on: 2016-10-14 00:25)
Thanks for the build, WaTaKiD.

The build seems to have fixed the disconnect issue. I tested with spectating and disconnecting, manipulating line positions and raising sv_maxplayers and the server seemed to properly allow the correct players in line to enter the game when sv_maxplayers was raised.

I'd like to keep the ticket open for a while to test it some more.

Edit:

I also tested it in CTF and it seems to work well there too now.

(0015974)
Dusk   
2016-10-14 05:03   
The sandbox head was tainted by a duplicate commit and has thus been moved to a new one:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/3df2c26d6a0af63a5219284f09a1e950e64a40af [^]'
(0016200)
Combinebobnt   
2016-11-16 02:22   
Tested the duel queue upon disconnects and stuff and everything worked. Didn't test anything in CTF.
(0016499)
Ru5tK1ng   
2016-12-16 07:29   
I went ahead and did the rest of the queue testing for ctf and it seemed to work fine with spectating and disconnects.