Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002661Zandronum[All Projects] Bugpublic2016-03-05 21:472018-09-30 22:04
ReporterFused 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version2.2Fixed in Version3.0 
Summary0002661: sv_forcegldefaults ignores lightmode in MAPINFO
Descriptionsv_forcegldefaults ignores lightmode, even though this is an intended setting by the author and thus lightmode should be allowed to change gl_lightmode instead of the other way around.
Steps To Reproduceopen attached wad, gl_lightmode 0, sv_forcegldefaults 1. Notice how the lighting changes like gl_lightmode is 3, even though lightmode is defined to be 0 (standard)
Attached Files? file icon lightingbug.wad [^] (6,668 bytes) 2016-03-05 21:47

- Relationships

-  Notes
User avatar (0014556)
Edward-san (developer)
2016-03-06 00:54

 Pull request'd.
User avatar (0014638)
cobalt (updater)
2016-04-02 15:25

 Issue addressed by commit d2b6b4091402: - Fixed: sv_forcegldefaults 1 didn't honor the MAPINFO lightmode option if present (fixes 2661).
Committed by Edoardo Prezioso [edward-san] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/gl/data/gl_data.cpp | 10 +++++-----
 src/gl/gl_functions.h | 13 +++++++++++--
 src/gl/renderer/gl_lightdata.cpp | 4 +++-
 src/gl/shaders/gl_shader.cpp | 3 ++-
 5 files changed, 22 insertions(+), 9 deletions(-)
User avatar (0014689)
Ru5tK1ng (updater)
2016-04-10 16:22

 I tried this out with r160403-1900 and it seems lightmode defined in MAPINFO is still being ignored.
User avatar (0014698)
Edward-san (developer)
2016-04-10 21:44
edited on: 2016-04-11 14:42

 Probably the changes, which were made for 2.x, need to be adapted to 3.0. I'll have a look.

[edit]Actually, r160403-1900 does not contain the fix. You should check anything after April 9.
User avatar (0014707)
WaTaKiD (updater)
2016-04-14 20:58

 this 3.0 build includes the above commit and can be used to test:'https://www.dropbox.com/s/t93d3mlz9cqb1u8/zandronum-3.0-r160410-1037-9d18728-windows.zip?dl=0 [^]'
User avatar (0014708)
Ru5tK1ng (updater)
2016-04-15 00:28

 That build seems to fix the bug. The MAPINFO lighting definition isn't being ignored.
User avatar (0014722)
Edward-san (developer)
2016-04-17 21:17

 Thanks for checking!

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-03-05 21:47 Fused New Issue
2016-03-05 21:47 Fused File Added: lightingbug.wad
2016-03-06 00:52 Edward-san Assigned To => Edward-san
2016-03-06 00:52 Edward-san Status new => assigned
2016-03-06 00:54 Edward-san Note Added: 0014556
2016-03-06 00:54 Edward-san Status assigned => needs review
2016-04-02 15:25 cobalt Status needs review => needs testing
2016-04-02 15:25 cobalt Target Version => 2.2
2016-04-02 15:25 cobalt Note Added: 0014638
2016-04-10 16:22 Ru5tK1ng Note Added: 0014689
2016-04-10 16:22 Ru5tK1ng Status needs testing => feedback
2016-04-10 21:44 Edward-san Note Added: 0014698
2016-04-10 21:45 Edward-san Status feedback => assigned
2016-04-11 14:42 Edward-san Note Edited: 0014698 View Revisions
2016-04-11 14:42 Edward-san Status assigned => feedback
2016-04-14 20:58 WaTaKiD Note Added: 0014707
2016-04-15 00:28 Ru5tK1ng Note Added: 0014708
2016-04-17 20:15 Ru5tK1ng Status feedback => resolved
2016-04-17 20:15 Ru5tK1ng Resolution open => fixed
2016-04-17 20:15 Ru5tK1ng Fixed in Version => 3.0
2016-04-17 21:17 Edward-san Note Added: 0014722
2018-09-30 22:04 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker