MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002661Zandronum[All Projects] Bugpublic2016-03-05 21:472018-09-30 22:04
ReporterFused 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version2.2Fixed in Version3.0 
Summary0002661: sv_forcegldefaults ignores lightmode in MAPINFO
Descriptionsv_forcegldefaults ignores lightmode, even though this is an intended setting by the author and thus lightmode should be allowed to change gl_lightmode instead of the other way around.
Steps To Reproduceopen attached wad, gl_lightmode 0, sv_forcegldefaults 1. Notice how the lighting changes like gl_lightmode is 3, even though lightmode is defined to be 0 (standard)
Additional Information
TagsNo tags attached.
Relationships
Attached Files? lightingbug.wad (6,668) 2016-03-05 21:47
/tracker/file_download.php?file_id=1757&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-05 21:47FusedNew Issue
2016-03-05 21:47FusedFile Added: lightingbug.wad
2016-03-06 00:52Edward-sanAssigned To => Edward-san
2016-03-06 00:52Edward-sanStatusnew => assigned
2016-03-06 00:54Edward-sanNote Added: 0014556
2016-03-06 00:54Edward-sanStatusassigned => needs review
2016-04-02 15:25cobaltStatusneeds review => needs testing
2016-04-02 15:25cobaltTarget Version => 2.2
2016-04-02 15:25cobaltNote Added: 0014638
2016-04-10 16:22Ru5tK1ngNote Added: 0014689
2016-04-10 16:22Ru5tK1ngStatusneeds testing => feedback
2016-04-10 21:44Edward-sanNote Added: 0014698
2016-04-10 21:45Edward-sanStatusfeedback => assigned
2016-04-11 14:42Edward-sanNote Edited: 0014698bug_revision_view_page.php?bugnote_id=14698#r8896
2016-04-11 14:42Edward-sanStatusassigned => feedback
2016-04-14 20:58WaTaKiDNote Added: 0014707
2016-04-15 00:28Ru5tK1ngNote Added: 0014708
2016-04-17 20:15Ru5tK1ngStatusfeedback => resolved
2016-04-17 20:15Ru5tK1ngResolutionopen => fixed
2016-04-17 20:15Ru5tK1ngFixed in Version => 3.0
2016-04-17 21:17Edward-sanNote Added: 0014722
2018-09-30 22:04Blzut3Statusresolved => closed

Notes
(0014556)
Edward-san   
2016-03-06 00:54   
Pull request'd.
(0014638)
cobalt   
2016-04-02 15:25   
Issue addressed by commit d2b6b4091402: - Fixed: sv_forcegldefaults 1 didn't honor the MAPINFO lightmode option if present (fixes 2661).
Committed by Edoardo Prezioso [edward-san] on Wednesday 31 December 1969 23:59:57

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/gl/data/gl_data.cpp | 10 +++++-----
 src/gl/gl_functions.h | 13 +++++++++++--
 src/gl/renderer/gl_lightdata.cpp | 4 +++-
 src/gl/shaders/gl_shader.cpp | 3 ++-
 5 files changed, 22 insertions(+), 9 deletions(-)
(0014689)
Ru5tK1ng   
2016-04-10 16:22   
I tried this out with r160403-1900 and it seems lightmode defined in MAPINFO is still being ignored.
(0014698)
Edward-san   
2016-04-10 21:44   
(edited on: 2016-04-11 14:42)
Probably the changes, which were made for 2.x, need to be adapted to 3.0. I'll have a look.

[edit]Actually, r160403-1900 does not contain the fix. You should check anything after April 9.
(0014707)
WaTaKiD   
2016-04-14 20:58   
this 3.0 build includes the above commit and can be used to test:'https://www.dropbox.com/s/t93d3mlz9cqb1u8/zandronum-3.0-r160410-1037-9d18728-windows.zip?dl=0 [^]'
(0014708)
Ru5tK1ng   
2016-04-15 00:28   
That build seems to fix the bug. The MAPINFO lighting definition isn't being ignored.
(0014722)
Edward-san   
2016-04-17 21:17   
Thanks for checking!