Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002519Zandronum[All Projects] Bugpublic2015-11-09 19:362018-09-30 21:56
ReporterWaTaKiD 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002519: some scripts in this wad dont work properly online
Descriptionxa-psych-b5b.pk3 is here:'http://forum.zdoom.org/viewtopic.php?f=19&t=21681 [^]'

the wad works correctly offline and in g/zdoom, however online:
when pressing a bind for the menu script (psychic-shopmenu), the menu doesnt pop up
and when pressing the binds for the quickbuy (psychic-quickbuy), it instead calls a completely different script (psychic-mapreset)
Steps To Reproduceload xa-psych-b5b.pk3 offline
press all the wad's bindings found in customize controls
notice that everything works fine and calls the proper scripts

repeat online, menu doesnt work and the quickbuy binds call the wrong script
Attached Files

- Relationships
related to 0002431closedTorr Samaho Rapid PUKENAME on a net script will get you kicked from the server for "client command flood". 

-  Notes
User avatar (0013789)
Torr Samaho (administrator)
2015-11-14 18:57

 I'm pretty sure that pukename is at fault. I'll take care of this once Dusk's index for named ACS scripts is finalized.
User avatar (0013876)
Torr Samaho (administrator)
2015-11-23 19:51
edited on: 2015-11-23 19:52

 puekname should be fixed now. Please test thoroughly.
User avatar (0013881)
cobalt (updater)
2015-11-25 23:28

 Issue addressed by commit 980fac18f4ca: Fixed: Under certain circumstances, the 'pukename' command didn't work on the client (fixes 2519).
Committed by Benjamin Berkels [Torr Samaho] on Monday 23 November 2015 20:47:32

Changes in files:

 src/cl_commands.cpp | 15 +++++++++++++--
 src/sv_main.cpp | 12 +++++++++---
 2 files changed, 22 insertions(+), 5 deletions(-)
User avatar (0013918)
WaTaKiD (updater)
2015-11-29 20:50

 using'https://www.dropbox.com/s/obffhny5vh06g6e/zandronum-3.0-r150809-0703-83ceae7-windows.zip?dl=0 [^]'

i connected 2 clients to a local server and they were both able to use the menu, set their own quickbuy slots, and everything seemed to work correctly
User avatar (0013938)
Ru5tK1ng (updater)
2015-12-05 18:34

 I was able to get the bindings to work with the above build. However, I noticed if I had the buy menu open as a spectator and join the game, the binds no longer worked. New clients would not be able to use the scripts until the map was reset.
User avatar (0014613)
WaTaKiD (updater)
2016-03-28 19:05

 using the above build and the latest official beta (3.0-r160229-1221), i was able to reproduce the part with the spectator joining the game with the menu open and not being able to use it anymore, but new clients were still able to use it just fine

im not sure if this has something to do with zandro or the mod, because keeping in mind that this mod was not made with the intention for zandro netplay so its possible the mod just needs a patch to change a few things (for example, try using the quickbuy binds and notice that the error messages get printed to the server console, not the player's)
User avatar (0014695)
Torr Samaho (administrator)
2016-04-10 19:16

 ZDoom's script logic doesn't factor in spectators. The only thing we could do is to completely forbid spectators to puke scripts.
User avatar (0014713)
Ru5tK1ng (updater)
2016-04-15 02:01

 Even then, I'm not so sure that's a good solution to forbid spectator puking. I know there were a few mods that had scripts which displayed info to specs and players alike.
User avatar (0015157)
Torr Samaho (administrator)
2016-07-02 09:25

 So as long as spectators don't puke any scripts, this wad is working fine now?
User avatar (0015171)
WaTaKiD (updater)
2016-07-02 15:05

 i am still unable to reproduce new clients being unable to use the scripts mentioned here:'http://zandronum.com/tracker/view.php?id=2519#c13938 [^]'

is it possible it was a one time fluke or am i missing something?

also the bit about the messages i mentioned here'http://zandronum.com/tracker/view.php?id=2519#c14613 [^]' seems to also happen in zdoom as per'http://forum.zdoom.org/viewtopic.php?f=15&t=45591&p=904870#p904870 [^]' so nevermind that

so yes, im gonna say the wad is working fine
User avatar (0015850)
Torr Samaho (administrator)
2016-10-09 17:52

 Thanks for checking. I'll consider this resolved then.
User avatar (0015984)
unknownna (updater)
2016-10-14 10:14
Quote from Ru5tK1ng
However, I noticed if I had the buy menu open as a spectator and join the game, the binds no longer worked. New clients would not be able to use the scripts until the map was reset.

This issue is still present. You open the menu as a spectator, then join the game before exiting the menu. After that, you and any player that enters your player spot after you disconnect will be unable to use the menu.
User avatar (0016154)
Torr Samaho (administrator)
2016-11-06 17:02

 As I said above, ZDoom's script logic doesn't factor in spectators. The only thing we could do is to completely forbid spectators to puke scripts.
User avatar (0016156)
Empyre (reporter)
2016-11-06 17:28

 Is there a way for the wad itself to forbid spectators from opening the menu? Doing so might fix this wad without breaking others. If there isn't a way, maybe there should be.
User avatar (0016157)
Torr Samaho (administrator)
2016-11-06 17:34

 Using PlayerIsSpectator, the script should be able to check whether a spectator is trying to puke it. In this case, the script could just refuse to do anything.
User avatar (0016165)
Catastrophe (reporter)
2016-11-08 22:01
edited on: 2016-11-08 22:03

 Spectators aren't allowed to puke anymore? But what about mods that have custom ACS menus that are made to be used when players are spectating only? IMO keeping the current behavior is better as some mods rely on it.
User avatar (0016167)
Torr Samaho (administrator)
2016-11-08 22:16

 No, we didn't change the behavior. I only said that the only thing Zandronum itself could do to fix the problems caused by spectators puking these scripts is to completely forbid spectators to puke scripts. Since existing mods rely on the current behavior, I don't think that this change is an option.
User avatar (0016175)
Catastrophe (reporter)
2016-11-10 02:28

 Ah thanks for the clarification. Sounds good.
User avatar (0016445)
Ru5tK1ng (updater)
2016-12-08 03:54

 I'm re-marking this as resolved unless of course 95% of the community actually wants to disable spectator puking.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-11-09 19:36 WaTaKiD New Issue
2015-11-09 19:37 WaTaKiD Description Updated View Revisions
2015-11-14 18:57 Torr Samaho Note Added: 0013789
2015-11-14 18:57 Torr Samaho Assigned To => Torr Samaho
2015-11-14 18:57 Torr Samaho Status new => assigned
2015-11-23 19:51 Torr Samaho Note Added: 0013876
2015-11-23 19:52 Torr Samaho Note Edited: 0013876 View Revisions
2015-11-23 19:52 Torr Samaho Note Revision Dropped: 13876: 0008259
2015-11-23 19:57 Torr Samaho Status assigned => needs testing
2015-11-25 23:28 cobalt Target Version => 3.0
2015-11-25 23:28 cobalt Description Updated View Revisions
2015-11-25 23:28 cobalt Steps to Reproduce Updated View Revisions
2015-11-25 23:28 cobalt Note Added: 0013881
2015-11-29 20:50 WaTaKiD Note Added: 0013918
2015-12-05 18:34 Ru5tK1ng Note Added: 0013938
2015-12-10 03:38 Ru5tK1ng Status needs testing => feedback
2015-12-10 03:38 Ru5tK1ng Description Updated View Revisions
2015-12-10 03:38 Ru5tK1ng Steps to Reproduce Updated View Revisions
2016-03-28 19:05 WaTaKiD Note Added: 0014613
2016-03-28 19:05 WaTaKiD Status feedback => assigned
2016-04-10 19:16 Torr Samaho Note Added: 0014695
2016-04-15 02:01 Ru5tK1ng Note Added: 0014713
2016-07-02 09:25 Torr Samaho Note Added: 0015157
2016-07-02 09:26 Torr Samaho Status assigned => feedback
2016-07-02 15:05 WaTaKiD Note Added: 0015171
2016-07-02 15:05 WaTaKiD Status feedback => assigned
2016-10-09 17:52 Torr Samaho Note Added: 0015850
2016-10-09 17:52 Torr Samaho Status assigned => resolved
2016-10-09 17:52 Torr Samaho Fixed in Version => 3.0
2016-10-09 17:52 Torr Samaho Resolution open => fixed
2016-10-14 10:14 unknownna Note Added: 0015984
2016-10-14 10:14 unknownna Status resolved => feedback
2016-10-14 10:14 unknownna Resolution fixed => reopened
2016-11-06 17:02 Torr Samaho Note Added: 0016154
2016-11-06 17:28 Empyre Note Added: 0016156
2016-11-06 17:34 Torr Samaho Note Added: 0016157
2016-11-08 22:01 Catastrophe Note Added: 0016165
2016-11-08 22:03 Catastrophe Note Edited: 0016165 View Revisions
2016-11-08 22:16 Torr Samaho Note Added: 0016167
2016-11-10 02:28 Catastrophe Note Added: 0016175
2016-11-20 20:38 Torr Samaho Status feedback => needs testing
2016-11-20 21:07 Torr Samaho Relationship added related to 0002431
2016-12-08 03:54 Ru5tK1ng Note Added: 0016445
2016-12-08 03:54 Ru5tK1ng Status needs testing => resolved
2016-12-08 03:54 Ru5tK1ng Resolution reopened => fixed
2018-09-30 21:56 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker