0002509: Clientside Named ENTER/DEATH/RESPAWN scripts cause wierd spew and don't execute

(0013699)
StrikerMan780 (reporter)
2015-10-28 00:36
edited on: 2015-10-28 00:47

The spew in the client console is as follows:

Spawn:
P_StartScript: Unknown Script "OverlayTypes"
P_StartScript: Unknown Script "SB_TeamDeathmatch_HeadingColor"

Death:
P_StartScript: Unknown Script "SB_Cooperative_Enable"
P_StartScript: Unknown Script "SampleRates"

Really messed up. Those aren't even real scripts... and depending on WAD/PK3 content loaded, they end up other random strings. FYI, ignore the "I don't know what X is" errors, those are normal and means the script is executing. In that case, you are unable to reproduce the bug if you don't get the messages in this screenshot:'http://puu.sh/l0976/878f66ee2d.png [^]'

EDIT: More random string BS:'http://puu.sh/l09qQ/f35fb21242.png [^]'

(0013700)
WaTaKiD (updater)
2015-10-28 00:53

i used striker's commandline here:
zandronum.exe -host -iwad doom2.wad -file BadACS.pk3 +deathmatch 1 +vid_renderer 0 +dmflags 0 +dmflags2 0 +map MAP01

and was able to reproduce the issue after changing my vid_renderer to 1 and connecting to the server:'http://pastebin.com/X2bmHCWE [^]'

(0013701)
StrikerMan780 (reporter)
2015-10-28 00:57

vid_renderer 1 on client or server?

(0013702)
WaTaKiD (updater)
2015-10-28 01:00

on the client i connected to the server and i did vid_renderer 1 in console then exited and reconnected thru the server window, the server remained as vid_renderer 0 the entire time

(0013704)
StrikerMan780 (reporter)
2015-10-28 01:04
edited on: 2015-10-28 22:39

I made this batch file to make launching servers with WADs very quick and easy. Also, I can always reproduce the error with this:'http://shadowmavericks.com/files/RunZan.bat [^]'

Just stick it in Zandronum's folder, then drag-drop BadACS.pk3 on it, and press 2.

(0013719)
cobalt (updater)
2015-11-01 15:19

Issue addressed by commit 3eaf5350e623: Fixed: Under certain circumstances, the server didn't properly instruct the clients to run named CLIENTSIDE scripts (fixes 2509).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 November 2015 16:14:57

Changes in files:

src/cl_main.cpp | 12 +++++++++---
src/sv_commands.cpp | 12 ++++++++++--
src/sv_commands.h | 2 +-
3 files changed, 20 insertions(+), 6 deletions(-)

(0013720)
Torr Samaho (administrator)
2015-11-01 15:20

This was caused by the fact that the internal FName indices differ when a client uses "vid_renderer 1" while the server uses "vid_renderer 0". Your example wad seems to be fixed now, but there may be other problems with named scripts online. Please test named script support thoroughly.

(0013744)
StrikerMan780 (reporter)
2015-11-06 01:30
edited on: 2015-11-06 01:33

Named scripts are working just fine now. However, wouldn't sending the full string use up much more bandwidth? (Especially on scripts that repeat a lot)

Any way to perhaps create an additional string table specifically for script names and send an index? (Kind of like sounds)

(0013880)
cobalt (updater)
2015-11-25 23:28

Issue addressed by commit f7b34b3e805a: Index named non-map ACS scripts so that they can be addressed over the network with 2 bytes instead of a string (addresses 2509 again)
Committed by Teemu Piippo [Dusk] on Tuesday 17 November 2015 01:37:17

Changes in files:

src/cl_main.cpp | 17 +++++++++--------
src/network.cpp | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/network.h | 5 +++++
src/p_acs.cpp | 21 +++++++++++++++++++++
src/p_acs.h | 1 +
src/sv_commands.cpp | 19 +++++++++++--------
6 files changed, 122 insertions(+), 16 deletions(-)

(0013882)
StrikerMan780 (reporter)
2015-11-26 02:54

I knew I was onto something. Awesome. I'll test this when I get a chance.

(0014042)
cobalt (updater)
2016-01-03 18:35

Issue addressed by commit 67f99bb8dc34: Made ACS script name indexing more robust, addresses 2509 yet again. Name index is now recreated on each level load and discovers all script names, not just ones in libraries.
Committed by Teemu Piippo [Dusk] on Friday 25 December 2015 20:41:45

Changes in files:

src/cl_main.cpp | 12 ++----------
src/network.cpp | 57 +++++++++++++++++++++++++++++++++++----------------------
src/network.h | 2 +-
src/p_acs.cpp | 34 +++++++++++++++++++++-------------
src/p_acs.h | 1 +
src/p_setup.cpp | 3 +++
src/sv_commands.cpp | 17 +++++++++++------
7 files changed, 74 insertions(+), 52 deletions(-)

(0014055)
Arco (updater)
2016-01-07 06:32

Works correctly in r151228-1140.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-10-27 23:14	StrikerMan780	New Issue
2015-10-27 23:14	StrikerMan780	File Added: BadACS.pk3
2015-10-28 00:36	StrikerMan780	Note Added: 0013699
2015-10-28 00:36	StrikerMan780	Note Edited: 0013699	View Revisions
2015-10-28 00:38	StrikerMan780	Note Edited: 0013699	View Revisions
2015-10-28 00:43	StrikerMan780	Note Edited: 0013699	View Revisions
2015-10-28 00:47	StrikerMan780	Note Edited: 0013699	View Revisions
2015-10-28 00:53	WaTaKiD	Note Added: 0013700
2015-10-28 00:57	StrikerMan780	Note Added: 0013701
2015-10-28 01:00	WaTaKiD	Note Added: 0013702
2015-10-28 01:04	StrikerMan780	Note Added: 0013704
2015-10-28 01:44	StrikerMan780	Note Edited: 0013704	View Revisions
2015-10-28 22:39	StrikerMan780	Note Edited: 0013704	View Revisions
2015-11-01 14:29	Torr Samaho	File Added: RunZan.bat
2015-11-01 14:38	Torr Samaho	Assigned To	=> Torr Samaho
2015-11-01 14:38	Torr Samaho	Status	new => assigned
2015-11-01 15:19	cobalt	Status	assigned => needs testing
2015-11-01 15:19	cobalt	Target Version	=> 3.0
2015-11-01 15:19	cobalt	Note Added: 0013719
2015-11-01 15:20	Torr Samaho	Note Added: 0013720
2015-11-06 01:30	StrikerMan780	Note Added: 0013744
2015-11-06 01:32	StrikerMan780	Note Edited: 0013744	View Revisions
2015-11-06 01:33	StrikerMan780	Note Edited: 0013744	View Revisions
2015-11-06 01:33	StrikerMan780	Note Edited: 0013744	View Revisions
2015-11-19 21:13	Dusk	File Added: namedscripts.wad
2015-11-25 23:28	cobalt	Note Added: 0013880
2015-11-26 02:54	StrikerMan780	Note Added: 0013882
2016-01-03 18:35	cobalt	Note Added: 0014042
2016-01-07 06:32	Arco	Note Added: 0014055
2016-01-07 06:32	Arco	Status	needs testing => resolved
2016-01-07 06:32	Arco	Resolution	open => fixed
2016-01-07 06:32	Arco	Fixed in Version	=> 3.0
2018-09-30 22:14	Blzut3	Status	resolved => closed

Notes
(0013699) StrikerMan780 (reporter) 2015-10-28 00:36 edited on: 2015-10-28 00:47	The spew in the client console is as follows: Spawn: P_StartScript: Unknown Script "OverlayTypes" P_StartScript: Unknown Script "SB_TeamDeathmatch_HeadingColor" Death: P_StartScript: Unknown Script "SB_Cooperative_Enable" P_StartScript: Unknown Script "SampleRates" Really messed up. Those aren't even real scripts... and depending on WAD/PK3 content loaded, they end up other random strings. FYI, ignore the "I don't know what X is" errors, those are normal and means the script is executing. In that case, you are unable to reproduce the bug if you don't get the messages in this screenshot:'http://puu.sh/l0976/878f66ee2d.png [^]' EDIT: More random string BS:'http://puu.sh/l09qQ/f35fb21242.png [^]'

(0013700) WaTaKiD (updater) 2015-10-28 00:53	i used striker's commandline here: zandronum.exe -host -iwad doom2.wad -file BadACS.pk3 +deathmatch 1 +vid_renderer 0 +dmflags 0 +dmflags2 0 +map MAP01 and was able to reproduce the issue after changing my vid_renderer to 1 and connecting to the server:'http://pastebin.com/X2bmHCWE [^]'

(0013701) StrikerMan780 (reporter) 2015-10-28 00:57	vid_renderer 1 on client or server?

(0013702) WaTaKiD (updater) 2015-10-28 01:00	on the client i connected to the server and i did vid_renderer 1 in console then exited and reconnected thru the server window, the server remained as vid_renderer 0 the entire time

(0013704) StrikerMan780 (reporter) 2015-10-28 01:04 edited on: 2015-10-28 22:39	I made this batch file to make launching servers with WADs very quick and easy. Also, I can always reproduce the error with this:'http://shadowmavericks.com/files/RunZan.bat [^]' Just stick it in Zandronum's folder, then drag-drop BadACS.pk3 on it, and press 2.

(0013719) cobalt (updater) 2015-11-01 15:19	Issue addressed by commit 3eaf5350e623: Fixed: Under certain circumstances, the server didn't properly instruct the clients to run named CLIENTSIDE scripts (fixes 2509). Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 November 2015 16:14:57 Changes in files: src/cl_main.cpp \| 12 +++++++++--- src/sv_commands.cpp \| 12 ++++++++++-- src/sv_commands.h \| 2 +- 3 files changed, 20 insertions(+), 6 deletions(-)

(0013720) Torr Samaho (administrator) 2015-11-01 15:20	This was caused by the fact that the internal FName indices differ when a client uses "vid_renderer 1" while the server uses "vid_renderer 0". Your example wad seems to be fixed now, but there may be other problems with named scripts online. Please test named script support thoroughly.

(0013744) StrikerMan780 (reporter) 2015-11-06 01:30 edited on: 2015-11-06 01:33	Named scripts are working just fine now. However, wouldn't sending the full string use up much more bandwidth? (Especially on scripts that repeat a lot) Any way to perhaps create an additional string table specifically for script names and send an index? (Kind of like sounds)

(0013880) cobalt (updater) 2015-11-25 23:28	Issue addressed by commit f7b34b3e805a: Index named non-map ACS scripts so that they can be addressed over the network with 2 bytes instead of a string (addresses 2509 again) Committed by Teemu Piippo [Dusk] on Tuesday 17 November 2015 01:37:17 Changes in files: src/cl_main.cpp \| 17 +++++++++-------- src/network.cpp \| 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/network.h \| 5 +++++ src/p_acs.cpp \| 21 +++++++++++++++++++++ src/p_acs.h \| 1 + src/sv_commands.cpp \| 19 +++++++++++-------- 6 files changed, 122 insertions(+), 16 deletions(-)

(0013882) StrikerMan780 (reporter) 2015-11-26 02:54	I knew I was onto something. Awesome. I'll test this when I get a chance.

(0014042) cobalt (updater) 2016-01-03 18:35	Issue addressed by commit 67f99bb8dc34: Made ACS script name indexing more robust, addresses 2509 yet again. Name index is now recreated on each level load and discovers all script names, not just ones in libraries. Committed by Teemu Piippo [Dusk] on Friday 25 December 2015 20:41:45 Changes in files: src/cl_main.cpp \| 12 ++---------- src/network.cpp \| 57 +++++++++++++++++++++++++++++++++++---------------------- src/network.h \| 2 +- src/p_acs.cpp \| 34 +++++++++++++++++++++------------- src/p_acs.h \| 1 + src/p_setup.cpp \| 3 +++ src/sv_commands.cpp \| 17 +++++++++++------ 7 files changed, 74 insertions(+), 52 deletions(-)

(0014055) Arco (updater) 2016-01-07 06:32	Works correctly in r151228-1140.

Relationships