0002498: SetActorProperty with APROP_ViewHeight is broken

Notes
(0013679) Tribeam3rd (reporter) 2015-10-21 10:17 edited on: 2015-10-21 11:15	This also seems to effect APROP_AttackZOffset Edit: Nevermind this note.

(0013680) Edward-san (developer) 2015-10-21 11:07 edited on: 2015-10-21 11:09	Does it happen with GZDoom 1.8.6? Also, are you sure that APROP_AttackZOffset is not broken in latest gzdoom? An example wad with this would help.

(0013681) Tribeam3rd (reporter) 2015-10-21 11:15	Just tested and this bug is indeed in GZDoom 1.8.6 And apparently I derped on the APROP_AttackZOffset property, it is not glitched in either Zandronum or GZDoom 1.8.6

(0013682) Edward-san (developer) 2015-10-21 11:31	Porting this zdoom commit (which requires this other zdoom commit for a clean apply) fixes the issue offline.

(0013718) cobalt (updater) 2015-11-01 14:32	Issue addressed by commit 07247c59796f: Fixed: SetActorProperty didn't work properly with APROP_ViewHeight online (fixes 2498). Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 November 2015 15:20:10 Changes in files: src/cl_main.cpp \| 12 ++++++++++++ src/network_enums.h \| 1 + src/p_acs.cpp \| 6 ++++++ src/sv_commands.cpp \| 13 +++++++++++++ src/sv_commands.h \| 1 + 5 files changed, 33 insertions(+), 0 deletions(-)

(0013733) Tribeam3rd (reporter) 2015-11-02 02:37	Unfortunatly this bug does not seem to be fixed offline or online with the latest revision.

(0013734) Torr Samaho (administrator) 2015-11-02 07:07	So fat the fix only addresses offline / online discrepancies. Before the fix, the switch didn't do anything online, now it changes the view height like it does offline. That was the only problem I noticed when quickly glancing at the example wad. Since your description doesn't actually specify what is wrong (it just says "acts weird"), I didn't know what else to look for. If you elaborate what's wrong, I can also look at the offline / ZDoom issues.

(0013737) Tribeam3rd (reporter) 2015-11-02 10:21	Not sure how to explain it, so maybe these overly sized gifs can help What Gzdoom does: 'https://dl.dropboxusercontent.com/u/49758621/right.gif [^]' What Zandronum does: 'https://dl.dropboxusercontent.com/u/49758621/notsoright.gif [^]'

(0013750) Torr Samaho (administrator) 2015-11-08 10:21	I see. Hopefully fixed now.

(0013755) cobalt (updater) 2015-11-08 12:41	Issue addressed by commit ed192f0d062f: Extended the ZDoom APROP_ViewHeight fix to also cover the online case (fixes 2498). Committed by Benjamin Berkels [Torr Samaho] on Sunday 08 November 2015 10:13:27 Changes in files: src/cl_main.cpp \| 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

(0013761) Tribeam3rd (reporter) 2015-11-08 15:09	Tested online and offline, seems fixed to me.

(0013773) Ru5tK1ng (updater) 2015-11-10 00:15	It also worked fine for me.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-10-21 10:00	Tribeam3rd	New Issue
2015-10-21 10:17	Tribeam3rd	Note Added: 0013679
2015-10-21 10:54	Dusk	File Added: zand_viewheight_glitch.wad
2015-10-21 10:54	Dusk	Description Updated	View Revisions
2015-10-21 11:07	Edward-san	Note Added: 0013680
2015-10-21 11:08	Edward-san	Status	new => feedback
2015-10-21 11:09	Edward-san	Note Edited: 0013680	View Revisions
2015-10-21 11:09	Edward-san	Note Edited: 0013680	View Revisions
2015-10-21 11:15	Tribeam3rd	Note Added: 0013681
2015-10-21 11:15	Tribeam3rd	Status	feedback => new
2015-10-21 11:15	Tribeam3rd	Note Edited: 0013679	View Revisions
2015-10-21 11:31	Edward-san	Note Added: 0013682
2015-10-21 11:31	Edward-san	Assigned To	=> Torr Samaho
2015-10-21 11:31	Edward-san	Status	new => assigned
2015-11-01 14:32	cobalt	Status	assigned => needs testing
2015-11-01 14:32	cobalt	Target Version	=> 3.0
2015-11-01 14:32	cobalt	Description Updated	View Revisions
2015-11-01 14:32	cobalt	Steps to Reproduce Updated	View Revisions
2015-11-01 14:32	cobalt	Note Added: 0013718
2015-11-02 02:37	Tribeam3rd	Note Added: 0013733
2015-11-02 07:07	Torr Samaho	Note Added: 0013734
2015-11-02 07:09	Torr Samaho	Status	needs testing => feedback
2015-11-02 10:21	Tribeam3rd	Note Added: 0013737
2015-11-02 10:21	Tribeam3rd	Status	feedback => assigned
2015-11-08 10:21	Torr Samaho	Note Added: 0013750
2015-11-08 10:31	Torr Samaho	Status	assigned => needs testing
2015-11-08 12:41	cobalt	Note Added: 0013755
2015-11-08 15:09	Tribeam3rd	Note Added: 0013761
2015-11-10 00:15	Ru5tK1ng	Note Added: 0013773
2015-11-10 00:15	Ru5tK1ng	Status	needs testing => resolved
2015-11-10 00:15	Ru5tK1ng	Resolution	open => fixed
2015-11-10 00:15	Ru5tK1ng	Fixed in Version	=> 3.0
2015-11-10 00:15	Ru5tK1ng	Description Updated	View Revisions
2015-11-10 00:15	Ru5tK1ng	Steps to Reproduce Updated	View Revisions
2018-09-30 22:16	Blzut3	Status	resolved => closed

Relationships