MantisBT - Zandronum
View Issue Details
0002498Zandronum[All Projects] Bugpublic2015-10-21 10:002018-09-30 22:16
Tribeam3rd 
Torr Samaho 
normalminoralways
closedfixed 
MicrosoftWindowsXP/Vista/7
3.0-beta 
3.03.0 
0002498: SetActorProperty with APROP_ViewHeight is broken
When settings a player's view height with SetActorProperty, it acts...weird
This does not happen in the latest GZDoom revision.
Download Wad
Play Wad Zandronum
Click Switch
Play Wad in GZDoom
Click Switch
No tags attached.
? zand_viewheight_glitch.wad (3,136) 2015-10-21 10:54
/tracker/file_download.php?file_id=1668&type=bug
Issue History
2015-10-21 10:00Tribeam3rdNew Issue
2015-10-21 10:17Tribeam3rdNote Added: 0013679
2015-10-21 10:54DuskFile Added: zand_viewheight_glitch.wad
2015-10-21 10:54DuskDescription Updatedbug_revision_view_page.php?rev_id=8154#r8154
2015-10-21 11:07Edward-sanNote Added: 0013680
2015-10-21 11:08Edward-sanStatusnew => feedback
2015-10-21 11:09Edward-sanNote Edited: 0013680bug_revision_view_page.php?bugnote_id=13680#r8156
2015-10-21 11:09Edward-sanNote Edited: 0013680bug_revision_view_page.php?bugnote_id=13680#r8157
2015-10-21 11:15Tribeam3rdNote Added: 0013681
2015-10-21 11:15Tribeam3rdStatusfeedback => new
2015-10-21 11:15Tribeam3rdNote Edited: 0013679bug_revision_view_page.php?bugnote_id=13679#r8159
2015-10-21 11:31Edward-sanNote Added: 0013682
2015-10-21 11:31Edward-sanAssigned To => Torr Samaho
2015-10-21 11:31Edward-sanStatusnew => assigned
2015-11-01 14:32cobaltStatusassigned => needs testing
2015-11-01 14:32cobaltTarget Version => 3.0
2015-11-01 14:32cobaltDescription Updatedbug_revision_view_page.php?rev_id=8184#r8184
2015-11-01 14:32cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8186#r8186
2015-11-01 14:32cobaltNote Added: 0013718
2015-11-02 02:37Tribeam3rdNote Added: 0013733
2015-11-02 07:07Torr SamahoNote Added: 0013734
2015-11-02 07:09Torr SamahoStatusneeds testing => feedback
2015-11-02 10:21Tribeam3rdNote Added: 0013737
2015-11-02 10:21Tribeam3rdStatusfeedback => assigned
2015-11-08 10:21Torr SamahoNote Added: 0013750
2015-11-08 10:31Torr SamahoStatusassigned => needs testing
2015-11-08 12:41cobaltNote Added: 0013755
2015-11-08 15:09Tribeam3rdNote Added: 0013761
2015-11-10 00:15Ru5tK1ngNote Added: 0013773
2015-11-10 00:15Ru5tK1ngStatusneeds testing => resolved
2015-11-10 00:15Ru5tK1ngResolutionopen => fixed
2015-11-10 00:15Ru5tK1ngFixed in Version => 3.0
2015-11-10 00:15Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=8211#r8211
2015-11-10 00:15Ru5tK1ngSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8212#r8212
2018-09-30 22:16Blzut3Statusresolved => closed

Notes
(0013679)
Tribeam3rd   
2015-10-21 10:17   
(edited on: 2015-10-21 11:15)
This also seems to effect APROP_AttackZOffset
Edit: Nevermind this note.

(0013680)
Edward-san   
2015-10-21 11:07   
(edited on: 2015-10-21 11:09)
Does it happen with GZDoom 1.8.6?

Also, are you sure that APROP_AttackZOffset is not broken in latest gzdoom? An example wad with this would help.

(0013681)
Tribeam3rd   
2015-10-21 11:15   
Just tested and this bug is indeed in GZDoom 1.8.6
And apparently I derped on the APROP_AttackZOffset property, it is not glitched in either Zandronum or GZDoom 1.8.6
(0013682)
Edward-san   
2015-10-21 11:31   
Porting this zdoom commit (which requires this other zdoom commit for a clean apply) fixes the issue offline.
(0013718)
cobalt   
2015-11-01 14:32   
Issue addressed by commit 07247c59796f: Fixed: SetActorProperty didn't work properly with APROP_ViewHeight online (fixes 2498).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 November 2015 15:20:10

Changes in files:

 src/cl_main.cpp | 12 ++++++++++++
 src/network_enums.h | 1 +
 src/p_acs.cpp | 6 ++++++
 src/sv_commands.cpp | 13 +++++++++++++
 src/sv_commands.h | 1 +
 5 files changed, 33 insertions(+), 0 deletions(-)

(0013733)
Tribeam3rd   
2015-11-02 02:37   
Unfortunatly this bug does not seem to be fixed offline or online with the latest revision.
(0013734)
Torr Samaho   
2015-11-02 07:07   
So fat the fix only addresses offline / online discrepancies. Before the fix, the switch didn't do anything online, now it changes the view height like it does offline. That was the only problem I noticed when quickly glancing at the example wad. Since your description doesn't actually specify what is wrong (it just says "acts weird"), I didn't know what else to look for. If you elaborate what's wrong, I can also look at the offline / ZDoom issues.
(0013737)
Tribeam3rd   
2015-11-02 10:21   
Not sure how to explain it, so maybe these overly sized gifs can help

What Gzdoom does:
'https://dl.dropboxusercontent.com/u/49758621/right.gif [^]'

What Zandronum does:
'https://dl.dropboxusercontent.com/u/49758621/notsoright.gif [^]'
(0013750)
Torr Samaho   
2015-11-08 10:21   
I see. Hopefully fixed now.
(0013755)
cobalt   
2015-11-08 12:41   
Issue addressed by commit ed192f0d062f: Extended the ZDoom APROP_ViewHeight fix to also cover the online case (fixes 2498).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 08 November 2015 10:13:27

Changes in files:

 src/cl_main.cpp | 1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

(0013761)
Tribeam3rd   
2015-11-08 15:09   
Tested online and offline, seems fixed to me.
(0013773)
Ru5tK1ng   
2015-11-10 00:15   
It also worked fine for me.