0002486: *** ERROR: Tried to spawn a class-less actor

(0013646)
Torr Samaho (administrator)
2015-10-10 15:08

Please supply a minimal example wad that triggers the error.

(0013647)
Dusk (developer)
2015-10-10 15:15

FYI that error happens when it literally tries to spawn an actor without a class. So there's no information, no class name to give. You've run into a bug and we need more information to fix it.

(0013656)
Fastclick (reporter)
2015-10-10 22:18
edited on: 2015-10-10 23:05

I found where is a problem.
I used nonexistent "bloodtype" in this actor. Minimal example wad uploaded.

To reproduce:
1. load test_classless.pk3
2. summon testdemon
3. shoot at it.

Online - server kick all clients and restarts with "Tried to spawn a class-less actor" error.
Offline - all fine.

(0013657)
Dusk (developer)
2015-10-10 23:04
edited on: 2015-10-10 23:04

Found the culprit. In the past the server went to spawn the blood actor if bloodtype <= 1 check didn't satisfy. Now it goes in there even if bloodcls is NULL.

(0013663)
Fastclick (reporter)
2015-10-12 15:43
edited on: 2015-10-12 15:45

Glad that my mistake helped to find zan's problem, but that ticket is about this error in global meaning.
I mean: why error, not warning (can we ignore it, write to log and move on ?) Its not like "nothing trying to spawn nothing" its more like "something trying to spawn "bad_actor"". Can we have more detail about what courses it to happen (DECORATE\ACS string, or actor that trying to spawn "bad_actor") ?

P.S. Similar question about missing actor for model in MODELDEF (why error instead of warning?), but i presume, 1 problem - 1 ticket.

P.P.S. I'am newbie here so, accept my apologies, if I asking something on what the answer is obvious.

(0013664)
Dusk (developer)
2015-10-12 18:34

The engine spawns actors using actor classes (e.g. spawn an imp using the imp class). The error happens when the engine is creating an actor and find out that the actor class is missing. So it finds itself trying to spawn an actor without any idea what actor needs to be spawned. It would need to spawn *something* in order to continue execution. I guess it could spawn exclamation marks of doom instead but it wasn't me who made that decision (this behavior comes from ZDoom, even though it's a Zandronum bug which manages to trigger it).

MODELDEF is something completely different. I believe there's already a ticket for the issue you describe, I'm not very familiar with MODELDEF myself.

(0013754)
Torr Samaho (administrator)
2015-11-08 12:41

The crash should be fixed now. Dusk is right about the error message. If the engine encounters this problem, it really doesn't know what it was supposed to spawn leading to a very generic error message.

(0013756)
cobalt (updater)
2015-11-08 12:41

Issue addressed by commit 8aca8366a316: Fixed a server crash related to actors with nonexistent BloodType (fixes 2486).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 08 November 2015 13:38:37

Changes in files:

src/p_mobj.cpp | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)

(0013758)
Fastclick (reporter)
2015-11-08 13:14

Can we have a build that contain 8aca836 and earlier commits ?

(0013760)
WaTaKiD (updater)
2015-11-08 15:00

'https://www.dropbox.com/s/f9lwn8d8ojsn75x/zandronum-3.0-r151108-1238-8aca836-windows.zip?dl=0 [^]'

(0013762)
Fastclick (reporter)
2015-11-08 16:00
edited on: 2015-11-08 16:01

Can confirm, that bug is fixed. Thankyou.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-10-10 13:57	Fastclick	New Issue
2015-10-10 15:08	Torr Samaho	Note Added: 0013646
2015-10-10 15:13	Dusk	Status	new => feedback
2015-10-10 15:15	Dusk	Note Added: 0013647
2015-10-10 22:10	Fastclick	File Added: test_classless.pk3
2015-10-10 22:18	Fastclick	Note Added: 0013656
2015-10-10 22:18	Fastclick	Status	feedback => new
2015-10-10 23:04	Fastclick	Note Edited: 0013656	View Revisions
2015-10-10 23:04	Dusk	Note Added: 0013657
2015-10-10 23:04	Dusk	Note Edited: 0013657	View Revisions
2015-10-10 23:05	Fastclick	Note Edited: 0013656	View Revisions
2015-10-10 23:05	Dusk	Status	new => confirmed
2015-10-10 23:06	Dusk	Reproducibility	random => always
2015-10-12 15:43	Fastclick	Note Added: 0013663
2015-10-12 15:45	Fastclick	Note Edited: 0013663	View Revisions
2015-10-12 18:34	Dusk	Note Added: 0013664
2015-11-08 12:41	Torr Samaho	Note Added: 0013754
2015-11-08 12:41	Torr Samaho	Assigned To	=> Torr Samaho
2015-11-08 12:41	Torr Samaho	Status	confirmed => needs testing
2015-11-08 12:41	cobalt	Target Version	=> 3.0
2015-11-08 12:41	cobalt	Description Updated	View Revisions
2015-11-08 12:41	cobalt	Note Added: 0013756
2015-11-08 13:14	Fastclick	Note Added: 0013758
2015-11-08 15:00	WaTaKiD	Note Added: 0013760
2015-11-08 16:00	Fastclick	Note Added: 0013762
2015-11-08 16:01	Fastclick	Note Edited: 0013762	View Revisions
2015-11-08 21:24	Dusk	Status	needs testing => resolved
2015-11-08 21:24	Dusk	Fixed in Version	=> 3.0
2015-11-08 21:24	Dusk	Resolution	open => fixed
2018-09-30 22:16	Blzut3	Status	resolved => closed

Notes
(0013646) Torr Samaho (administrator) 2015-10-10 15:08	Please supply a minimal example wad that triggers the error.

(0013647) Dusk (developer) 2015-10-10 15:15	FYI that error happens when it literally tries to spawn an actor without a class. So there's no information, no class name to give. You've run into a bug and we need more information to fix it.

(0013656) Fastclick (reporter) 2015-10-10 22:18 edited on: 2015-10-10 23:05	I found where is a problem. I used nonexistent "bloodtype" in this actor. Minimal example wad uploaded. To reproduce: 1. load test_classless.pk3 2. summon testdemon 3. shoot at it. Online - server kick all clients and restarts with "Tried to spawn a class-less actor" error. Offline - all fine.

(0013657) Dusk (developer) 2015-10-10 23:04 edited on: 2015-10-10 23:04	Found the culprit. In the past the server went to spawn the blood actor if bloodtype <= 1 check didn't satisfy. Now it goes in there even if bloodcls is NULL.

(0013663) Fastclick (reporter) 2015-10-12 15:43 edited on: 2015-10-12 15:45	Glad that my mistake helped to find zan's problem, but that ticket is about this error in global meaning. I mean: why error, not warning (can we ignore it, write to log and move on ?) Its not like "nothing trying to spawn nothing" its more like "something trying to spawn "bad_actor"". Can we have more detail about what courses it to happen (DECORATE\ACS string, or actor that trying to spawn "bad_actor") ? P.S. Similar question about missing actor for model in MODELDEF (why error instead of warning?), but i presume, 1 problem - 1 ticket. P.P.S. I'am newbie here so, accept my apologies, if I asking something on what the answer is obvious.

(0013664) Dusk (developer) 2015-10-12 18:34	The engine spawns actors using actor classes (e.g. spawn an imp using the imp class). The error happens when the engine is creating an actor and find out that the actor class is missing. So it finds itself trying to spawn an actor without any idea what actor needs to be spawned. It would need to spawn something in order to continue execution. I guess it could spawn exclamation marks of doom instead but it wasn't me who made that decision (this behavior comes from ZDoom, even though it's a Zandronum bug which manages to trigger it). MODELDEF is something completely different. I believe there's already a ticket for the issue you describe, I'm not very familiar with MODELDEF myself.

(0013754) Torr Samaho (administrator) 2015-11-08 12:41	The crash should be fixed now. Dusk is right about the error message. If the engine encounters this problem, it really doesn't know what it was supposed to spawn leading to a very generic error message.

(0013756) cobalt (updater) 2015-11-08 12:41	Issue addressed by commit 8aca8366a316: Fixed a server crash related to actors with nonexistent BloodType (fixes 2486). Committed by Benjamin Berkels [Torr Samaho] on Sunday 08 November 2015 13:38:37 Changes in files: src/p_mobj.cpp \| 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)

(0013758) Fastclick (reporter) 2015-11-08 13:14	Can we have a build that contain 8aca836 and earlier commits ?

(0013760) WaTaKiD (updater) 2015-11-08 15:00	'https://www.dropbox.com/s/f9lwn8d8ojsn75x/zandronum-3.0-r151108-1238-8aca836-windows.zip?dl=0 [^]'

(0013762) Fastclick (reporter) 2015-11-08 16:00 edited on: 2015-11-08 16:01	Can confirm, that bug is fixed. Thankyou.

Relationships