Zandronum Chat on our Discord Server Get the latest version: 3.2.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002351Zandronum[All Projects] Bugpublic2015-07-15 19:492025-10-11 03:17
ReporterDusk 
Assigned To 
PrioritylowSeveritytrivialReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0002351: CALLVOTE_CountNumEligibleVoters is useless
Description'http://hastebin.com/vumikogera.cpp [^]'
The for loop is clearly useless because the breaking point is commented out (and I don't think anyone is going to uncomment it anytime soon), so ulIdx2 is always MAXPLAYERS.

So effective it's the same as this:'http://hastebin.com/elenetihub.cpp [^]'
And this in turn means we could replace it with a call to SERVER_CountPlayers( false ).
Attached Files

- Relationships

-  Notes
User avatar (0012947)
Dusk (developer)
2015-07-15 19:51
edited on: 2015-07-15 19:51

 To keep its symbolic meaning we could probably rewrite it as:

int CALLVOTE_CountNumEligibleVoters()
{
    return SERVER_CountPlayers( false );
}


In case we need to refine the definition of "eligible" sometime.
User avatar (0024573)
Ru5tK1ng (updater)
2025-10-11 03:17

 It's been changed since then so I don't think this ticket is valid anymore.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-07-15 19:49 Dusk New Issue
2015-07-15 19:51 Dusk Note Added: 0012947
2015-07-15 19:51 Dusk Note Edited: 0012947 View Revisions
2025-10-11 03:17 Ru5tK1ng Note Added: 0024573
2025-10-11 03:17 Ru5tK1ng Status new => resolved
2025-10-11 03:17 Ru5tK1ng Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker