0002179: gitinfo issues

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002179

Zandronum

[All Projects] Bug

public

2015-04-09 21:30

2018-09-30 21:39

Reporter

Dusk

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.1

Target Version

Fixed in Version

2.1

Summary

0002179: gitinfo issues

Description

edward-san pointed out that it doesn't compile under Linux atm, needs another cherry-pick:'https://github.com/rheit/zdoom/commit/d1835b2. [^]' The missing CMakeLists.txt change also prevents build under CMake on Windows.

Additionally, gitinfo.h is being version controlled, it probably shouldn't be.

Attached Files

Relationships

Notes
(0012079) DevilHunter (reporter) 2015-04-09 22:48	It failed on Linux for me, however I can build just fine using VC 2005++.. Don't think that has anything to do with Cmake though.

(0012080) Dusk (developer) 2015-04-10 09:18	According to edward-san it compiles just fine now. It's great to have this improvement around. :)

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-04-09 21:30	Dusk	New Issue
2015-04-09 21:30	Dusk	Product Version	=> 2.1
2015-04-09 21:32	Dusk	Description Updated	View Revisions
2015-04-09 21:33	Dusk	Description Updated	View Revisions
2015-04-09 22:48	DevilHunter	Note Added: 0012079
2015-04-10 09:18	Dusk	Note Added: 0012080
2015-04-10 09:18	Dusk	Status	new => resolved
2015-04-10 09:18	Dusk	Fixed in Version	=> 2.1
2015-04-10 09:18	Dusk	Resolution	open => fixed
2015-04-10 09:18	Dusk	Assigned To	=> Torr Samaho
2018-09-30 21:39	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.