Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002118Zandronum[All Projects] Bugpublic2015-03-06 14:342018-09-30 23:04
ReporterDark-Assassin 
Assigned ToEdward-san 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002118: A_RailAttack spread_xy/z does nothing
DescriptionA_RailAttack's spread_xy/z just does nothing.
However, it works as intended in ZDoom 2.5.0
Steps To Reproduce1: Load Attached WAD
2: Give RailTest (Replaces PlasmaRifle)
3: Select it (Slot 6) and Fire away.
Additional InformationTested in ZandroDev2.0-150118-1152
Attached Files? file icon RailTest.wad [^] (562 bytes) 2015-03-06 14:34

- Relationships

-  Notes
User avatar (0011776)
Edward-san (developer)
2015-03-06 15:29

 Fixed.
User avatar (0011777)
DevilHunter (reporter)
2015-03-06 23:26

 Confirmed as Fixed
User avatar (0011780)
ZzZombo (reporter)
2015-03-07 09:09

 I'm just curious how the line
P_RailAttackWithPossibleSpread (self, Damage, Spawnofs_XY, Color1, Color2, MaxDiff, (Flags & RAF_SILENT), PuffType, (!(Flags & RAF_NOPIERCE))), angle, slope;
was interpreted?
User avatar (0011781)
Konar6 (reporter)
2015-03-07 09:37

 It just ignored angle and slope since they were not part of the function call, which was fine for the compiler because they have declared default values. The compiler saw

P_RailAttackWithPossibleSpread(..);
angle; //
slope; //this was probably optimized out because it doesn't do anything
User avatar (0011785)
cobalt (updater)
2015-03-08 19:17

 Issue addressed by commit 546c840f70fc: - Fixed a bad merge during the code upgrade in changeset cf1e312f353a (fixes 2118).
Committed by edward_san [edward-san] on Friday 06 March 2015 16:28:49

Changes in files:
 src/thingdef/thingdef_codeptr.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
User avatar (0011796)
WaTaKiD (updater)
2015-03-08 22:06

 after testing with 2.0-r150308-2039, issue seems fixed
User avatar (0011799)
Dark-Assassin (administrator)
2015-03-09 04:10

 I can confirm it works correctly.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-03-06 14:34 Dark-Assassin New Issue
2015-03-06 14:34 Dark-Assassin File Added: RailTest.wad
2015-03-06 15:19 Edward-san Assigned To => Edward-san
2015-03-06 15:19 Edward-san Status new => assigned
2015-03-06 15:29 Edward-san Note Added: 0011776
2015-03-06 15:29 Edward-san Status assigned => needs review
2015-03-06 23:26 DevilHunter Note Added: 0011777
2015-03-07 09:09 ZzZombo Note Added: 0011780
2015-03-07 09:37 Konar6 Note Added: 0011781
2015-03-08 19:16 cobalt Status needs review => needs testing
2015-03-08 19:16 cobalt Target Version => 2.0
2015-03-08 19:16 cobalt Description Updated View Revisions
2015-03-08 19:16 cobalt Steps to Reproduce Updated View Revisions
2015-03-08 19:17 cobalt Note Added: 0011785
2015-03-08 20:39 cobalt Note Added: 0011790
2015-03-08 20:41 Dusk Note Deleted: 0011790
2015-03-08 22:06 WaTaKiD Note Added: 0011796
2015-03-09 04:10 Dark-Assassin Note Added: 0011799
2015-03-09 04:47 Dusk Status needs testing => resolved
2015-03-09 04:47 Dusk Fixed in Version => 2.0
2015-03-09 04:47 Dusk Resolution open => fixed
2018-09-30 23:04 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker