MantisBT - Zandronum
View Issue Details
0002118Zandronum[All Projects] Bugpublic2015-03-06 14:342018-09-30 23:04
Dark-Assassin 
Edward-san 
highmajoralways
closedfixed 
2.0-beta 
2.02.0 
0002118: A_RailAttack spread_xy/z does nothing
A_RailAttack's spread_xy/z just does nothing.
However, it works as intended in ZDoom 2.5.0
1: Load Attached WAD
2: Give RailTest (Replaces PlasmaRifle)
3: Select it (Slot 6) and Fire away.
Tested in ZandroDev2.0-150118-1152
No tags attached.
? RailTest.wad (562) 2015-03-06 14:34
/tracker/file_download.php?file_id=1425&type=bug
Issue History
2015-03-06 14:34Dark-AssassinNew Issue
2015-03-06 14:34Dark-AssassinFile Added: RailTest.wad
2015-03-06 15:19Edward-sanAssigned To => Edward-san
2015-03-06 15:19Edward-sanStatusnew => assigned
2015-03-06 15:29Edward-sanNote Added: 0011776
2015-03-06 15:29Edward-sanStatusassigned => needs review
2015-03-06 23:26DevilHunterNote Added: 0011777
2015-03-07 09:09ZzZomboNote Added: 0011780
2015-03-07 09:37Konar6Note Added: 0011781
2015-03-08 19:16cobaltStatusneeds review => needs testing
2015-03-08 19:16cobaltTarget Version => 2.0
2015-03-08 19:16cobaltDescription Updatedbug_revision_view_page.php?rev_id=6727#r6727
2015-03-08 19:16cobaltSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6729#r6729
2015-03-08 19:17cobaltNote Added: 0011785
2015-03-08 20:39cobaltNote Added: 0011790
2015-03-08 20:41DuskNote Deleted: 0011790
2015-03-08 22:06WaTaKiDNote Added: 0011796
2015-03-09 04:10Dark-AssassinNote Added: 0011799
2015-03-09 04:47DuskStatusneeds testing => resolved
2015-03-09 04:47DuskFixed in Version => 2.0
2015-03-09 04:47DuskResolutionopen => fixed
2018-09-30 23:04Blzut3Statusresolved => closed

Notes
(0011776)
Edward-san   
2015-03-06 15:29   
Fixed.
(0011777)
DevilHunter   
2015-03-06 23:26   
Confirmed as Fixed
(0011780)
ZzZombo   
2015-03-07 09:09   
I'm just curious how the line
P_RailAttackWithPossibleSpread (self, Damage, Spawnofs_XY, Color1, Color2, MaxDiff, (Flags & RAF_SILENT), PuffType, (!(Flags & RAF_NOPIERCE))), angle, slope;
was interpreted?
(0011781)
Konar6   
2015-03-07 09:37   
It just ignored angle and slope since they were not part of the function call, which was fine for the compiler because they have declared default values. The compiler saw

P_RailAttackWithPossibleSpread(..);
angle; //
slope; //this was probably optimized out because it doesn't do anything
(0011785)
cobalt   
2015-03-08 19:17   
Issue addressed by commit 546c840f70fc: - Fixed a bad merge during the code upgrade in changeset cf1e312f353a (fixes 2118).
Committed by edward_san [edward-san] on Friday 06 March 2015 16:28:49

Changes in files:
 src/thingdef/thingdef_codeptr.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(0011796)
WaTaKiD   
2015-03-08 22:06   
after testing with 2.0-r150308-2039, issue seems fixed
(0011799)
Dark-Assassin   
2015-03-09 04:10   
I can confirm it works correctly.