0002115: "Tag" Weapon Actory Property is Ignored

(0011758)
Edward-san (developer)
2015-02-25 20:50

Can you reproduce with GZDoom 900? What about GZDoom 1.6?

(0011759)
Dusk (developer)
2015-02-25 21:11

I'm 95% sure this is a missing feature that hasn't been ported yet.

(0011760)
StrikerMan780 (reporter)
2015-02-25 22:02
edited on: 2015-02-25 22:02

Works fine in GZDoom 900. It's the "Display Nametags" feature. Might as well use that, and delete the Weapon name display code from Skulltag, since it's the exact same feature duplicated, but the (G)ZDoom version supports the tags.

(0011761)
Edward-san (developer)
2015-02-26 00:34

What does the console command 'displaynametags' report? If it's 0, what happens if you use 'displaynametags 2'?

(0011762)
StrikerMan780 (reporter)
2015-02-26 06:10

If it's on 2, it still doesn't work. It's bugged. (Seems to be conflicting with the older Skulltag implementation.)

(0011764)
Dusk (developer)
2015-02-26 14:37

This should fix the behavior and also reduces delta by a nice amount.

(0011767)
StrikerMan780 (reporter)
2015-02-28 20:02

Awesome.

(0011786)
Torr Samaho (administrator)
2015-03-08 19:19

Dusk, your patch looks fine. If you think it was tested thoroughly enough, I'll pull it into 2.0.

(0011803)
cobalt (updater)
2015-03-09 19:16

Issue addressed by commit 2d82e4ba5071: - fixed: weapon nametags weren't properly handled (also reduced delta with ZDoom to make the code more resistant to future merge errors). Fixes 2115.
Committed by Teemu Piippo [Dusk] on Thursday 26 February 2015 16:36:53

Changes in files:
src/cl_main.cpp | 17 +++++++++++
src/g_game.cpp | 205 ++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------------------------
2 files changed, 69 insertions(+), 153 deletions(-)

(0011806)
StrikerMan780 (reporter)
2015-03-09 23:57
edited on: 2015-03-10 00:04

Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]'

BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point.

(0011812)
Torr Samaho (administrator)
2015-03-11 19:41
edited on: 2015-03-11 19:47

Please post a minimal example wad.

(0011813)
StrikerMan780 (reporter)
2015-03-11 19:43

An example wad isn't necessary. The default Doom weapons have tags.

SuperShotgun should read as "Super Shotgun", RocketLauncher should read as "Rocket Launcher", etc. However, they do not.

(0011814)
Torr Samaho (administrator)
2015-03-11 19:47
edited on: 2015-03-11 19:47

Works fine for me offline and online with "displaynametags 2" in my latest local build.

EDIT: Shall we change the default value of displaynametags to 2 to mimic the old default behavior, i.e. "cl_showweapnameoncycle 1"?

(0011815)
Dusk (developer)
2015-03-11 19:55
edited on: 2015-03-11 19:55

Or add ini migration to translate the change for existing configs?
You could use an expression like 'if ( lastver == NULL || atof( lastver ) <= 181 ) { ... }' to match such configs.

(0011816)
StrikerMan780 (reporter)
2015-03-11 19:55
edited on: 2015-03-11 19:56

I'd say yes, make it default (dunno why it isn't default in ZDoom as it is).

Also, can someone confirm if the build I linked to is out-of-date?

(0011817)
Torr Samaho (administrator)
2015-03-12 07:14

Quote from Dusk
Or add ini migration to translate the change for existing configs?

This will only keep the known behavior for existing users and existing installs. New users (or people who freshly re-install Zandronum) will not have the weapon tags displayed by default then.

The ini translation is great if we explicitly want to change some default behavior without bothering existing users, but is this the case here? I actually like the old default behavior.

(0011818)
Dusk (developer)
2015-03-12 15:02

Very well then, though if we're going that route, why not set the default all the way to 3? I never saw much point in having name tags only for weapons now that we have tags for items too.

(0011819)
Torr Samaho (administrator)
2015-03-13 07:33

Good point. Let's default to 3.

(0011820)
Dusk (developer)
2015-03-13 17:30
edited on: 2015-03-13 17:34

Quote from StrikerMan780

Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]'

BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point.

]version_info
changeset: 339da8a48c22
date: Sun Jan 25 19:00:42 2015

The build is of a changeset almost two months old and does not contain the fix. The filename of the build appears to be incorrect as the version of it is actually 150125-1900. cl_showweapnameoncycle was removed.

(0011821)
Dusk (developer)
2015-03-13 20:50

I think it's pretty clear at this point that the feature is working as intended.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-02-25 18:51	StrikerMan780	New Issue
2015-02-25 20:50	Edward-san	Note Added: 0011758
2015-02-25 21:11	Dusk	Note Added: 0011759
2015-02-25 22:02	StrikerMan780	Note Added: 0011760
2015-02-25 22:02	StrikerMan780	Note Edited: 0011760	View Revisions
2015-02-26 00:34	Edward-san	Note Added: 0011761
2015-02-26 06:10	StrikerMan780	Note Added: 0011762
2015-02-26 12:05	Dusk	Assigned To	=> Dusk
2015-02-26 12:05	Dusk	Status	new => assigned
2015-02-26 12:32	Dusk	Target Version	=> 2.0
2015-02-26 14:37	Dusk	Note Added: 0011764
2015-02-26 14:37	Dusk	Status	assigned => needs review
2015-02-28 20:02	StrikerMan780	Note Added: 0011767
2015-03-08 19:19	Torr Samaho	Note Added: 0011786
2015-03-08 19:19	Torr Samaho	Status	needs review => feedback
2015-03-09 19:16	cobalt	Status	feedback => needs testing
2015-03-09 19:16	cobalt	Note Added: 0011803
2015-03-09 23:57	StrikerMan780	Note Added: 0011806
2015-03-09 23:58	StrikerMan780	Note Edited: 0011806	View Revisions
2015-03-09 23:59	StrikerMan780	Note Edited: 0011806	View Revisions
2015-03-10 00:04	StrikerMan780	Note Edited: 0011806	View Revisions
2015-03-11 19:41	Torr Samaho	Note Added: 0011812
2015-03-11 19:43	StrikerMan780	Note Added: 0011813
2015-03-11 19:44	Torr Samaho	Note Edited: 0011812
2015-03-11 19:47	Torr Samaho	Note Added: 0011814
2015-03-11 19:47	Torr Samaho	Note Edited: 0011812	View Revisions
2015-03-11 19:47	Torr Samaho	Note Edited: 0011814	View Revisions
2015-03-11 19:49	Torr Samaho	Note Revision Dropped: 11812: 0006763
2015-03-11 19:49	Torr Samaho	Note Revision Dropped: 11812: 0006762
2015-03-11 19:55	Dusk	Note Added: 0011815
2015-03-11 19:55	Dusk	Note Edited: 0011815	View Revisions
2015-03-11 19:55	StrikerMan780	Note Added: 0011816
2015-03-11 19:56	StrikerMan780	Note Edited: 0011816	View Revisions
2015-03-12 07:14	Torr Samaho	Note Added: 0011817
2015-03-12 15:02	Dusk	Note Added: 0011818
2015-03-13 07:33	Torr Samaho	Note Added: 0011819
2015-03-13 17:30	Dusk	Note Added: 0011820
2015-03-13 17:30	Dusk	Note Edited: 0011820	View Revisions
2015-03-13 17:30	Dusk	Note Edited: 0011820	View Revisions
2015-03-13 17:31	Dusk	Note Edited: 0011820	View Revisions
2015-03-13 17:34	Dusk	Note Edited: 0011820	View Revisions
2015-03-13 20:39	Dusk	Relationship added	related to 0002122
2015-03-13 20:50	Dusk	Note Added: 0011821
2015-03-13 20:50	Dusk	Status	needs testing => resolved
2015-03-13 20:50	Dusk	Fixed in Version	=> 2.0
2015-03-13 20:50	Dusk	Resolution	open => fixed
2018-09-30 23:03	Blzut3	Status	resolved => closed

Notes
(0011758) Edward-san (developer) 2015-02-25 20:50	Can you reproduce with GZDoom 900? What about GZDoom 1.6?

(0011759) Dusk (developer) 2015-02-25 21:11	I'm 95% sure this is a missing feature that hasn't been ported yet.

(0011760) StrikerMan780 (reporter) 2015-02-25 22:02 edited on: 2015-02-25 22:02	Works fine in GZDoom 900. It's the "Display Nametags" feature. Might as well use that, and delete the Weapon name display code from Skulltag, since it's the exact same feature duplicated, but the (G)ZDoom version supports the tags.

(0011761) Edward-san (developer) 2015-02-26 00:34	What does the console command 'displaynametags' report? If it's 0, what happens if you use 'displaynametags 2'?

(0011762) StrikerMan780 (reporter) 2015-02-26 06:10	If it's on 2, it still doesn't work. It's bugged. (Seems to be conflicting with the older Skulltag implementation.)

(0011764) Dusk (developer) 2015-02-26 14:37	This should fix the behavior and also reduces delta by a nice amount.

(0011767) StrikerMan780 (reporter) 2015-02-28 20:02	Awesome.

(0011786) Torr Samaho (administrator) 2015-03-08 19:19	Dusk, your patch looks fine. If you think it was tested thoroughly enough, I'll pull it into 2.0.

(0011803) cobalt (updater) 2015-03-09 19:16	Issue addressed by commit 2d82e4ba5071: - fixed: weapon nametags weren't properly handled (also reduced delta with ZDoom to make the code more resistant to future merge errors). Fixes 2115. Committed by Teemu Piippo [Dusk] on Thursday 26 February 2015 16:36:53 Changes in files: src/cl_main.cpp \| 17 +++++++++++ src/g_game.cpp \| 205 ++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- 2 files changed, 69 insertions(+), 153 deletions(-)

(0011806) StrikerMan780 (reporter) 2015-03-09 23:57 edited on: 2015-03-10 00:04	Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]' BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point.

(0011812) Torr Samaho (administrator) 2015-03-11 19:41 edited on: 2015-03-11 19:47	Please post a minimal example wad.

(0011813) StrikerMan780 (reporter) 2015-03-11 19:43	An example wad isn't necessary. The default Doom weapons have tags. SuperShotgun should read as "Super Shotgun", RocketLauncher should read as "Rocket Launcher", etc. However, they do not.

(0011814) Torr Samaho (administrator) 2015-03-11 19:47 edited on: 2015-03-11 19:47	Works fine for me offline and online with "displaynametags 2" in my latest local build. EDIT: Shall we change the default value of displaynametags to 2 to mimic the old default behavior, i.e. "cl_showweapnameoncycle 1"?

(0011815) Dusk (developer) 2015-03-11 19:55 edited on: 2015-03-11 19:55	Or add ini migration to translate the change for existing configs? You could use an expression like 'if ( lastver == NULL \|\| atof( lastver ) <= 181 ) { ... }' to match such configs.

(0011816) StrikerMan780 (reporter) 2015-03-11 19:55 edited on: 2015-03-11 19:56	I'd say yes, make it default (dunno why it isn't default in ZDoom as it is). Also, can someone confirm if the build I linked to is out-of-date?

(0011817) Torr Samaho (administrator) 2015-03-12 07:14	Quote from Dusk Or add ini migration to translate the change for existing configs? This will only keep the known behavior for existing users and existing installs. New users (or people who freshly re-install Zandronum) will not have the weapon tags displayed by default then. The ini translation is great if we explicitly want to change some default behavior without bothering existing users, but is this the case here? I actually like the old default behavior.

(0011818) Dusk (developer) 2015-03-12 15:02	Very well then, though if we're going that route, why not set the default all the way to 3? I never saw much point in having name tags only for weapons now that we have tags for items too.

(0011819) Torr Samaho (administrator) 2015-03-13 07:33	Good point. Let's default to 3.

(0011820) Dusk (developer) 2015-03-13 17:30 edited on: 2015-03-13 17:34	Quote from StrikerMan780 Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]' BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point. ]version_info changeset: 339da8a48c22 date: Sun Jan 25 19:00:42 2015 The build is of a changeset almost two months old and does not contain the fix. The filename of the build appears to be incorrect as the version of it is actually 150125-1900. cl_showweapnameoncycle was removed.

(0011821) Dusk (developer) 2015-03-13 20:50	I think it's pretty clear at this point that the feature is working as intended.