MantisBT - Zandronum
View Issue Details
0002115Zandronum[All Projects] Bugpublic2015-02-25 18:512018-09-30 23:03
StrikerMan780 
Dusk 
normalminoralways
closedfixed 
MicrosoftWindowsXP/Vista/7
2.0-beta 
2.02.0 
0002115: "Tag" Weapon Actory Property is Ignored
It looks like the "Tag" property is accepted for weapons in Zandronum 2.0, however, it does not actually show the name of the weapon given when picking weapons with the scroll wheel. Instead, it just shows the classname.
No tags attached.
related to 0002122closed Torr Samaho Typo "Plama Rifle" in weapon tag 
Issue History
2015-02-25 18:51StrikerMan780New Issue
2015-02-25 20:50Edward-sanNote Added: 0011758
2015-02-25 21:11DuskNote Added: 0011759
2015-02-25 22:02StrikerMan780Note Added: 0011760
2015-02-25 22:02StrikerMan780Note Edited: 0011760bug_revision_view_page.php?bugnote_id=11760#r6705
2015-02-26 00:34Edward-sanNote Added: 0011761
2015-02-26 06:10StrikerMan780Note Added: 0011762
2015-02-26 12:05DuskAssigned To => Dusk
2015-02-26 12:05DuskStatusnew => assigned
2015-02-26 12:32DuskTarget Version => 2.0
2015-02-26 14:37DuskNote Added: 0011764
2015-02-26 14:37DuskStatusassigned => needs review
2015-02-28 20:02StrikerMan780Note Added: 0011767
2015-03-08 19:19Torr SamahoNote Added: 0011786
2015-03-08 19:19Torr SamahoStatusneeds review => feedback
2015-03-09 19:16cobaltStatusfeedback => needs testing
2015-03-09 19:16cobaltNote Added: 0011803
2015-03-09 23:57StrikerMan780Note Added: 0011806
2015-03-09 23:58StrikerMan780Note Edited: 0011806bug_revision_view_page.php?bugnote_id=11806#r6751
2015-03-09 23:59StrikerMan780Note Edited: 0011806bug_revision_view_page.php?bugnote_id=11806#r6752
2015-03-10 00:04StrikerMan780Note Edited: 0011806bug_revision_view_page.php?bugnote_id=11806#r6753
2015-03-11 19:41Torr SamahoNote Added: 0011812
2015-03-11 19:43StrikerMan780Note Added: 0011813
2015-03-11 19:44Torr SamahoNote Edited: 0011812
2015-03-11 19:47Torr SamahoNote Added: 0011814
2015-03-11 19:47Torr SamahoNote Edited: 0011812bug_revision_view_page.php?bugnote_id=11812#r6764
2015-03-11 19:47Torr SamahoNote Edited: 0011814bug_revision_view_page.php?bugnote_id=11814#r6766
2015-03-11 19:49Torr SamahoNote Revision Dropped: 11812: 0006763
2015-03-11 19:49Torr SamahoNote Revision Dropped: 11812: 0006762
2015-03-11 19:55DuskNote Added: 0011815
2015-03-11 19:55DuskNote Edited: 0011815bug_revision_view_page.php?bugnote_id=11815#r6768
2015-03-11 19:55StrikerMan780Note Added: 0011816
2015-03-11 19:56StrikerMan780Note Edited: 0011816bug_revision_view_page.php?bugnote_id=11816#r6770
2015-03-12 07:14Torr SamahoNote Added: 0011817
2015-03-12 15:02DuskNote Added: 0011818
2015-03-13 07:33Torr SamahoNote Added: 0011819
2015-03-13 17:30DuskNote Added: 0011820
2015-03-13 17:30DuskNote Edited: 0011820bug_revision_view_page.php?bugnote_id=11820#r6772
2015-03-13 17:30DuskNote Edited: 0011820bug_revision_view_page.php?bugnote_id=11820#r6773
2015-03-13 17:31DuskNote Edited: 0011820bug_revision_view_page.php?bugnote_id=11820#r6774
2015-03-13 17:34DuskNote Edited: 0011820bug_revision_view_page.php?bugnote_id=11820#r6775
2015-03-13 20:39DuskRelationship addedrelated to 0002122
2015-03-13 20:50DuskNote Added: 0011821
2015-03-13 20:50DuskStatusneeds testing => resolved
2015-03-13 20:50DuskFixed in Version => 2.0
2015-03-13 20:50DuskResolutionopen => fixed
2018-09-30 23:03Blzut3Statusresolved => closed

Notes
(0011758)
Edward-san   
2015-02-25 20:50   
Can you reproduce with GZDoom 900? What about GZDoom 1.6?
(0011759)
Dusk   
2015-02-25 21:11   
I'm 95% sure this is a missing feature that hasn't been ported yet.
(0011760)
StrikerMan780   
2015-02-25 22:02   
Works fine in GZDoom 900. It's the "Display Nametags" feature. Might as well use that, and delete the Weapon name display code from Skulltag, since it's the exact same feature duplicated, but the (G)ZDoom version supports the tags.

(0011761)
Edward-san   
2015-02-26 00:34   
What does the console command 'displaynametags' report? If it's 0, what happens if you use 'displaynametags 2'?
(0011762)
StrikerMan780   
2015-02-26 06:10   
If it's on 2, it still doesn't work. It's bugged. (Seems to be conflicting with the older Skulltag implementation.)
(0011764)
Dusk   
2015-02-26 14:37   
This should fix the behavior and also reduces delta by a nice amount.
(0011767)
StrikerMan780   
2015-02-28 20:02   
Awesome.
(0011786)
Torr Samaho   
2015-03-08 19:19   
Dusk, your patch looks fine. If you think it was tested thoroughly enough, I'll pull it into 2.0.
(0011803)
cobalt   
2015-03-09 19:16   
Issue addressed by commit 2d82e4ba5071: - fixed: weapon nametags weren't properly handled (also reduced delta with ZDoom to make the code more resistant to future merge errors). Fixes 2115.
Committed by Teemu Piippo [Dusk] on Thursday 26 February 2015 16:36:53

Changes in files:
 src/cl_main.cpp | 17 +++++++++++
 src/g_game.cpp | 205 ++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------------------------
 2 files changed, 69 insertions(+), 153 deletions(-)
(0011806)
StrikerMan780   
2015-03-09 23:57   
(edited on: 2015-03-10 00:04)
Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]'

BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point.

(0011812)
Torr Samaho   
2015-03-11 19:41   
(edited on: 2015-03-11 19:47)
Please post a minimal example wad.

(0011813)
StrikerMan780   
2015-03-11 19:43   
An example wad isn't necessary. The default Doom weapons have tags.

SuperShotgun should read as "Super Shotgun", RocketLauncher should read as "Rocket Launcher", etc. However, they do not.
(0011814)
Torr Samaho   
2015-03-11 19:47   
Works fine for me offline and online with "displaynametags 2" in my latest local build.

EDIT: Shall we change the default value of displaynametags to 2 to mimic the old default behavior, i.e. "cl_showweapnameoncycle 1"?

(0011815)
Dusk   
2015-03-11 19:55   
Or add ini migration to translate the change for existing configs?
You could use an expression like 'if ( lastver == NULL || atof( lastver ) <= 181 ) { ... }' to match such configs.

(0011816)
StrikerMan780   
2015-03-11 19:55   
(edited on: 2015-03-11 19:56)
I'd say yes, make it default (dunno why it isn't default in ZDoom as it is).

Also, can someone confirm if the build I linked to is out-of-date?

(0011817)
Torr Samaho   
2015-03-12 07:14   
Quote from Dusk
Or add ini migration to translate the change for existing configs?
This will only keep the known behavior for existing users and existing installs. New users (or people who freshly re-install Zandronum) will not have the weapon tags displayed by default then.

The ini translation is great if we explicitly want to change some default behavior without bothering existing users, but is this the case here? I actually like the old default behavior.
(0011818)
Dusk   
2015-03-12 15:02   
Very well then, though if we're going that route, why not set the default all the way to 3? I never saw much point in having name tags only for weapons now that we have tags for items too.
(0011819)
Torr Samaho   
2015-03-13 07:33   
Good point. Let's default to 3.
(0011820)
Dusk   
2015-03-13 17:30   
(edited on: 2015-03-13 17:34)
Quote from StrikerMan780

Works for inventory items now, but weapons are still ignored as far as this build is concerned:'http://s1.plusreed.com/jenkins/zandronum/zandronum-150309-1742_936.zip [^]'

BTW, cl_showweapnameoncycle should just be removed. It's redundant functionality at this point.


]version_info
changeset: 339da8a48c22
date: Sun Jan 25 19:00:42 2015

The build is of a changeset almost two months old and does not contain the fix. The filename of the build appears to be incorrect as the version of it is actually 150125-1900. cl_showweapnameoncycle was removed.

(0011821)
Dusk   
2015-03-13 20:50   
I think it's pretty clear at this point that the feature is working as intended.