0002078: SetActivatorToTarget is broken with "Autoaim: Never".

Notes
(0011527) Torr Samaho (administrator) 2015-01-25 10:19	Does it work in GZDoom 900?

(0011528) Edward-san (developer) 2015-01-25 10:42 edited on: 2015-01-25 12:08	Actually, it's broken somehow in 1.4, with the same symptoms ... [edit]If I enable compat_autoaim, the bug disappears. [edit2] The problem started from commit 18219b6dc864 , which introduced the compat flag. [edit3] This code: i = compatflags2 & COMPATF2_AUTOAIM ? 2 : 14; // [CK] Our starting index depends on compatflags. is wrong because its logic is reverted. Changing that code to: i = compatflags2 & COMPATF2_AUTOAIM ? 14 : 2; // [CK] Our starting index depends on compatflags. works. Also, the angdiff table should avoid doing shift of negative values! Although, even if we fix these problems, the fact that when compat_autoaim is on, the problem shows up, it's still considered as a bug, right? [edit4] Ok, if I move the third value of angdiff, which is 0, to the last position, it works also with compat_autoaim on.

(0011536) Edward-san (developer) 2015-01-25 12:25	In zdoom, 0 is processed first, then the two angles. In zandronum, since the compat_autoaim introduces other angles, which order of processing is the right one?

(0011538) Torr Samaho (administrator) 2015-01-25 12:51	I cannot say what Water was intending here, but I'd say that Zandronum should do the same as ZDoom and process 0 first in all cases.

(0011544) Dusk (developer) 2015-01-25 19:01	'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/62 [^]'

(0011576) cobalt (updater) 2015-02-01 11:31	Issue addressed by commit 339da8a48c22: - corrected the implementation of compat_autoaim; it processed angles in the wrong order, causing 'autoaim: never' to be intepreted incorrectly (fixes 2078) Committed by Teemu Piippo [Dusk] on Sunday 25 January 2015 21:00:42 Changes in files: src/p_pspr.cpp \| 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-)

(0011769) WaTaKiD (updater) 2015-03-05 01:37	after testing with 2.0-r150224-1833, issue seems fixed

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-01-22 10:38	hjalg	New Issue
2015-01-22 10:38	hjalg	File Added: SetActivatorToTarget_2.0.wad
2015-01-25 10:19	Torr Samaho	Note Added: 0011527
2015-01-25 10:42	Edward-san	Note Added: 0011528
2015-01-25 10:42	Edward-san	Product Version	2.0-beta => 1.4
2015-01-25 10:43	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 11:09	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 11:09	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 11:19	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 12:00	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 12:00	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 12:03	Edward-san	Relationship added	related to 0001226
2015-01-25 12:08	Edward-san	Note Edited: 0011528	View Revisions
2015-01-25 12:25	Edward-san	Note Added: 0011536
2015-01-25 12:51	Torr Samaho	Note Added: 0011538
2015-01-25 18:42	Dusk	Assigned To	=> Dusk
2015-01-25 18:42	Dusk	Status	new => assigned
2015-01-25 19:01	Dusk	Note Added: 0011544
2015-01-25 19:01	Dusk	Status	assigned => needs review
2015-02-01 11:31	cobalt	Status	needs review => needs testing
2015-02-01 11:31	cobalt	Target Version	=> 2.0
2015-02-01 11:31	cobalt	Note Added: 0011576
2015-03-05 01:37	WaTaKiD	Note Added: 0011769
2015-03-05 02:03	Dusk	Status	needs testing => resolved
2015-03-05 02:03	Dusk	Fixed in Version	=> 2.0
2015-03-05 02:03	Dusk	Resolution	open => fixed
2018-09-30 23:04	Blzut3	Status	resolved => closed