MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002078Zandronum[All Projects] Bugpublic2015-01-22 10:382018-09-30 23:04
Reporterhjalg 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version8.1
Product Version1.4 
Target Version2.0Fixed in Version2.0 
Summary0002078: SetActivatorToTarget is broken with "Autoaim: Never".
DescriptionWhen you turn off your autoaim you should be able to aim perfectly to an actor's hitbox, but you have to aim to an empty space on the right side of the actor instead.
Steps To Reproduce
Additional InformationWorks as intended in 1.3 but broken in 2.0. Tested with clean zandronum.ini configs in opengl/software modes.
TagsNo tags attached.
Relationships
related to 0001226closed Watermelon Leniency with vertical autoaim 
Attached Files? SetActivatorToTarget_2.0.wad (2,572) 2015-01-22 10:38
/tracker/file_download.php?file_id=1390&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-01-22 10:38hjalgNew Issue
2015-01-22 10:38hjalgFile Added: SetActivatorToTarget_2.0.wad
2015-01-25 10:19Torr SamahoNote Added: 0011527
2015-01-25 10:42Edward-sanNote Added: 0011528
2015-01-25 10:42Edward-sanProduct Version2.0-beta => 1.4
2015-01-25 10:43Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6521
2015-01-25 11:09Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6524
2015-01-25 11:09Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6525
2015-01-25 11:19Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6526
2015-01-25 12:00Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6531
2015-01-25 12:00Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6532
2015-01-25 12:03Edward-sanRelationship addedrelated to 0001226
2015-01-25 12:08Edward-sanNote Edited: 0011528bug_revision_view_page.php?bugnote_id=11528#r6533
2015-01-25 12:25Edward-sanNote Added: 0011536
2015-01-25 12:51Torr SamahoNote Added: 0011538
2015-01-25 18:42DuskAssigned To => Dusk
2015-01-25 18:42DuskStatusnew => assigned
2015-01-25 19:01DuskNote Added: 0011544
2015-01-25 19:01DuskStatusassigned => needs review
2015-02-01 11:31cobaltStatusneeds review => needs testing
2015-02-01 11:31cobaltTarget Version => 2.0
2015-02-01 11:31cobaltNote Added: 0011576
2015-03-05 01:37WaTaKiDNote Added: 0011769
2015-03-05 02:03DuskStatusneeds testing => resolved
2015-03-05 02:03DuskFixed in Version => 2.0
2015-03-05 02:03DuskResolutionopen => fixed
2018-09-30 23:04Blzut3Statusresolved => closed

Notes
(0011527)
Torr Samaho   
2015-01-25 10:19   
Does it work in GZDoom 900?
(0011528)
Edward-san   
2015-01-25 10:42   
(edited on: 2015-01-25 12:08)
Actually, it's broken somehow in 1.4, with the same symptoms ...

[edit]If I enable compat_autoaim, the bug disappears.

[edit2] The problem started from commit 18219b6dc864 , which introduced the compat flag.

[edit3] This code:


i = compatflags2 & COMPATF2_AUTOAIM ? 2 : 14; // [CK] Our starting index depends on compatflags.

is wrong because its logic is reverted. Changing that code to:


i = compatflags2 & COMPATF2_AUTOAIM ? 14 : 2; // [CK] Our starting index depends on compatflags.


works. Also, the angdiff table should avoid doing shift of negative values!

Although, even if we fix these problems, the fact that when compat_autoaim is on, the problem shows up, it's still considered as a bug, right?

[edit4] Ok, if I move the third value of angdiff, which is 0, to the last position, it works also with compat_autoaim on.
(0011536)
Edward-san   
2015-01-25 12:25   
In zdoom, 0 is processed first, then the two angles. In zandronum, since the compat_autoaim introduces other angles, which order of processing is the right one?
(0011538)
Torr Samaho   
2015-01-25 12:51   
I cannot say what Water was intending here, but I'd say that Zandronum should do the same as ZDoom and process 0 first in all cases.
(0011544)
Dusk   
2015-01-25 19:01   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/62 [^]'
(0011576)
cobalt   
2015-02-01 11:31   
Issue addressed by commit 339da8a48c22: - corrected the implementation of compat_autoaim; it processed angles in the wrong order, causing 'autoaim: never' to be intepreted incorrectly (fixes 2078)
Committed by Teemu Piippo [Dusk] on Sunday 25 January 2015 21:00:42

Changes in files:
 src/p_pspr.cpp | 14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)
(0011769)
WaTaKiD   
2015-03-05 01:37   
after testing with 2.0-r150224-1833, issue seems fixed